Menu

fb-contrib: Version 6.8.0 released

fb-contrib is a bug detector plugin for the FindBugs application (https://github.com/findbugsproject/findbugs).
This release adds four detectors that can easily be integrated into FindBugs by dropping the jar file into FindBugs' plugin directory. fb-contrib version 6.8.0 requires FindBugs version 3.0.1 or later. This version of fb-contrib uses java 1.7.

New Detectors added in this release:

Dubious Map Collection
Looks for fields that are implementations of java.util.Map, but that are only ever iterated over. This probably means that this data structure should be a List of some class that holds two values, or at the least Pair. Map was probably choosen as it was the easiest thing to use, but obfuscates the reason for the data structure.

Burying Logic
Looks for relatively large if blocks of code, where you unconditionally return from them, and then follow that with an unconditional return of a small block. This places the bulk of the logic to the right indentation-wise, making it more difficult to read than needed. It would be better to invert the logic of the if block, and immediately return, allowing the bulk of the logic to be move to the left, for easier reading.

Wiring Issues
Looks for various issues around @Autowired/@Inject fields in DI classes
Injecting the same bean twice into the same class hierarchy, even with different field names

Concurrent Collection Issues
Looks for various issues around using concurrent collections including
* Using get/put with collection values, when you should use putIfAbsent

Posted by Dave Brosius 2016-10-10

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.