[Fb-contrib-commit] SF.net SVN: fb-contrib: [936] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/SillynessPotPourri.java

[<dbr...@us...>]

Revision: 936
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=936&view=rev
Author:   dbrosius
Date:     2007-10-12 21:49:06 -0700 (Fri, 12 Oct 2007)

Log Message:
-----------
guard against a non initialized lastPCs array

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2007-10-13 03:30:42 UTC (rev 935)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2007-10-13 04:49:06 UTC (rev 936)
@@ -92,7 +92,8 @@
 			
 			if (seen == ICONST_0) {
 				byte[] bytes = getCode().getCode();
-				if (((0x00FF & bytes[lastPCs[3]]) == GOTO) 
+				if ((lastPCs[3] != -1)
+				&&  ((0x00FF & bytes[lastPCs[3]]) == GOTO) 
 				&&  ((0x00FF & bytes[lastPCs[2]]) == ICONST_1)
 				&&  ((0x00FF & bytes[lastPCs[1]]) == IFEQ)) {
 					bugReporter.reportBug(new BugInstance(this, "SPP_USELESS_TRINARY", NORMAL_PRIORITY)


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.