[Fb-contrib-commit] SF.net SVN: fb-contrib: [928] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/ExceptionSoftening.java

[<dbr...@us...>]

Revision: 928
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=928&view=rev
Author:   dbrosius
Date:     2007-10-07 18:42:30 -0700 (Sun, 07 Oct 2007)

Log Message:
-----------
set priority based on subtype of bug

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ExceptionSoftening.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ExceptionSoftening.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ExceptionSoftening.java	2007-10-08 01:39:46 UTC (rev 927)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ExceptionSoftening.java	2007-10-08 01:42:30 UTC (rev 928)
@@ -167,10 +167,16 @@
 											constrainingInfo = getConstrainingInfo(getClassContext().getJavaClass(), getMethod());
 			
 										String bug = null;
-										if (constrainingInfo == null)
+										int priority = NORMAL_PRIORITY;
+										
+										if (constrainingInfo == null) {
 											bug = "EXS_EXCEPTION_SOFTENING_NO_CONSTRAINTS";
-										else if (!constrainingInfo.values().iterator().next().isEmpty())
+											priority = HIGH_PRIORITY;
+										}
+										else if (!constrainingInfo.values().iterator().next().isEmpty()) {
 											bug = "EXS_EXCEPTION_SOFTENING_HAS_CHECKED";
+											priority = NORMAL_PRIORITY;
+										}
 										else {
 											String pack1 = constrainingInfo.keySet().iterator().next();
 											String pack2 = getClassContext().getJavaClass().getClassName();
@@ -184,12 +190,14 @@
 												pack2 = pack2.substring(0, dotPos);
 											else
 												pack2 = "";
-											if (SignatureUtils.similarPackages(pack1, pack2, 2))
+											if (SignatureUtils.similarPackages(pack1, pack2, 2)) {
 												bug = "EXS_EXCEPTION_SOFTENING_NO_CHECKED";
+												priority = NORMAL_PRIORITY;
+											}
 										}
 										
 										if (bug != null) {
-											bugReporter.reportBug(new BugInstance(this, bug, NORMAL_PRIORITY)
+											bugReporter.reportBug(new BugInstance(this, bug, priority)
 														.addClass(this)
 														.addMethod(this)
 														.addSourceLine(this));


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.