[Fb-contrib-commit] SF.net SVN: fb-contrib:[1816] trunk/fb-contrib
Brought to you by:
dbrosius
From: <dbr...@us...> - 2017-04-09 22:42:36
|
Revision: 1816 http://sourceforge.net/p/fb-contrib/code/1816 Author: dbrosius Date: 2017-04-09 22:42:29 +0000 (Sun, 09 Apr 2017) Log Message: ----------- sync from github Modified Paths: -------------- trunk/fb-contrib/build.xml trunk/fb-contrib/etc/findbugs.xml trunk/fb-contrib/etc/messages.xml trunk/fb-contrib/pom.xml trunk/fb-contrib/samples.xml trunk/fb-contrib/src/main/java/com/mebigfatguy/fbcontrib/collect/CollectStatistics.java trunk/fb-contrib/src/main/java/com/mebigfatguy/fbcontrib/detect/BloatedAssignmentScope.java trunk/fb-contrib/src/main/java/com/mebigfatguy/fbcontrib/detect/BuryingLogic.java trunk/fb-contrib/src/main/java/com/mebigfatguy/fbcontrib/detect/CommonsStringBuilderToString.java trunk/fb-contrib/src/main/java/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java trunk/fb-contrib/src/main/java/com/mebigfatguy/fbcontrib/detect/CopiedOverriddenMethod.java trunk/fb-contrib/src/main/java/com/mebigfatguy/fbcontrib/detect/DeletingWhileIterating.java trunk/fb-contrib/src/main/java/com/mebigfatguy/fbcontrib/detect/FieldCouldBeLocal.java trunk/fb-contrib/src/main/java/com/mebigfatguy/fbcontrib/detect/HangingExecutors.java trunk/fb-contrib/src/main/java/com/mebigfatguy/fbcontrib/detect/OptionalIssues.java trunk/fb-contrib/src/main/java/com/mebigfatguy/fbcontrib/detect/OverlyPermissiveMethod.java trunk/fb-contrib/src/main/java/com/mebigfatguy/fbcontrib/detect/PossiblyRedundantMethodCalls.java trunk/fb-contrib/src/main/java/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java trunk/fb-contrib/src/main/java/com/mebigfatguy/fbcontrib/detect/SpoiledChildInterfaceImplementor.java trunk/fb-contrib/src/main/java/com/mebigfatguy/fbcontrib/detect/SuspiciousComparatorReturnValues.java trunk/fb-contrib/src/main/java/com/mebigfatguy/fbcontrib/detect/SuspiciousLoopSearch.java trunk/fb-contrib/src/main/java/com/mebigfatguy/fbcontrib/detect/UseAddAll.java trunk/fb-contrib/src/main/java/com/mebigfatguy/fbcontrib/detect/UseEnumCollections.java trunk/fb-contrib/src/main/java/com/mebigfatguy/fbcontrib/detect/WiringIssues.java trunk/fb-contrib/src/main/java/com/mebigfatguy/fbcontrib/utils/QMethod.java Added Paths: ----------- trunk/fb-contrib/src/samples/java/ex/ trunk/fb-contrib/src/samples/java/ex/ABC_Sample.java trunk/fb-contrib/src/samples/java/ex/ACEM_Sample.java trunk/fb-contrib/src/samples/java/ex/AFBR_Sample.java trunk/fb-contrib/src/samples/java/ex/AIOB_Sample.java trunk/fb-contrib/src/samples/java/ex/AOM_Sample.java trunk/fb-contrib/src/samples/java/ex/AWCBR_Sample.java trunk/fb-contrib/src/samples/java/ex/BAS_Sample.java trunk/fb-contrib/src/samples/java/ex/BED_Sample.java trunk/fb-contrib/src/samples/java/ex/BL_Sample.java trunk/fb-contrib/src/samples/java/ex/BRPI_Sample.java trunk/fb-contrib/src/samples/java/ex/BSB_Sample.java trunk/fb-contrib/src/samples/java/ex/CAAL_Sample.java trunk/fb-contrib/src/samples/java/ex/CAO_Sample.java trunk/fb-contrib/src/samples/java/ex/CBC_Sample.java trunk/fb-contrib/src/samples/java/ex/CBX_Sample.java trunk/fb-contrib/src/samples/java/ex/CCI_Sample.java trunk/fb-contrib/src/samples/java/ex/CCNE_Sample.java trunk/fb-contrib/src/samples/java/ex/CEBE_EqualsToEqualsSample.java trunk/fb-contrib/src/samples/java/ex/CE_Sample.java trunk/fb-contrib/src/samples/java/ex/CFS_Sample.java trunk/fb-contrib/src/samples/java/ex/CHBH_HashcodeToHashcodeSample.java trunk/fb-contrib/src/samples/java/ex/CLI_Sample.java trunk/fb-contrib/src/samples/java/ex/CNC_Sample.java trunk/fb-contrib/src/samples/java/ex/COM_Sample.java trunk/fb-contrib/src/samples/java/ex/CRF_Sample.java trunk/fb-contrib/src/samples/java/ex/CSBTS_StringToStringSample.java trunk/fb-contrib/src/samples/java/ex/CSI_Sample.java trunk/fb-contrib/src/samples/java/ex/CTU_Sample.java trunk/fb-contrib/src/samples/java/ex/CU_Sample.java trunk/fb-contrib/src/samples/java/ex/CVAA_Sample.java trunk/fb-contrib/src/samples/java/ex/DDC_Sample.java trunk/fb-contrib/src/samples/java/ex/DLC_Sample.java trunk/fb-contrib/src/samples/java/ex/DMC_Sample.java trunk/fb-contrib/src/samples/java/ex/DRE_Sample.java trunk/fb-contrib/src/samples/java/ex/DSOC_Sample.java trunk/fb-contrib/src/samples/java/ex/DTEP_Sample.java trunk/fb-contrib/src/samples/java/ex/DWI_Sample.java trunk/fb-contrib/src/samples/java/ex/EXS_Sample.java trunk/fb-contrib/src/samples/java/ex/FCBL_Sample.java trunk/fb-contrib/src/samples/java/ex/FCCD_Sample.java trunk/fb-contrib/src/samples/java/ex/FPL_Sample.java trunk/fb-contrib/src/samples/java/ex/FP_Sample.java trunk/fb-contrib/src/samples/java/ex/HCP_Sample.java trunk/fb-contrib/src/samples/java/ex/HES_Sample.java trunk/fb-contrib/src/samples/java/ex/ICA_Sample.java trunk/fb-contrib/src/samples/java/ex/IICU_Sample.java trunk/fb-contrib/src/samples/java/ex/IKNC_Sample.java trunk/fb-contrib/src/samples/java/ex/IMC_Sample.java trunk/fb-contrib/src/samples/java/ex/IOI_Sample.java trunk/fb-contrib/src/samples/java/ex/IPU_Sample.java trunk/fb-contrib/src/samples/java/ex/ISB_Sample.java trunk/fb-contrib/src/samples/java/ex/ITC_Sample.java trunk/fb-contrib/src/samples/java/ex/ITU_Sample.java trunk/fb-contrib/src/samples/java/ex/JPAI_Sample.java trunk/fb-contrib/src/samples/java/ex/JVR_Sample.java trunk/fb-contrib/src/samples/java/ex/JXI_Sample.java trunk/fb-contrib/src/samples/java/ex/LEST_Sample.java trunk/fb-contrib/src/samples/java/ex/LGO_Sample.java trunk/fb-contrib/src/samples/java/ex/LII_Sample.java trunk/fb-contrib/src/samples/java/ex/LO_Sample.java trunk/fb-contrib/src/samples/java/ex/LSC_Sample.java trunk/fb-contrib/src/samples/java/ex/LSYC_Sample.java trunk/fb-contrib/src/samples/java/ex/MAC_Sample.java trunk/fb-contrib/src/samples/java/ex/MDM_Sample.java trunk/fb-contrib/src/samples/java/ex/MOM_Sample.java trunk/fb-contrib/src/samples/java/ex/MRC_Sample.java trunk/fb-contrib/src/samples/java/ex/MTA_Sample.java trunk/fb-contrib/src/samples/java/ex/MUC_Sample.java trunk/fb-contrib/src/samples/java/ex/NAB_Sample.java trunk/fb-contrib/src/samples/java/ex/NCMU_Sample.java trunk/fb-contrib/src/samples/java/ex/NCS_Sample.java trunk/fb-contrib/src/samples/java/ex/NFF_Sample.java trunk/fb-contrib/src/samples/java/ex/NIR_Sample.java trunk/fb-contrib/src/samples/java/ex/NMCS_Sample.java trunk/fb-contrib/src/samples/java/ex/NOS_Sample.java trunk/fb-contrib/src/samples/java/ex/NPMC_Sample.java trunk/fb-contrib/src/samples/java/ex/NRTL_Sample.java trunk/fb-contrib/src/samples/java/ex/NSE_Sample.java trunk/fb-contrib/src/samples/java/ex/OCP_Sample.java trunk/fb-contrib/src/samples/java/ex/OC_Sample.java trunk/fb-contrib/src/samples/java/ex/ODN_Sample.java trunk/fb-contrib/src/samples/java/ex/OI_Sample.java trunk/fb-contrib/src/samples/java/ex/OPM_Sample.java trunk/fb-contrib/src/samples/java/ex/PCAIL_Sample.java trunk/fb-contrib/src/samples/java/ex/PCOA_Sample.java trunk/fb-contrib/src/samples/java/ex/PDP_Sample.java trunk/fb-contrib/src/samples/java/ex/PIS_Sample.java trunk/fb-contrib/src/samples/java/ex/PL_Sample.java trunk/fb-contrib/src/samples/java/ex/PMB_Sample.java trunk/fb-contrib/src/samples/java/ex/PME_Sample.java trunk/fb-contrib/src/samples/java/ex/PRMC_Sample.java trunk/fb-contrib/src/samples/java/ex/PSC_Sample.java trunk/fb-contrib/src/samples/java/ex/PUS_Sample.java trunk/fb-contrib/src/samples/java/ex/ROOM_Sample.java trunk/fb-contrib/src/samples/java/ex/S508C_Sample.java trunk/fb-contrib/src/samples/java/ex/SACM_Sample.java trunk/fb-contrib/src/samples/java/ex/SCA_Sample.java trunk/fb-contrib/src/samples/java/ex/SCII_Sample.java trunk/fb-contrib/src/samples/java/ex/SCI_Sample.java trunk/fb-contrib/src/samples/java/ex/SCRV_Sample.java trunk/fb-contrib/src/samples/java/ex/SCR_Sample.java trunk/fb-contrib/src/samples/java/ex/SCSS_Sample.java trunk/fb-contrib/src/samples/java/ex/SEC_Sample.java trunk/fb-contrib/src/samples/java/ex/SEO_Sample.java trunk/fb-contrib/src/samples/java/ex/SGSU_Sample.java trunk/fb-contrib/src/samples/java/ex/SG_Sample.java trunk/fb-contrib/src/samples/java/ex/SIL_Sample.java trunk/fb-contrib/src/samples/java/ex/SJVU_Sample.java trunk/fb-contrib/src/samples/java/ex/SLS_Sample.java trunk/fb-contrib/src/samples/java/ex/SMII_Sample.java trunk/fb-contrib/src/samples/java/ex/SNG_Sample.java trunk/fb-contrib/src/samples/java/ex/SPP_Sample.java trunk/fb-contrib/src/samples/java/ex/SSCU_Sample.java trunk/fb-contrib/src/samples/java/ex/STB_Sample.java trunk/fb-contrib/src/samples/java/ex/STS_Sample.java trunk/fb-contrib/src/samples/java/ex/STT_Sample.java trunk/fb-contrib/src/samples/java/ex/SUA_Sample.java trunk/fb-contrib/src/samples/java/ex/SWCO_Sample.java trunk/fb-contrib/src/samples/java/ex/TBP_Sample.java trunk/fb-contrib/src/samples/java/ex/TR_Sample.java trunk/fb-contrib/src/samples/java/ex/UAA_Sample.java trunk/fb-contrib/src/samples/java/ex/UCC_Sample.java trunk/fb-contrib/src/samples/java/ex/UCPM_Sample.java trunk/fb-contrib/src/samples/java/ex/UEC_Sample.java trunk/fb-contrib/src/samples/java/ex/UMTP_Sample.java trunk/fb-contrib/src/samples/java/ex/UNNC_Sample.java trunk/fb-contrib/src/samples/java/ex/UP_Sample.java trunk/fb-contrib/src/samples/java/ex/URV_Sample.java trunk/fb-contrib/src/samples/java/ex/USBR_Sample.java trunk/fb-contrib/src/samples/java/ex/USFW_Sample.java trunk/fb-contrib/src/samples/java/ex/USS_Sample.java trunk/fb-contrib/src/samples/java/ex/UTAO_Sample.java trunk/fb-contrib/src/samples/java/ex/UTA_Sample.java trunk/fb-contrib/src/samples/java/ex/UTWR_Sample.java trunk/fb-contrib/src/samples/java/ex/UVA_Sample.java trunk/fb-contrib/src/samples/java/ex/WEM_Sample.java trunk/fb-contrib/src/samples/java/ex/WI_Sample.java trunk/fb-contrib/src/samples/java/ex/WOC_Sample.java Removed Paths: ------------- trunk/fb-contrib/src/samples/java/ABC_Sample.java trunk/fb-contrib/src/samples/java/ACEM_Sample.java trunk/fb-contrib/src/samples/java/AFBR_Sample.java trunk/fb-contrib/src/samples/java/AIOB_Sample.java trunk/fb-contrib/src/samples/java/AOM_Sample.java trunk/fb-contrib/src/samples/java/AWCBR_Sample.java trunk/fb-contrib/src/samples/java/BAS_Sample.java trunk/fb-contrib/src/samples/java/BED_Sample.java trunk/fb-contrib/src/samples/java/BL_Sample.java trunk/fb-contrib/src/samples/java/BRPI_Sample.java trunk/fb-contrib/src/samples/java/BSB_Sample.java trunk/fb-contrib/src/samples/java/CAAL_Sample.java trunk/fb-contrib/src/samples/java/CAO_Sample.java trunk/fb-contrib/src/samples/java/CBC_Sample.java trunk/fb-contrib/src/samples/java/CBX_Sample.java trunk/fb-contrib/src/samples/java/CCI_Sample.java trunk/fb-contrib/src/samples/java/CCNE_Sample.java trunk/fb-contrib/src/samples/java/CEBE_EqualsToEqualsSample.java trunk/fb-contrib/src/samples/java/CE_Sample.java trunk/fb-contrib/src/samples/java/CFS_Sample.java trunk/fb-contrib/src/samples/java/CHBH_HashcodeToHashcodeSample.java trunk/fb-contrib/src/samples/java/CLI_Sample.java trunk/fb-contrib/src/samples/java/CNC_Sample.java trunk/fb-contrib/src/samples/java/COM_Sample.java trunk/fb-contrib/src/samples/java/CRF_Sample.java trunk/fb-contrib/src/samples/java/CSBTS_StringToStringSample.java trunk/fb-contrib/src/samples/java/CSI_Sample.java trunk/fb-contrib/src/samples/java/CTU_Sample.java trunk/fb-contrib/src/samples/java/CU_Sample.java trunk/fb-contrib/src/samples/java/CVAA_Sample.java trunk/fb-contrib/src/samples/java/DDC_Sample.java trunk/fb-contrib/src/samples/java/DLC_Sample.java trunk/fb-contrib/src/samples/java/DMC_Sample.java trunk/fb-contrib/src/samples/java/DRE_Sample.java trunk/fb-contrib/src/samples/java/DSOC_Sample.java trunk/fb-contrib/src/samples/java/DTEP_Sample.java trunk/fb-contrib/src/samples/java/DWI_Sample.java trunk/fb-contrib/src/samples/java/EXS_Sample.java trunk/fb-contrib/src/samples/java/FCBL_Sample.java trunk/fb-contrib/src/samples/java/FCCD_Sample.java trunk/fb-contrib/src/samples/java/FPL_Sample.java trunk/fb-contrib/src/samples/java/FP_Sample.java trunk/fb-contrib/src/samples/java/HCP_Sample.java trunk/fb-contrib/src/samples/java/HES_Sample.java trunk/fb-contrib/src/samples/java/ICA_Sample.java trunk/fb-contrib/src/samples/java/IICU_Sample.java trunk/fb-contrib/src/samples/java/IKNC_Sample.java trunk/fb-contrib/src/samples/java/IMC_Sample.java trunk/fb-contrib/src/samples/java/IOI_Sample.java trunk/fb-contrib/src/samples/java/IPU_Sample.java trunk/fb-contrib/src/samples/java/ISB_Sample.java trunk/fb-contrib/src/samples/java/ITC_Sample.java trunk/fb-contrib/src/samples/java/ITU_Sample.java trunk/fb-contrib/src/samples/java/JPAI_Sample.java trunk/fb-contrib/src/samples/java/JVR_Sample.java trunk/fb-contrib/src/samples/java/JXI_Sample.java trunk/fb-contrib/src/samples/java/LEST_Sample.java trunk/fb-contrib/src/samples/java/LGO_Sample.java trunk/fb-contrib/src/samples/java/LII_Sample.java trunk/fb-contrib/src/samples/java/LO_Sample.java trunk/fb-contrib/src/samples/java/LSC_Sample.java trunk/fb-contrib/src/samples/java/LSYC_Sample.java trunk/fb-contrib/src/samples/java/MAC_Sample.java trunk/fb-contrib/src/samples/java/MDM_Sample.java trunk/fb-contrib/src/samples/java/MOM_Sample.java trunk/fb-contrib/src/samples/java/MRC_Sample.java trunk/fb-contrib/src/samples/java/MTA_Sample.java trunk/fb-contrib/src/samples/java/MUC_Sample.java trunk/fb-contrib/src/samples/java/NAB_Sample.java trunk/fb-contrib/src/samples/java/NCMU_Sample.java trunk/fb-contrib/src/samples/java/NCS_Sample.java trunk/fb-contrib/src/samples/java/NFF_Sample.java trunk/fb-contrib/src/samples/java/NIR_Sample.java trunk/fb-contrib/src/samples/java/NMCS_Sample.java trunk/fb-contrib/src/samples/java/NOS_Sample.java trunk/fb-contrib/src/samples/java/NPMC_Sample.java trunk/fb-contrib/src/samples/java/NRTL_Sample.java trunk/fb-contrib/src/samples/java/NSE_Sample.java trunk/fb-contrib/src/samples/java/OCP_Sample.java trunk/fb-contrib/src/samples/java/OC_Sample.java trunk/fb-contrib/src/samples/java/ODN_Sample.java trunk/fb-contrib/src/samples/java/OI_Sample.java trunk/fb-contrib/src/samples/java/OPM_Sample.java trunk/fb-contrib/src/samples/java/PCAIL_Sample.java trunk/fb-contrib/src/samples/java/PCOA_Sample.java trunk/fb-contrib/src/samples/java/PDP_Sample.java trunk/fb-contrib/src/samples/java/PIS_Sample.java trunk/fb-contrib/src/samples/java/PL_Sample.java trunk/fb-contrib/src/samples/java/PMB_Sample.java trunk/fb-contrib/src/samples/java/PME_Sample.java trunk/fb-contrib/src/samples/java/PRMC_Sample.java trunk/fb-contrib/src/samples/java/PSC_Sample.java trunk/fb-contrib/src/samples/java/PUS_Sample.java trunk/fb-contrib/src/samples/java/ROOM_Sample.java trunk/fb-contrib/src/samples/java/S508C_Sample.java trunk/fb-contrib/src/samples/java/SACM_Sample.java trunk/fb-contrib/src/samples/java/SCA_Sample.java trunk/fb-contrib/src/samples/java/SCII_Sample.java trunk/fb-contrib/src/samples/java/SCI_Sample.java trunk/fb-contrib/src/samples/java/SCRV_Sample.java trunk/fb-contrib/src/samples/java/SCR_Sample.java trunk/fb-contrib/src/samples/java/SCSS_Sample.java trunk/fb-contrib/src/samples/java/SEC_Sample.java trunk/fb-contrib/src/samples/java/SEO_Sample.java trunk/fb-contrib/src/samples/java/SGSU_Sample.java trunk/fb-contrib/src/samples/java/SG_Sample.java trunk/fb-contrib/src/samples/java/SIL_Sample.java trunk/fb-contrib/src/samples/java/SJVU_Sample.java trunk/fb-contrib/src/samples/java/SLS_Sample.java trunk/fb-contrib/src/samples/java/SMII_Sample.java trunk/fb-contrib/src/samples/java/SNG_Sample.java trunk/fb-contrib/src/samples/java/SPP_Sample.java trunk/fb-contrib/src/samples/java/SSCU_Sample.java trunk/fb-contrib/src/samples/java/STB_Sample.java trunk/fb-contrib/src/samples/java/STS_Sample.java trunk/fb-contrib/src/samples/java/STT_Sample.java trunk/fb-contrib/src/samples/java/SUA_Sample.java trunk/fb-contrib/src/samples/java/SWCO_Sample.java trunk/fb-contrib/src/samples/java/TBP_Sample.java trunk/fb-contrib/src/samples/java/TR_Sample.java trunk/fb-contrib/src/samples/java/UAA_Sample.java trunk/fb-contrib/src/samples/java/UCC_Sample.java trunk/fb-contrib/src/samples/java/UCPM_Sample.java trunk/fb-contrib/src/samples/java/UEC_Sample.java trunk/fb-contrib/src/samples/java/UMTP_Sample.java trunk/fb-contrib/src/samples/java/UNNC_Sample.java trunk/fb-contrib/src/samples/java/UP_Sample.java trunk/fb-contrib/src/samples/java/URV_Sample.java trunk/fb-contrib/src/samples/java/USBR_Sample.java trunk/fb-contrib/src/samples/java/USFW_Sample.java trunk/fb-contrib/src/samples/java/USS_Sample.java trunk/fb-contrib/src/samples/java/UTAO_Sample.java trunk/fb-contrib/src/samples/java/UTA_Sample.java trunk/fb-contrib/src/samples/java/UTWR_Sample.java trunk/fb-contrib/src/samples/java/UVA_Sample.java trunk/fb-contrib/src/samples/java/WEM_Sample.java trunk/fb-contrib/src/samples/java/WI_Sample.java trunk/fb-contrib/src/samples/java/WOC_Sample.java Modified: trunk/fb-contrib/build.xml =================================================================== --- trunk/fb-contrib/build.xml 2017-03-12 23:39:23 UTC (rev 1815) +++ trunk/fb-contrib/build.xml 2017-04-09 22:42:29 UTC (rev 1816) @@ -31,7 +31,7 @@ <property name="javac.debug" value="on" /> <property name="test_reports.dir" value="${target.dir}/reports/test"/> - <property name="fb-contrib.version" value="6.8.4" /> + <property name="fb-contrib.version" value="6.9.0-SNAPSHOT" /> <property name="sonatype.dir" value="${user.home}/.fb-contrib-${fb-contrib.version}-sonatype" /> Modified: trunk/fb-contrib/etc/findbugs.xml =================================================================== --- trunk/fb-contrib/etc/findbugs.xml 2017-03-12 23:39:23 UTC (rev 1815) +++ trunk/fb-contrib/etc/findbugs.xml 2017-04-09 22:42:29 UTC (rev 1816) @@ -20,7 +20,7 @@ <!-- Detectors --> -<!-- COMMENT OUT FOR RELEASE +<!-- COMMENT OUT FOR RELEASE --> <Detector class="com.mebigfatguy.fbcontrib.debug.OCSDebugger" speed="fast"/> @@ -30,7 +30,7 @@ <Detector class="com.mebigfatguy.fbcontrib.detect.BloatedAssignmentScope" speed="fast" reports="BAS_BLOATED_ASSIGNMENT_SCOPE" hidden="true" /> - COMMENT OUT FOR RELEASE --> +<!-- COMMENT OUT FOR RELEASE --> <Detector class="com.mebigfatguy.fbcontrib.collect.CollectStatistics" speed="fast" reports="" hidden="true" /> @@ -305,7 +305,7 @@ <Detector class="com.mebigfatguy.fbcontrib.detect.ConcurrentCollectionIssues" speed="fast" reports="CCI_CONCURRENT_COLLECTION_ISSUES_USE_PUT_IS_RACY"/> - <!-- COMMENT OUT FOR POINT RELEASE + <!-- COMMENT OUT FOR POINT RELEASE --> <Detector class="com.mebigfatguy.fbcontrib.detect.UseTryWithResources" speed="fast" reports="UTWR_USE_TRY_WITH_RESOURCES"/> @@ -315,7 +315,7 @@ <Detector class="com.mebigfatguy.fbcontrib.detect.OptionalIssues" speed="fast" reports="OI_OPTIONAL_ISSUES_USES_IMMEDIATE_EXECUTION,OI_OPTIONAL_ISSUES_USES_DELAYED_EXECUTION,OI_OPTIONAL_ISSUES_CHECKING_REFERENCE,OI_OPTIONAL_ISSUES_PRIMITIVE_VARIANT_PREFERRED"/> - COMMENT OUT FOR POINT RELEASE --> + <!-- COMMENT OUT FOR POINT RELEASE --> <!-- BugPattern --> Modified: trunk/fb-contrib/etc/messages.xml =================================================================== --- trunk/fb-contrib/etc/messages.xml 2017-03-12 23:39:23 UTC (rev 1815) +++ trunk/fb-contrib/etc/messages.xml 2017-04-09 22:42:29 UTC (rev 1816) @@ -5638,7 +5638,7 @@ <![CDATA[ <p>Looks for relatively large if blocks of code, where you unconditionally return from them, and then follow that with an unconditional return of a small block. This places the bulk of the logic to the right indentation-wise, making it more difficult to read than needed. - It would be better to invert the logic of the if block, and immediately return, allowing the bulk of the logic to be move to the left, + It would be better to invert the logic of the if block, and immediately return, allowing the bulk of the logic to be move to the left for easier reading.</p> ]]> </Details> @@ -5649,9 +5649,9 @@ <LongDescription>Class {0} auto wires the same object into two separate fields in a class hierarchy</LongDescription> <Details> <![CDATA[ - <p>this class has two fields in either itself or a parent class which autowire (without specialization, the same object - for both fields. This is likely caused by a developer just not being aware that the field already is available for you use, - and just causes wasted space, and confusing code access the same object through two different pathways.</p> + <p>this class has two fields in either itself or a parent class which autowire (without specialization), the same object + for both fields. This is likely caused by a developer just not being aware that the field already is available for your use, + and just causes wasted space, and confusing code access to the same object through two different pathways.</p> ]]> </Details> </BugPattern> @@ -5662,7 +5662,7 @@ <Details> <![CDATA[ <p>This method retrieves the value of a key from a ConcurrentHashMap, where the value is itself a collection. It checks this - value for null, and if it is so, creates a new collection and places in the map. This may cause thread race conditions + value for null, and if it is so, creates a new collection and places it in the map. This may cause thread race conditions where two threads overwrite each other's values. You should be using <code> ConcurrentHashMap.putIfAbsent(K, V) @@ -5677,9 +5677,9 @@ <LongDescription>Method {1} manually handles closing an auto-closeable resource</LongDescription> <Details> <![CDATA[[ - <p>This method allocates and uses a auto closeable resources. However it manually closes the resource in a finally block. + <p>This method allocates and uses an auto closeable resources. However it manually closes the resource in a finally block. While this is correct management, it doesn't rely on the Idiomatic way available to JDK 7 and above, and allows for possible - subtle problems, and complicates the reading of code, by developers expecting the use of try-with-resources. + subtle problems, and complicates the reading of code by developers expecting the use of try-with-resources. </p> <p>Switch to using try with resources, as: <pre> Modified: trunk/fb-contrib/pom.xml =================================================================== --- trunk/fb-contrib/pom.xml 2017-03-12 23:39:23 UTC (rev 1815) +++ trunk/fb-contrib/pom.xml 2017-04-09 22:42:29 UTC (rev 1816) @@ -8,7 +8,7 @@ <modelVersion>4.0.0</modelVersion> <groupId>com.mebigfatguy.fb-contrib</groupId> <artifactId>fb-contrib</artifactId> - <version>6.8.4</version> + <version>6.9.0-SNAPSHOT</version> <prerequisites> <maven>2.2.1</maven> Modified: trunk/fb-contrib/samples.xml =================================================================== --- trunk/fb-contrib/samples.xml 2017-03-12 23:39:23 UTC (rev 1815) +++ trunk/fb-contrib/samples.xml 2017-04-09 22:42:29 UTC (rev 1816) @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> -<BugCollection version="3.0.1" sequence="0" timestamp="1489328062955" analysisTimestamp="1489328062981" release=""> +<BugCollection version="3.0.1" sequence="0" timestamp="1491777371371" analysisTimestamp="1491777371509" release=""> <Project projectName="Samples"> <Jar>/home/dave/dev/fb-contrib/target/classes/samples</Jar> <AuxClasspathEntry>/home/dave/dev/fb-contrib/lib/asm-debug-all-5.0.2.jar</AuxClasspathEntry> @@ -19,7 +19,6 @@ <AuxClasspathEntry>/home/dave/dev/fb-contrib/lib/httpcore-4.4.5.jar</AuxClasspathEntry> <AuxClasspathEntry>/home/dave/dev/fb-contrib/lib/httpclient-4.5.2.jar</AuxClasspathEntry> <AuxClasspathEntry>/home/dave/dev/fb-contrib/lib/commons-codec-1.10.jar</AuxClasspathEntry> - <AuxClasspathEntry>/home/dave/dev/fb-contrib/lib/jsr311-api-${jsr311-api.version}.jar</AuxClasspathEntry> <AuxClasspathEntry>/home/dave/dev/fb-contrib/lib/spring-beans-4.3.3.RELEASE.jar</AuxClasspathEntry> <AuxClasspathEntry>/home/dave/dev/fb-contrib/lib/spring-context-4.3.3.RELEASE.jar</AuxClasspathEntry> <AuxClasspathEntry>/home/dave/dev/fb-contrib/lib/spring-tx-4.3.3.RELEASE.jar</AuxClasspathEntry> @@ -29,371 +28,280 @@ <AuxClasspathEntry>/home/dave/dev/fb-contrib/lib/javax.ws.rs-api-2.0.1.jar</AuxClasspathEntry> <AuxClasspathEntry>/home/dave/dev/fb-contrib/lib/jersey-media-multipart-2.25.1.jar</AuxClasspathEntry> </Project> - <BugInstance type="IMC_IMMATURE_CLASS_NO_PACKAGE" priority="3" rank="20" abbrev="IMC" category="STYLE" instanceHash="52beb96b508e41498d672e105e62ceda" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> - <ShortMessage>Class is defined in the default package</ShortMessage> - <LongMessage>Class A id defined in the default package</LongMessage> - <Class classname="A" primary="true"> - <SourceLine classname="A" start="1" end="1" sourcefile="SCR_Sample.java" sourcepath="SCR_Sample.java"> - <Message>At SCR_Sample.java:[line 1]</Message> - </SourceLine> - <Message>In class A</Message> - </Class> - <SourceLine classname="A" start="1" end="1" sourcefile="SCR_Sample.java" sourcepath="SCR_Sample.java" synthetic="true"> - <Message>At SCR_Sample.java:[line 1]</Message> - </SourceLine> - </BugInstance> - <BugInstance type="ABC_ARRAY_BASED_COLLECTIONS" priority="2" rank="7" abbrev="ABC" category="CORRECTNESS" instanceHash="5421bf96fc5a9d37844eb8b32cd4cb17" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> + <BugInstance type="ABC_ARRAY_BASED_COLLECTIONS" priority="2" rank="7" abbrev="ABC" category="CORRECTNESS" instanceHash="c119924fdc9852642c13941116e4133a" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> <ShortMessage>Method uses array as basis of collection</ShortMessage> - <LongMessage>Method ABC_Sample.testLists(List, String[]) uses array as basis of collection</LongMessage> - <Class classname="ABC_Sample" primary="true"> - <SourceLine classname="ABC_Sample" start="9" end="23" sourcefile="ABC_Sample.java" sourcepath="ABC_Sample.java"> - <Message>At ABC_Sample.java:[lines 9-23]</Message> + <LongMessage>Method ex.ABC_Sample.testLists(List, String[]) uses array as basis of collection</LongMessage> + <Class classname="ex.ABC_Sample" primary="true"> + <SourceLine classname="ex.ABC_Sample" start="10" end="24" sourcefile="ABC_Sample.java" sourcepath="ex/ABC_Sample.java"> + <Message>At ABC_Sample.java:[lines 10-24]</Message> </SourceLine> - <Message>In class ABC_Sample</Message> + <Message>In class ex.ABC_Sample</Message> </Class> - <Method classname="ABC_Sample" name="testLists" signature="(Ljava/util/List;[Ljava/lang/String;)Z" isStatic="false" primary="true"> - <SourceLine classname="ABC_Sample" start="23" end="23" startBytecode="0" endBytecode="87" sourcefile="ABC_Sample.java" sourcepath="ABC_Sample.java"/> - <Message>In method ABC_Sample.testLists(List, String[])</Message> + <Method classname="ex.ABC_Sample" name="testLists" signature="(Ljava/util/List;[Ljava/lang/String;)Z" isStatic="false" primary="true"> + <SourceLine classname="ex.ABC_Sample" start="24" end="24" startBytecode="0" endBytecode="87" sourcefile="ABC_Sample.java" sourcepath="ex/ABC_Sample.java"/> + <Message>In method ex.ABC_Sample.testLists(List, String[])</Message> </Method> - <SourceLine classname="ABC_Sample" primary="true" start="23" end="23" startBytecode="2" endBytecode="2" sourcefile="ABC_Sample.java" sourcepath="ABC_Sample.java"> - <Message>At ABC_Sample.java:[line 23]</Message> + <SourceLine classname="ex.ABC_Sample" primary="true" start="24" end="24" startBytecode="2" endBytecode="2" sourcefile="ABC_Sample.java" sourcepath="ex/ABC_Sample.java"> + <Message>At ABC_Sample.java:[line 24]</Message> </SourceLine> </BugInstance> - <BugInstance type="ABC_ARRAY_BASED_COLLECTIONS" priority="2" rank="7" abbrev="ABC" category="CORRECTNESS" instanceHash="40414f9e8176322dc38b05fd7a40112b" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> + <BugInstance type="ABC_ARRAY_BASED_COLLECTIONS" priority="2" rank="7" abbrev="ABC" category="CORRECTNESS" instanceHash="5022f7e5f22e85b8c09eb0698effc480" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> <ShortMessage>Method uses array as basis of collection</ShortMessage> - <LongMessage>Method ABC_Sample.testMaps(String[], String) uses array as basis of collection</LongMessage> - <Class classname="ABC_Sample" primary="true"> - <SourceLine classname="ABC_Sample" start="9" end="23" sourcefile="ABC_Sample.java" sourcepath="ABC_Sample.java"> - <Message>At ABC_Sample.java:[lines 9-23]</Message> + <LongMessage>Method ex.ABC_Sample.testMaps(String[], String) uses array as basis of collection</LongMessage> + <Class classname="ex.ABC_Sample" primary="true"> + <SourceLine classname="ex.ABC_Sample" start="10" end="24" sourcefile="ABC_Sample.java" sourcepath="ex/ABC_Sample.java"> + <Message>At ABC_Sample.java:[lines 10-24]</Message> </SourceLine> - <Message>In class ABC_Sample</Message> + <Message>In class ex.ABC_Sample</Message> </Class> - <Method classname="ABC_Sample" name="testMaps" signature="([Ljava/lang/String;Ljava/lang/String;)Ljava/util/Map;" isStatic="false" primary="true"> - <SourceLine classname="ABC_Sample" start="11" end="13" startBytecode="0" endBytecode="116" sourcefile="ABC_Sample.java" sourcepath="ABC_Sample.java"/> - <Message>In method ABC_Sample.testMaps(String[], String)</Message> + <Method classname="ex.ABC_Sample" name="testMaps" signature="([Ljava/lang/String;Ljava/lang/String;)Ljava/util/Map;" isStatic="false" primary="true"> + <SourceLine classname="ex.ABC_Sample" start="12" end="14" startBytecode="0" endBytecode="116" sourcefile="ABC_Sample.java" sourcepath="ex/ABC_Sample.java"/> + <Message>In method ex.ABC_Sample.testMaps(String[], String)</Message> </Method> - <SourceLine classname="ABC_Sample" primary="true" start="12" end="12" startBytecode="11" endBytecode="11" sourcefile="ABC_Sample.java" sourcepath="ABC_Sample.java"> - <Message>At ABC_Sample.java:[line 12]</Message> + <SourceLine classname="ex.ABC_Sample" primary="true" start="13" end="13" startBytecode="11" endBytecode="11" sourcefile="ABC_Sample.java" sourcepath="ex/ABC_Sample.java"> + <Message>At ABC_Sample.java:[line 13]</Message> </SourceLine> </BugInstance> - <BugInstance type="ABC_ARRAY_BASED_COLLECTIONS" priority="2" rank="7" abbrev="ABC" category="CORRECTNESS" instanceHash="dfcf9c8148359ea9a561f2ac7905bdc1" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> + <BugInstance type="ABC_ARRAY_BASED_COLLECTIONS" priority="2" rank="7" abbrev="ABC" category="CORRECTNESS" instanceHash="4072d21498fbe1619af1b99012438a3e" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> <ShortMessage>Method uses array as basis of collection</ShortMessage> - <LongMessage>Method ABC_Sample.testSets(String[]) uses array as basis of collection</LongMessage> - <Class classname="ABC_Sample" primary="true"> - <SourceLine classname="ABC_Sample" start="9" end="23" sourcefile="ABC_Sample.java" sourcepath="ABC_Sample.java"> - <Message>At ABC_Sample.java:[lines 9-23]</Message> + <LongMessage>Method ex.ABC_Sample.testSets(String[]) uses array as basis of collection</LongMessage> + <Class classname="ex.ABC_Sample" primary="true"> + <SourceLine classname="ex.ABC_Sample" start="10" end="24" sourcefile="ABC_Sample.java" sourcepath="ex/ABC_Sample.java"> + <Message>At ABC_Sample.java:[lines 10-24]</Message> </SourceLine> - <Message>In class ABC_Sample</Message> + <Message>In class ex.ABC_Sample</Message> </Class> - <Method classname="ABC_Sample" name="testSets" signature="([Ljava/lang/String;)Ljava/util/Set;" isStatic="false" primary="true"> - <SourceLine classname="ABC_Sample" start="17" end="19" startBytecode="0" endBytecode="105" sourcefile="ABC_Sample.java" sourcepath="ABC_Sample.java"/> - <Message>In method ABC_Sample.testSets(String[])</Message> + <Method classname="ex.ABC_Sample" name="testSets" signature="([Ljava/lang/String;)Ljava/util/Set;" isStatic="false" primary="true"> + <SourceLine classname="ex.ABC_Sample" start="18" end="20" startBytecode="0" endBytecode="105" sourcefile="ABC_Sample.java" sourcepath="ex/ABC_Sample.java"/> + <Message>In method ex.ABC_Sample.testSets(String[])</Message> </Method> - <SourceLine classname="ABC_Sample" primary="true" start="18" end="18" startBytecode="10" endBytecode="10" sourcefile="ABC_Sample.java" sourcepath="ABC_Sample.java"> - <Message>At ABC_Sample.java:[line 18]</Message> + <SourceLine classname="ex.ABC_Sample" primary="true" start="19" end="19" startBytecode="10" endBytecode="10" sourcefile="ABC_Sample.java" sourcepath="ex/ABC_Sample.java"> + <Message>At ABC_Sample.java:[line 19]</Message> </SourceLine> </BugInstance> - <BugInstance type="IMC_IMMATURE_CLASS_NO_PACKAGE" priority="3" rank="20" abbrev="IMC" category="STYLE" instanceHash="6a106c10c25dcb88c0ca36a141248693" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> - <ShortMessage>Class is defined in the default package</ShortMessage> - <LongMessage>Class ABC_Sample id defined in the default package</LongMessage> - <Class classname="ABC_Sample" primary="true"> - <SourceLine classname="ABC_Sample" start="9" end="23" sourcefile="ABC_Sample.java" sourcepath="ABC_Sample.java"> - <Message>At ABC_Sample.java:[lines 9-23]</Message> - </SourceLine> - <Message>In class ABC_Sample</Message> - </Class> - <SourceLine classname="ABC_Sample" start="9" end="23" sourcefile="ABC_Sample.java" sourcepath="ABC_Sample.java" synthetic="true"> - <Message>At ABC_Sample.java:[lines 9-23]</Message> - </SourceLine> - </BugInstance> - <BugInstance type="UVA_USE_VAR_ARGS" priority="3" rank="20" abbrev="UVA" category="STYLE" instanceHash="953736d56fdf8525c7638c0264d76ee1" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> + <BugInstance type="UVA_USE_VAR_ARGS" priority="3" rank="20" abbrev="UVA" category="STYLE" instanceHash="b812994e88471986bcb49febe893981" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> <ShortMessage>Method defines parameter list with array as last argument, rather than vararg</ShortMessage> - <LongMessage>Method ABC_Sample.testLists(List, String[]) defines parameter list with array as last argument, rather than vararg</LongMessage> - <Class classname="ABC_Sample" primary="true"> - <SourceLine classname="ABC_Sample" start="9" end="23" sourcefile="ABC_Sample.java" sourcepath="ABC_Sample.java"> - <Message>At ABC_Sample.java:[lines 9-23]</Message> + <LongMessage>Method ex.ABC_Sample.testLists(List, String[]) defines parameter list with array as last argument, rather than vararg</LongMessage> + <Class classname="ex.ABC_Sample" primary="true"> + <SourceLine classname="ex.ABC_Sample" start="10" end="24" sourcefile="ABC_Sample.java" sourcepath="ex/ABC_Sample.java"> + <Message>At ABC_Sample.java:[lines 10-24]</Message> </SourceLine> - <Message>In class ABC_Sample</Message> + <Message>In class ex.ABC_Sample</Message> </Class> - <Method classname="ABC_Sample" name="testLists" signature="(Ljava/util/List;[Ljava/lang/String;)Z" isStatic="false" primary="true"> - <SourceLine classname="ABC_Sample" start="23" end="23" startBytecode="0" endBytecode="87" sourcefile="ABC_Sample.java" sourcepath="ABC_Sample.java"/> - <Message>In method ABC_Sample.testLists(List, String[])</Message> + <Method classname="ex.ABC_Sample" name="testLists" signature="(Ljava/util/List;[Ljava/lang/String;)Z" isStatic="false" primary="true"> + <SourceLine classname="ex.ABC_Sample" start="24" end="24" startBytecode="0" endBytecode="87" sourcefile="ABC_Sample.java" sourcepath="ex/ABC_Sample.java"/> + <Message>In method ex.ABC_Sample.testLists(List, String[])</Message> </Method> - <SourceLine classname="ABC_Sample" start="23" end="23" startBytecode="0" endBytecode="87" sourcefile="ABC_Sample.java" sourcepath="ABC_Sample.java" synthetic="true"> - <Message>At ABC_Sample.java:[line 23]</Message> + <SourceLine classname="ex.ABC_Sample" start="24" end="24" startBytecode="0" endBytecode="87" sourcefile="ABC_Sample.java" sourcepath="ex/ABC_Sample.java" synthetic="true"> + <Message>At ABC_Sample.java:[line 24]</Message> </SourceLine> </BugInstance> - <BugInstance type="UVA_USE_VAR_ARGS" priority="3" rank="20" abbrev="UVA" category="STYLE" instanceHash="371050328f0e7fbfb0936e6adf778ec5" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> + <BugInstance type="UVA_USE_VAR_ARGS" priority="3" rank="20" abbrev="UVA" category="STYLE" instanceHash="429323157d988fb6e44ff020f056b86a" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> <ShortMessage>Method defines parameter list with array as last argument, rather than vararg</ShortMessage> - <LongMessage>Method ABC_Sample.testSets(String[]) defines parameter list with array as last argument, rather than vararg</LongMessage> - <Class classname="ABC_Sample" primary="true"> - <SourceLine classname="ABC_Sample" start="9" end="23" sourcefile="ABC_Sample.java" sourcepath="ABC_Sample.java"> - <Message>At ABC_Sample.java:[lines 9-23]</Message> + <LongMessage>Method ex.ABC_Sample.testSets(String[]) defines parameter list with array as last argument, rather than vararg</LongMessage> + <Class classname="ex.ABC_Sample" primary="true"> + <SourceLine classname="ex.ABC_Sample" start="10" end="24" sourcefile="ABC_Sample.java" sourcepath="ex/ABC_Sample.java"> + <Message>At ABC_Sample.java:[lines 10-24]</Message> </SourceLine> - <Message>In class ABC_Sample</Message> + <Message>In class ex.ABC_Sample</Message> </Class> - <Method classname="ABC_Sample" name="testSets" signature="([Ljava/lang/String;)Ljava/util/Set;" isStatic="false" primary="true"> - <SourceLine classname="ABC_Sample" start="17" end="19" startBytecode="0" endBytecode="105" sourcefile="ABC_Sample.java" sourcepath="ABC_Sample.java"/> - <Message>In method ABC_Sample.testSets(String[])</Message> + <Method classname="ex.ABC_Sample" name="testSets" signature="([Ljava/lang/String;)Ljava/util/Set;" isStatic="false" primary="true"> + <SourceLine classname="ex.ABC_Sample" start="18" end="20" startBytecode="0" endBytecode="105" sourcefile="ABC_Sample.java" sourcepath="ex/ABC_Sample.java"/> + <Message>In method ex.ABC_Sample.testSets(String[])</Message> </Method> - <SourceLine classname="ABC_Sample" start="17" end="19" startBytecode="0" endBytecode="105" sourcefile="ABC_Sample.java" sourcepath="ABC_Sample.java" synthetic="true"> - <Message>At ABC_Sample.java:[lines 17-19]</Message> + <SourceLine classname="ex.ABC_Sample" start="18" end="20" startBytecode="0" endBytecode="105" sourcefile="ABC_Sample.java" sourcepath="ex/ABC_Sample.java" synthetic="true"> + <Message>At ABC_Sample.java:[lines 18-20]</Message> </SourceLine> </BugInstance> - <BugInstance type="IMC_IMMATURE_CLASS_NO_PACKAGE" priority="3" rank="20" abbrev="IMC" category="STYLE" instanceHash="c520853fde7213434793beddd90ecf4b" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> - <ShortMessage>Class is defined in the default package</ShortMessage> - <LongMessage>Class ABC_Sample$UseComparator id defined in the default package</LongMessage> - <Class classname="ABC_Sample$UseComparator" primary="true"> - <SourceLine classname="ABC_Sample$UseComparator" start="29" end="40" sourcefile="ABC_Sample.java" sourcepath="ABC_Sample.java"> - <Message>At ABC_Sample.java:[lines 29-40]</Message> - </SourceLine> - <Message>In class ABC_Sample$UseComparator</Message> - </Class> - <SourceLine classname="ABC_Sample$UseComparator" start="29" end="40" sourcefile="ABC_Sample.java" sourcepath="ABC_Sample.java" synthetic="true"> - <Message>At ABC_Sample.java:[lines 29-40]</Message> - </SourceLine> - </BugInstance> - <BugInstance type="IMC_IMMATURE_CLASS_NO_PACKAGE" priority="3" rank="20" abbrev="IMC" category="STYLE" instanceHash="2e5c6f2ce94c7857de42f1491cf2f6c2" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> - <ShortMessage>Class is defined in the default package</ShortMessage> - <LongMessage>Class ABC_Sample$UseComparator$1 id defined in the default package</LongMessage> - <Class classname="ABC_Sample$UseComparator$1" primary="true"> - <SourceLine classname="ABC_Sample$UseComparator$1" start="1" end="33" sourcefile="ABC_Sample.java" sourcepath="ABC_Sample.java"> - <Message>At ABC_Sample.java:[lines 1-33]</Message> - </SourceLine> - <Message>In class ABC_Sample$UseComparator$1</Message> - </Class> - <SourceLine classname="ABC_Sample$UseComparator$1" start="1" end="33" sourcefile="ABC_Sample.java" sourcepath="ABC_Sample.java" synthetic="true"> - <Message>At ABC_Sample.java:[lines 1-33]</Message> - </SourceLine> - </BugInstance> - <BugInstance type="SIC_INNER_SHOULD_BE_STATIC_ANON" priority="3" rank="20" abbrev="SIC" category="PERFORMANCE" instanceHash="9296dd6a3b1f76793e436f0b899dac" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> + <BugInstance type="SIC_INNER_SHOULD_BE_STATIC_ANON" priority="3" rank="20" abbrev="SIC" category="PERFORMANCE" instanceHash="77e4834d0124712408e4e088c71d9594" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> <ShortMessage>Could be refactored into a named static inner class</ShortMessage> - <LongMessage>The class ABC_Sample$UseComparator$1 could be refactored into a named _static_ inner class</LongMessage> - <Class classname="ABC_Sample$UseComparator$1" primary="true"> - <SourceLine classname="ABC_Sample$UseComparator$1" start="1" end="33" sourcefile="ABC_Sample.java" sourcepath="ABC_Sample.java"> - <Message>At ABC_Sample.java:[lines 1-33]</Message> + <LongMessage>The class ex.ABC_Sample$UseComparator$1 could be refactored into a named _static_ inner class</LongMessage> + <Class classname="ex.ABC_Sample$UseComparator$1" primary="true"> + <SourceLine classname="ex.ABC_Sample$UseComparator$1" start="1" end="34" sourcefile="ABC_Sample.java" sourcepath="ex/ABC_Sample.java"> + <Message>At ABC_Sample.java:[lines 1-34]</Message> </SourceLine> - <Message>In class ABC_Sample$UseComparator$1</Message> + <Message>In class ex.ABC_Sample$UseComparator$1</Message> </Class> - <SourceLine classname="ABC_Sample$UseComparator$1" start="1" end="33" sourcefile="ABC_Sample.java" sourcepath="ABC_Sample.java" synthetic="true"> - <Message>At ABC_Sample.java:[lines 1-33]</Message> + <SourceLine classname="ex.ABC_Sample$UseComparator$1" start="1" end="34" sourcefile="ABC_Sample.java" sourcepath="ex/ABC_Sample.java" synthetic="true"> + <Message>At ABC_Sample.java:[lines 1-34]</Message> </SourceLine> </BugInstance> - <BugInstance type="ACEM_ABSTRACT_CLASS_EMPTY_METHODS" priority="2" rank="19" abbrev="ACEM" category="STYLE" instanceHash="1d9ad842073400e44bf8df1666096e98" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> + <BugInstance type="ACEM_ABSTRACT_CLASS_EMPTY_METHODS" priority="2" rank="19" abbrev="ACEM" category="STYLE" instanceHash="aad57247260e0468a77c14712f5304f" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> <ShortMessage>Empty method could be declared abstract</ShortMessage> - <LongMessage>Empty method ACEM_Sample.test() could be declared abstract</LongMessage> - <Class classname="ACEM_Sample" primary="true"> - <SourceLine classname="ACEM_Sample" start="2" end="12" sourcefile="ACEM_Sample.java" sourcepath="ACEM_Sample.java"> - <Message>At ACEM_Sample.java:[lines 2-12]</Message> + <LongMessage>Empty method ex.ACEM_Sample.test() could be declared abstract</LongMessage> + <Class classname="ex.ACEM_Sample" primary="true"> + <SourceLine classname="ex.ACEM_Sample" start="3" end="13" sourcefile="ACEM_Sample.java" sourcepath="ex/ACEM_Sample.java"> + <Message>At ACEM_Sample.java:[lines 3-13]</Message> </SourceLine> - <Message>In class ACEM_Sample</Message> + <Message>In class ex.ACEM_Sample</Message> </Class> - <Method classname="ACEM_Sample" name="test" signature="()V" isStatic="false" primary="true"> - <SourceLine classname="ACEM_Sample" start="4" end="4" startBytecode="0" endBytecode="42" sourcefile="ACEM_Sample.java" sourcepath="ACEM_Sample.java"/> - <Message>In method ACEM_Sample.test()</Message> + <Method classname="ex.ACEM_Sample" name="test" signature="()V" isStatic="false" primary="true"> + <SourceLine classname="ex.ACEM_Sample" start="5" end="5" startBytecode="0" endBytecode="42" sourcefile="ACEM_Sample.java" sourcepath="ex/ACEM_Sample.java"/> + <Message>In method ex.ACEM_Sample.test()</Message> </Method> - <SourceLine classname="ACEM_Sample" primary="true" start="4" end="4" startBytecode="0" endBytecode="0" sourcefile="ACEM_Sample.java" sourcepath="ACEM_Sample.java"> - <Message>At ACEM_Sample.java:[line 4]</Message> + <SourceLine classname="ex.ACEM_Sample" primary="true" start="5" end="5" startBytecode="0" endBytecode="0" sourcefile="ACEM_Sample.java" sourcepath="ex/ACEM_Sample.java"> + <Message>At ACEM_Sample.java:[line 5]</Message> </SourceLine> </BugInstance> - <BugInstance type="ACEM_ABSTRACT_CLASS_EMPTY_METHODS" priority="2" rank="19" abbrev="ACEM" category="STYLE" instanceHash="dfb744a9fd133992695661a44c1ad885" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> + <BugInstance type="ACEM_ABSTRACT_CLASS_EMPTY_METHODS" priority="2" rank="19" abbrev="ACEM" category="STYLE" instanceHash="e87d3eb59ec00415966480f172c1cfb6" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> <ShortMessage>Empty method could be declared abstract</ShortMessage> - <LongMessage>Empty method ACEM_Sample.test1() could be declared abstract</LongMessage> - <Class classname="ACEM_Sample" primary="true"> - <SourceLine classname="ACEM_Sample" start="2" end="12" sourcefile="ACEM_Sample.java" sourcepath="ACEM_Sample.java"> - <Message>At ACEM_Sample.java:[lines 2-12]</Message> + <LongMessage>Empty method ex.ACEM_Sample.test1() could be declared abstract</LongMessage> + <Class classname="ex.ACEM_Sample" primary="true"> + <SourceLine classname="ex.ACEM_Sample" start="3" end="13" sourcefile="ACEM_Sample.java" sourcepath="ex/ACEM_Sample.java"> + <Message>At ACEM_Sample.java:[lines 3-13]</Message> </SourceLine> - <Message>In class ACEM_Sample</Message> + <Message>In class ex.ACEM_Sample</Message> </Class> - <Method classname="ACEM_Sample" name="test1" signature="()I" isStatic="false" primary="true"> - <SourceLine classname="ACEM_Sample" start="7" end="7" startBytecode="0" endBytecode="51" sourcefile="ACEM_Sample.java" sourcepath="ACEM_Sample.java"/> - <Message>In method ACEM_Sample.test1()</Message> + <Method classname="ex.ACEM_Sample" name="test1" signature="()I" isStatic="false" primary="true"> + <SourceLine classname="ex.ACEM_Sample" start="8" end="8" startBytecode="0" endBytecode="51" sourcefile="ACEM_Sample.java" sourcepath="ex/ACEM_Sample.java"/> + <Message>In method ex.ACEM_Sample.test1()</Message> </Method> - <SourceLine classname="ACEM_Sample" primary="true" start="7" end="7" startBytecode="9" endBytecode="9" sourcefile="ACEM_Sample.java" sourcepath="ACEM_Sample.java"> - <Message>At ACEM_Sample.java:[line 7]</Message> + <SourceLine classname="ex.ACEM_Sample" primary="true" start="8" end="8" startBytecode="9" endBytecode="9" sourcefile="ACEM_Sample.java" sourcepath="ex/ACEM_Sample.java"> + <Message>At ACEM_Sample.java:[line 8]</Message> </SourceLine> </BugInstance> - <BugInstance type="IMC_IMMATURE_CLASS_NO_PACKAGE" priority="3" rank="20" abbrev="IMC" category="STYLE" instanceHash="3e69b2201e7354f6c9dcfbd765b2aea4" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> - <ShortMessage>Class is defined in the default package</ShortMessage> - <LongMessage>Class ACEM_Sample id defined in the default package</LongMessage> - <Class classname="ACEM_Sample" primary="true"> - <SourceLine classname="ACEM_Sample" start="2" end="12" sourcefile="ACEM_Sample.java" sourcepath="ACEM_Sample.java"> - <Message>At ACEM_Sample.java:[lines 2-12]</Message> - </SourceLine> - <Message>In class ACEM_Sample</Message> - </Class> - <SourceLine classname="ACEM_Sample" start="2" end="12" sourcefile="ACEM_Sample.java" sourcepath="ACEM_Sample.java" synthetic="true"> - <Message>At ACEM_Sample.java:[lines 2-12]</Message> - </SourceLine> - </BugInstance> - <BugInstance type="IMC_IMMATURE_CLASS_NO_PACKAGE" priority="3" rank="20" abbrev="IMC" category="STYLE" instanceHash="7d163f23adfca420d778642389488e30" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> - <ShortMessage>Class is defined in the default package</ShortMessage> - <LongMessage>Class AFBR_Sample id defined in the default package</LongMessage> - <Class classname="AFBR_Sample" primary="true"> - <SourceLine classname="AFBR_Sample" start="6" end="55" sourcefile="AFBR_Sample.java" sourcepath="AFBR_Sample.java"> - <Message>At AFBR_Sample.java:[lines 6-55]</Message> - </SourceLine> - <Message>In class AFBR_Sample</Message> - </Class> - <SourceLine classname="AFBR_Sample" start="6" end="55" sourcefile="AFBR_Sample.java" sourcepath="AFBR_Sample.java" synthetic="true"> - <Message>At AFBR_Sample.java:[lines 6-55]</Message> - </SourceLine> - </BugInstance> - <BugInstance type="UTWR_USE_TRY_WITH_RESOURCES" priority="2" rank="17" abbrev="UTWR" category="STYLE" instanceHash="7853058b271c094cda47622eb67ea1ef" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> + <BugInstance type="UTWR_USE_TRY_WITH_RESOURCES" priority="2" rank="17" abbrev="UTWR" category="STYLE" instanceHash="ec7e6902ec57bf55eb9d354038d69126" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> <ShortMessage>Method manually handles closing an auto-closeable resource</ShortMessage> - <LongMessage>Method AFBR_Sample.test5() manually handles closing an auto-closeable resource</LongMessage> - <Class classname="AFBR_Sample" primary="true"> - <SourceLine classname="AFBR_Sample" start="6" end="55" sourcefile="AFBR_Sample.java" sourcepath="AFBR_Sample.java"> - <Message>At AFBR_Sample.java:[lines 6-55]</Message> + <LongMessage>Method ex.AFBR_Sample.test5() manually handles closing an auto-closeable resource</LongMessage> + <Class classname="ex.AFBR_Sample" primary="true"> + <SourceLine classname="ex.AFBR_Sample" start="7" end="56" sourcefile="AFBR_Sample.java" sourcepath="ex/AFBR_Sample.java"> + <Message>At AFBR_Sample.java:[lines 7-56]</Message> </SourceLine> - <Message>In class AFBR_Sample</Message> + <Message>In class ex.AFBR_Sample</Message> </Class> - <Method classname="AFBR_Sample" name="test5" signature="()I" isStatic="false" primary="true"> - <SourceLine classname="AFBR_Sample" start="45" end="55" startBytecode="0" endBytecode="244" sourcefile="AFBR_Sample.java" sourcepath="AFBR_Sample.java"/> - <Message>In method AFBR_Sample.test5()</Message> + <Method classname="ex.AFBR_Sample" name="test5" signature="()I" isStatic="false" primary="true"> + <SourceLine classname="ex.AFBR_Sample" start="46" end="56" startBytecode="0" endBytecode="244" sourcefile="AFBR_Sample.java" sourcepath="ex/AFBR_Sample.java"/> + <Message>In method ex.AFBR_Sample.test5()</Message> </Method> - <SourceLine classname="AFBR_Sample" primary="true" start="53" end="53" startBytecode="48" endBytecode="48" sourcefile="AFBR_Sample.java" sourcepath="AFBR_Sample.java"> - <Message>At AFBR_Sample.java:[line 53]</Message> + <SourceLine classname="ex.AFBR_Sample" primary="true" start="54" end="54" startBytecode="48" endBytecode="48" sourcefile="AFBR_Sample.java" sourcepath="ex/AFBR_Sample.java"> + <Message>At AFBR_Sample.java:[line 54]</Message> </SourceLine> </BugInstance> - <BugInstance type="AIOB_ARRAY_INDEX_OUT_OF_BOUNDS" priority="1" rank="5" abbrev="AIOB" category="CORRECTNESS" instanceHash="d2f4886e79bc1813b0e731d7c4a23e9" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> + <BugInstance type="AIOB_ARRAY_INDEX_OUT_OF_BOUNDS" priority="1" rank="5" abbrev="AIOB" category="CORRECTNESS" instanceHash="27db0e3df2e5d04faa228833bdf78524" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> <ShortMessage>Method attempts to access an array element outside the array's size</ShortMessage> - <LongMessage>Method AIOB_Sample.testOutOfBounds() attempts to access an array element outside the array's size</LongMessage> - <Class classname="AIOB_Sample" primary="true"> - <SourceLine classname="AIOB_Sample" start="3" end="80" sourcefile="AIOB_Sample.java" sourcepath="AIOB_Sample.java"> - <Message>At AIOB_Sample.java:[lines 3-80]</Message> + <LongMessage>Method ex.AIOB_Sample.testOutOfBounds() attempts to access an array element outside the array's size</LongMessage> + <Class classname="ex.AIOB_Sample" primary="true"> + <SourceLine classname="ex.AIOB_Sample" start="4" end="81" sourcefile="AIOB_Sample.java" sourcepath="ex/AIOB_Sample.java"> + <Message>At AIOB_Sample.java:[lines 4-81]</Message> </SourceLine> - <Message>In class AIOB_Sample</Message> + <Message>In class ex.AIOB_Sample</Message> </Class> - <Method classname="AIOB_Sample" name="testOutOfBounds" signature="()V" isStatic="false" primary="true"> - <SourceLine classname="AIOB_Sample" start="9" end="13" startBytecode="0" endBytecode="79" sourcefile="AIOB_Sample.java" sourcepath="AIOB_Sample.java"/> - <Message>In method AIOB_Sample.testOutOfBounds()</Message> + <Method classname="ex.AIOB_Sample" name="testOutOfBounds" signature="()V" isStatic="false" primary="true"> + <SourceLine classname="ex.AIOB_Sample" start="10" end="14" startBytecode="0" endBytecode="79" sourcefile="AIOB_Sample.java" sourcepath="ex/AIOB_Sample.java"/> + <Message>In method ex.AIOB_Sample.testOutOfBounds()</Message> </Method> - <SourceLine classname="AIOB_Sample" primary="true" start="11" end="11" startBytecode="7" endBytecode="7" sourcefile="AIOB_Sample.java" sourcepath="AIOB_Sample.java"> - <Message>At AIOB_Sample.java:[line 11]</Message> + <SourceLine classname="ex.AIOB_Sample" primary="true" start="12" end="12" startBytecode="7" endBytecode="7" sourcefile="AIOB_Sample.java" sourcepath="ex/AIOB_Sample.java"> + <Message>At AIOB_Sample.java:[line 12]</Message> </SourceLine> </BugInstance> - <BugInstance type="AIOB_ARRAY_STORE_TO_NULL_REFERENCE" priority="1" rank="5" abbrev="AIOB" category="CORRECTNESS" instanceHash="8e04af5b8eab8882d56ff00e1aae49bd" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> + <BugInstance type="AIOB_ARRAY_STORE_TO_NULL_REFERENCE" priority="1" rank="5" abbrev="AIOB" category="CORRECTNESS" instanceHash="32fd3a9096a628f23868ee9eff245995" instanceOccurrenceNum="0" instanceOccurrenceMax="0"> <ShortMessage>Method attempts to store an array element to an array that does not appear to be allocated</ShortMessage> - <LongMessage>Method AIOB_Sample.testUnallocated() attempts to store an array element to an array that does not appear to be allocated</LongMessage> - <Class classname="AIOB_Sample" primary="true"> - <SourceLine classname="AIOB_Sample" start="3" end="80" sourcefile="AIOB_Sample.java" sourcepath="AIOB_Sample.java"> - <Message>At AIOB_Sample.java:[lines 3-80]</Message> + <LongMessage>Method ex.AIOB_Sample.testUnallocated() attempts to store an array element to an array that does not appear to be allocated</LongMessage> + <Class classname="ex.AIOB_Sample" primary="true"> + <SourceLine classname="ex.AIOB_Sample" start="4" end="81" sourcefile="AIOB_Sample.java" sourcepath="ex/AIOB_Sample.java"> + <Message>At AIOB_Sample.java:[lines 4-81]</Message> </SourceLine> - <Message>In class AIOB_Sample</Message> + <Message>In class ex.AIOB_Sample</Message> </Class> - <Method classname="AIOB_Sample" name="testUnallocated" signature="()V" isStatic="false" primary="true"> - <SourceLine classname="AIOB_Sample" start="24" end="28" startBytecode="0" endBytecode="77" sourcefile="AIOB_Sample.java" sourcepath="AIOB_Sample.java"/> - <Message>In method AIOB_Sample.testUnallocated()</Message> + <Method classname="ex.AIOB_Sample" name="testUnallocated" signature="()V" isStatic="false" primary="true"> + <SourceLine classname="ex.AIOB_Sample" start="25" end="29" startBytecode="0" endBytecode="77" sourcefile="AIOB_Sample.java" sourcepath="ex/AIOB_Sample.java"/> + <Message>In method ex.AIOB_Sample.testUnallocated()</Message> </Method> - <SourceLine classname="AIOB_Sample" primary="true" start="26" end="26" startBytecode="5" endBytecode="5" sourcefile="AIOB_Sample.java" sourcepath="AIOB_Sample.java"> - <Message>At AIOB_Sample.java:[line 26]</Message> + <SourceLine classname="ex.AIOB_Sample" primary="true" start="27" end="27" startBytecode="5" endBytecode="5" sourcefile="AIOB_Sample.java" sourcepath="ex/AIOB_Sample.java"> + <Message>At AIOB_Sample.java:[line 27]</Message> </SourceLine> </BugInstance> - <BugInstance type="DLS_DEAD_LOCAL_STORE" priority="3" rank="20" abbrev="DLS" category="STYLE" instanceHash="92b9c579b1c9b45022ff884c72079ad3" instanceOccurrenceNum="0" instanceOccurrenceMax="0" cweid="563"> + <BugInstance type="DLS_DEAD_LOCAL_STORE" priority="3" rank="20" abbrev="DLS" category="STYLE" instanceHash="6fac8373ac4fb823f4ab0435e7682742" instanceOccurrenceNum="0" instanceOccurrenceMax="0" cweid="563"> <ShortMessage>Dead store to local variable</ShortMessage> - <LongMessage>Dead store to s in AIOB_Sample.fpPlusPlusNotRecognized(List)</LongMessage> - <Class classname="AIOB_Sample" primary="true"> - <SourceLine classname="AIOB_Sample" start="3" end="80" sourcefile="AIOB_Sample.java" sourcepath="AIOB_Sample.java"> - <Message>At AIOB_Sample.java:[lines 3-80]</Message> + <LongMessage>Dead store to s in ex.AIOB_Sample.fpPlusPlusNotRecognized(List)</LongMessage> + <Class classname="ex.AIOB_Sample" primary="true"> + <SourceLine classname="ex.AIOB_Sample" start="4" end="81" sourcefile="AIOB_Sample.java" sourcepath="ex/AIOB_Sample.java"> + <Message>At AIOB_Sample.java:[lines 4-81]</Message> </SourceLine> - <Message>In class AIOB_Sample</Message> + <Message>In class ex.AIOB_Sample</Message> </Class> - <Method classname="AIOB_Sample" name="fpPlusPlusNotRecognized" signature="(Ljava/util/List;)[I" isStatic="false" primary="true"> - <SourceLine classname="AIOB_Sample" start="38" end="47" startBytecode="0" endBytecode="22" sourcefile="AIOB_Sample.java" sourcepath="AIOB_Sample.java"/> - <Message>In method AIOB_Sample.fpPlusPlusNotRecognized(List)</Message> + <Method classname="ex.AIOB_Sample" name="fpPlusPlusNotRecognized" signature="(Ljava/util/List;)[I" isStatic="false" primary="true"> + <SourceLine classname="ex.AIOB_Sample" start="39" end="48" startBytecode="0" endBytecode="22" sourcefile="AIOB_Sample.jav... [truncated message content] |