[Fb-contrib-commit] SF.net SVN: fb-contrib:[1788] trunk/fb-contrib
Brought to you by:
dbrosius
Menu
▾
▴
[Fb-contrib-commit] SF.net SVN: fb-contrib:[1788] trunk/fb-contrib
|
From: <dbr...@us...> - 2015-12-30 20:32:19
|
Revision: 1788
http://sourceforge.net/p/fb-contrib/code/1788
Author: dbrosius
Date: 2015-12-30 20:32:17 +0000 (Wed, 30 Dec 2015)
Log Message:
-----------
sync from github
Modified Paths:
--------------
trunk/fb-contrib/build.xml
trunk/fb-contrib/etc/findbugs.xml
trunk/fb-contrib/etc/messages.xml
trunk/fb-contrib/htdocs/index.shtml
trunk/fb-contrib/htdocs/repository.html
trunk/fb-contrib/pom.xml
trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java
Modified: trunk/fb-contrib/build.xml
===================================================================
--- trunk/fb-contrib/build.xml 2015-12-29 21:37:08 UTC (rev 1787)
+++ trunk/fb-contrib/build.xml 2015-12-30 20:32:17 UTC (rev 1788)
@@ -28,7 +28,7 @@
<property name="javac.deprecation" value="on" />
<property name="javac.debug" value="on" />
- <property name="fb-contrib.version" value="6.5.0-SNAPSHOT" />
+ <property name="fb-contrib.version" value="6.4.2" />
<property name="sonatype.dir" value="${user.home}/.fb-contrib-${fb-contrib.version}-sonatype" />
Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================
--- trunk/fb-contrib/etc/findbugs.xml 2015-12-29 21:37:08 UTC (rev 1787)
+++ trunk/fb-contrib/etc/findbugs.xml 2015-12-30 20:32:17 UTC (rev 1788)
@@ -20,7 +20,7 @@
<!-- Detectors -->
-<!-- COMMENT OUT FOR RELEASE -->
+<!-- COMMENT OUT FOR RELEASE
<Detector class="com.mebigfatguy.fbcontrib.debug.OCSDebugger" speed="fast"/>
@@ -32,7 +32,7 @@
<Detector class="com.mebigfatguy.fbcontrib.detect.BloatedAssignmentScope" speed="fast" reports="BAS_BLOATED_ASSIGNMENT_SCOPE" hidden="true" />
-<!-- COMMENT OUT FOR RELEASE -->
+ COMMENT OUT FOR RELEASE -->
<Detector class="com.mebigfatguy.fbcontrib.collect.CollectStatistics" speed="fast" reports="" hidden="true" />
@@ -291,13 +291,13 @@
<Detector class="com.mebigfatguy.fbcontrib.detect.JAXRSIssues" speed="fast" reports="JXI_GET_ENDPOINT_CONSUMES_CONTENT,JXI_INVALID_CONTEXT_PARAMETER_TYPE,JXI_PARM_PARAM_NOT_FOUND_IN_PATH,JXI_UNDEFINED_PARAMETER_SOURCE_IN_ENDPOINT" />
- <!-- COMMENT OUT FOR POINT RELEASE -->
+ <!-- COMMENT OUT FOR POINT RELEASE
<Detector class="com.mebigfatguy.fbcontrib.detect.JPAIssues" speed="fast" reports="JPAI_TRANSACTION_ON_NON_PUBLIC_METHOD,JPAI_HC_EQUALS_ON_MANAGED_ENTITY,JPAI_NON_PROXIED_TRANSACTION_CALL,JPAI_INEFFICIENT_EAGER_FETCH,JPAI_IGNORED_MERGE_RESULT,JPAI_NON_SPECIFIED_TRANSACTION_EXCEPTION_HANDLING,JPAI_UNNECESSARY_TRANSACTION_EXCEPTION_HANDLING"/>
<Detector class="com.mebigfatguy.fbcontrib.detect.SuboptimalExpressionOrder" speed="fast" reports="SEO_SUBOPTIMAL_EXPRESSION_ORDER"/>
- <!-- COMMENT OUT FOR POINT RELEASE -->
+ COMMENT OUT FOR POINT RELEASE -->
<!-- BugPattern -->
Modified: trunk/fb-contrib/etc/messages.xml
===================================================================
--- trunk/fb-contrib/etc/messages.xml 2015-12-29 21:37:08 UTC (rev 1787)
+++ trunk/fb-contrib/etc/messages.xml 2015-12-30 20:32:17 UTC (rev 1788)
@@ -3859,8 +3859,9 @@
<LongDescription>Method {1} creates exception with logger parameter markers in message</LongDescription>
<Details>
<![CDATA[
- <p>This method creates a standard exception passing a message string which contains an SLF4J style
- parameter marker '{}'. This marker will not be translated as it is not processed by the Exception class.
+ <p>This method passes a standard exception as a logger parameter, and expects this exception to be substituted in
+ an SLF4J style parameter marker '{}'. This marker will not be translated as SLF4J doesn't process the Exception class
+ for markers.
</p>
]]>
</Details>
Modified: trunk/fb-contrib/htdocs/index.shtml
===================================================================
--- trunk/fb-contrib/htdocs/index.shtml 2015-12-29 21:37:08 UTC (rev 1787)
+++ trunk/fb-contrib/htdocs/index.shtml 2015-12-30 20:32:17 UTC (rev 1788)
@@ -68,7 +68,7 @@
</li>
</ul>
</p>
- <p style="font-weight: bold;">The latest version of fb-contrib is 6.4.1 available for download
+ <p style="font-weight: bold;">The latest version of fb-contrib is 6.4.2 available for download
<a href="http://search.maven.org/#search%7Cga%7C1%7Ca%3A%22fb-contrib%22">here</a>.</p>
<p style="font-weight: bold;">This version requires FindBugs 3.0.1 or better</p>
<p style="font-weight: bold;">Please note that active development for this project is now done on
Modified: trunk/fb-contrib/htdocs/repository.html
===================================================================
--- trunk/fb-contrib/htdocs/repository.html 2015-12-29 21:37:08 UTC (rev 1787)
+++ trunk/fb-contrib/htdocs/repository.html 2015-12-30 20:32:17 UTC (rev 1788)
@@ -22,7 +22,7 @@
<table style="margin-left: 40px; background-color: #A0A0FF; padding: 20px; border-width: 1px; border-style: outset; border-color: #000000;">
<tr><td><b>GroupId:</b></td><td>com.mebigfatguy.fb-contrib</td></tr>
<tr><td><b>ArtifactId:</b></td><td>fb-contrib</td></tr>
- <tr><td><b>Version:</b></td><td>6.4.1</td></tr>
+ <tr><td><b>Version:</b></td><td>6.4.2</td></tr>
</table>
</div>
Modified: trunk/fb-contrib/pom.xml
===================================================================
--- trunk/fb-contrib/pom.xml 2015-12-29 21:37:08 UTC (rev 1787)
+++ trunk/fb-contrib/pom.xml 2015-12-30 20:32:17 UTC (rev 1788)
@@ -8,7 +8,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.mebigfatguy.fb-contrib</groupId>
<artifactId>fb-contrib</artifactId>
- <version>6.5.0-SNAPSHOT</version>
+ <version>6.4.2</version>
<prerequisites>
<maven>2.2.1</maven>
Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java 2015-12-29 21:37:08 UTC (rev 1787)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java 2015-12-30 20:32:17 UTC (rev 1788)
@@ -253,6 +253,11 @@
}
}
+ /**
+ * looks for a variety of logging issues with log statements
+ *
+ * @throws ClassNotFoundException if the exception class, or a parent class can't be found
+ */
private void checkForProblemsWithLoggerMethods() throws ClassNotFoundException {
String callingClsName = getClassConstantOperand();
if (callingClsName.endsWith("Log") || (callingClsName.endsWith("Logger"))) {
@@ -316,6 +321,10 @@
}
}
+ /**
+ * looks for slf4j calls where an exception is passed as a logger parameter, expecting to be substituted for a {}
+ * marker. As slf4j just passes the exception down to the message generation itself, the {} marker will go unpopulated.
+ */
private void checkForLoggerParam() {
if (Values.CONSTRUCTOR.equals(getNameConstantOperand())) {
String cls = getClassConstantOperand();
@@ -339,6 +348,11 @@
}
}
+ /**
+ * looks for instantiation of a logger with what looks like a class name that isn't the same
+ * as the class in which it exists. There are some cases where a 'classname-like' string is
+ * presented purposely different than this class, and an attempt is made to ignore those.
+ */
private void lookForSuspectClasses() {
String callingClsName = getClassConstantOperand();
String mthName = getNameConstantOperand();
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
