[Fb-contrib-commit] SF.net SVN: fb-contrib: [907] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/MethodReturnsConstant.java

[<dbr...@us...>]

Revision: 907
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=907&view=rev
Author:   dbrosius
Date:     2007-09-15 17:27:48 -0700 (Sat, 15 Sep 2007)

Log Message:
-----------
if a method has a trinary, it makes it difficult to figure out whether a constant return is used, so marked these methods as not suspect, to avoid false positives.

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MethodReturnsConstant.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MethodReturnsConstant.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MethodReturnsConstant.java	2007-09-16 00:19:29 UTC (rev 906)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MethodReturnsConstant.java	2007-09-16 00:27:48 UTC (rev 907)
@@ -112,6 +112,10 @@
 					
 					returnConstant = constant;
 				}
+			} else if ((seen == GOTO) || (seen == GOTO_W)) {
+				if (stack.getStackDepth() > 0) {
+					methodSuspect = false; //Trinaries confuse us to much, if the code has a trinary well - oh well
+				}
 			}
 		} finally {
 			stack.sawOpcode(this, seen);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.