[Fb-contrib-commit] SF.net SVN: fb-contrib: [906] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/MethodReturnsConstant.java

[<dbr...@us...>]

Revision: 906
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=906&view=rev
Author:   dbrosius
Date:     2007-09-15 17:19:29 -0700 (Sat, 15 Sep 2007)

Log Message:
-----------
guard against npes

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MethodReturnsConstant.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MethodReturnsConstant.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MethodReturnsConstant.java	2007-09-15 18:59:26 UTC (rev 905)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MethodReturnsConstant.java	2007-09-16 00:19:29 UTC (rev 906)
@@ -73,7 +73,7 @@
 			methodSuspect = true;
 			returnPC = -1;
 			super.visitCode(obj);
-			if (methodSuspect) {
+			if (methodSuspect && (returnConstant != null)) {
 				BugInstance bi = new BugInstance(this, "MRC_METHOD_RETURNS_CONSTANT", NORMAL_PRIORITY)
 									.addClass(this)
 									.addMethod(this);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.