[Fb-contrib-commit] SF.net SVN: fb-contrib: [888] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/UseAddAll.java

[<dbr...@us...>]

Revision: 888
          http://svn.sourceforge.net/fb-contrib/?rev=888&view=rev
Author:   dbrosius
Date:     2007-06-25 15:14:58 -0700 (Mon, 25 Jun 2007)

Log Message:
-----------
some fixes - still not working

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseAddAll.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseAddAll.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseAddAll.java	2007-06-24 22:58:05 UTC (rev 887)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseAddAll.java	2007-06-25 22:14:58 UTC (rev 888)
@@ -118,8 +118,8 @@
 						}
 					}
 				} else if ("keySet".equals(methodName) || "values".equals(methodName) || "iterator".equals(methodName) || "next".equals(methodName)) {
-					if (stack.getStackDepth() > 1) {
-						OpcodeStack.Item itm = stack.getStackItem(1);
+					if (stack.getStackDepth() > 0) {
+						OpcodeStack.Item itm = stack.getStackItem(0);
 						reg = isLocalCollection(itm);
 						if (reg >= 0) {
 							sawAlias = true;
@@ -132,7 +132,7 @@
 						reg = isLocalCollection(colItem);
 						if ((reg >= 0)
 						&&  (valueItem.getUserValue() != null)) {
-							bugReporter.reportBug(new BugInstance(this, "UTA_USE_ADD_ALL", NORMAL_PRIORITY)
+							bugReporter.reportBug(new BugInstance(this, "UAA_USE_ADD_ALL", NORMAL_PRIORITY)
 										.addClass(this)
 										.addMethod(this)
 										.addSourceLine(this));


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.