[Fb-contrib-commit] SF.net SVN: fb-contrib: [781] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/BloatedAssignmentScope.java

[<dbr...@us...>]

Revision: 781
          http://svn.sourceforge.net/fb-contrib/?rev=781&view=rev
Author:   dbrosius
Date:     2007-01-27 21:29:58 -0800 (Sat, 27 Jan 2007)

Log Message:
-----------
experiment with removing null assignments from BAS

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedAssignmentScope.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedAssignmentScope.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedAssignmentScope.java	2007-01-27 06:09:09 UTC (rev 780)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedAssignmentScope.java	2007-01-28 05:29:58 UTC (rev 781)
@@ -52,6 +52,7 @@
     private Set<Integer> switchTargets;
     private boolean dontReport;
     private boolean sawDup;
+    private boolean sawNull;
 	
 	/**
      * constructs a BAS detector given the reporter to report bugs on
@@ -112,6 +113,7 @@
             switchTargets.clear();
             dontReport = false;
             sawDup = false;
+            sawNull = false;
 			super.visitCode(obj);
 			
             if (!dontReport)
@@ -145,6 +147,9 @@
             int pc = getPC();
             if (catchHandlers.contains(Integer14.valueOf(pc)))
                 ignoreRegs.add(iReg);
+            if (sawNull) {
+            	ignoreRegs.add(iReg);
+            }
 			if (!ignoreRegs.contains(iReg)) {
 				ScopeBlock sb = findScopeBlock(rootScopeBlock, pc);
 				if (sb != null) {
@@ -242,6 +247,7 @@
         } 
         
         sawDup = (seen == DUP);
+        sawNull = (seen == ACONST_NULL);
 	}
 	
 	/** 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.