[Fb-contrib-commit] SF.net SVN: fb-contrib: [748] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect

[<dbr...@us...>]

Revision: 748
          http://svn.sourceforge.net/fb-contrib/?rev=748&view=rev
Author:   dbrosius
Date:     2006-12-22 10:21:00 -0800 (Fri, 22 Dec 2006)

Log Message:
-----------
BAS fixes

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DubiousListCollection.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OverlyConcreteParameter.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SluggishGui.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DubiousListCollection.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DubiousListCollection.java	2006-12-22 04:18:42 UTC (rev 747)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DubiousListCollection.java	2006-12-22 18:21:00 UTC (rev 748)
@@ -127,15 +127,15 @@
 			
 			if (seen == INVOKEINTERFACE) {
 				String className = this.getClassConstantOperand();
-				String methodName = getNameConstantOperand();
-				String signature = getSigConstantOperand();
 				
 				if (className.startsWith("java/util/") && className.endsWith("List")) {
+					String signature = getSigConstantOperand();
 					XField field = getFieldFromStack(stack, signature);
 					if (field != null) {
 						String fieldName = field.getName();
 						FieldInfo fi = fieldsReported.get(fieldName);
 						if (fi != null) {
+							String methodName = getNameConstantOperand();
 							String methodInfo = methodName + signature;
 							if (listMethods.contains(methodInfo))
 								fieldsReported.remove(fieldName);

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java	2006-12-22 04:18:42 UTC (rev 747)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java	2006-12-22 18:21:00 UTC (rev 748)
@@ -364,11 +364,11 @@
 	 */
 	private void processCollectionStore(int seen) {
 		String fieldClassName = getDottedClassConstantOperand();
-		String fieldName = getNameConstantOperand();
 		if (fieldClassName.equals(className)) {
 			if (stack.getStackDepth() > 0) {
 				OpcodeStack.Item item = stack.getStackItem(0);
 				if (item.getUserValue() != null) {
+					String fieldName = getNameConstantOperand();
 					if (fieldName != null) {
 						FieldInfo fi = collectionFields.get(fieldName);
 						if (fi != null) {

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OverlyConcreteParameter.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OverlyConcreteParameter.java	2006-12-22 04:18:42 UTC (rev 747)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OverlyConcreteParameter.java	2006-12-22 18:21:00 UTC (rev 748)
@@ -321,12 +321,13 @@
 	}
 	
 	private void removeUselessDefiners(final int reg) {
-		String methodSig = getSigConstantOperand();
-		String methodName = getNameConstantOperand();
-		String methodInfo = methodName + methodSig;
 		
 		Map<JavaClass, List<String>> definers = parameterDefiners.get(Integer14.valueOf(reg));
 		if ((definers != null) && (definers.size() > 0)) {
+			String methodSig = getSigConstantOperand();
+			String methodName = getNameConstantOperand();
+			String methodInfo = methodName + methodSig;
+			
 			Iterator<List<String>> it = definers.values().iterator();
 			while (it.hasNext()) {
 				boolean methodDefined = false;

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SluggishGui.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SluggishGui.java	2006-12-22 04:18:42 UTC (rev 747)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SluggishGui.java	2006-12-22 18:21:00 UTC (rev 748)
@@ -192,7 +192,6 @@
 			String clsName = getClassConstantOperand();
 			String methodName = getNameConstantOperand();
 			String methodInfo = clsName + ":" + methodName;
-			String methodSig = getSigConstantOperand();
 			String thisMethodInfo = (clsName.equals(getClassName())) ? (methodName + ":" + methodSig) : "0";
 				
 			if (expensiveCalls.contains(methodInfo) || expensiveThisCalls.contains(thisMethodInfo)) {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.