[Fb-contrib-commit] SF.net SVN: fb-contrib: [715] trunk/fb-contrib/etc

[<dbr...@us...>]

Revision: 715
          http://svn.sourceforge.net/fb-contrib/?rev=715&view=rev
Author:   dbrosius
Date:     2006-12-09 21:04:14 -0800 (Sat, 09 Dec 2006)

Log Message:
-----------
initial checkin - SCII detector

Modified Paths:
--------------
    trunk/fb-contrib/etc/findbugs.xml
    trunk/fb-contrib/etc/messages.xml

Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================
--- trunk/fb-contrib/etc/findbugs.xml	2006-12-10 04:13:12 UTC (rev 714)
+++ trunk/fb-contrib/etc/findbugs.xml	2006-12-10 05:04:14 UTC (rev 715)
@@ -262,6 +262,10 @@
 			speed="fast"
 			reports="BAS_BLOATED_ASSIGNMENT_SCOPE" />	
 			
+	<Detector class="com.mebigfatguy.fbcontrib.detect.SpoiledChildInterfaceImplementor"
+			speed="fast"
+			reports="SCI_SPOILED_CHILD_INTERFACE_IMPLEMENTOR" />
+			
    	<!-- BugPattern -->
 	
 	<BugPattern abbrev="ISB" type="ISB_INEFFICIENT_STRING_BUFFERING" category="PERFORMANCE" />
@@ -335,4 +339,5 @@
 	<BugPattern abbrev="SPP" type="SPP_USE_ISNAN" category="CORRECTNESS" experimental="true" />
 	<BugPattern abbrev="SPP" type="SPP_USE_BIGDECIMAL_STRING_CTOR" category="CORRECTNESS" experimental="true" />
 	<BugPattern abbrev="BAS" type="BAS_BLOATED_ASSIGNMENT_SCOPE" category="PERFORMANCE" experimental="true" />
+	<BugPattern abbrev="SCII" type="SCII_SPOILED_CHILD_INTERFACE_IMPLEMENTATOR" category="STYLE" experimental="true" />
 </FindbugsPlugin>
\ No newline at end of file

Modified: trunk/fb-contrib/etc/messages.xml
===================================================================
--- trunk/fb-contrib/etc/messages.xml	2006-12-10 04:13:12 UTC (rev 714)
+++ trunk/fb-contrib/etc/messages.xml	2006-12-10 05:04:14 UTC (rev 715)
@@ -702,6 +702,16 @@
 			]]>
 		</Details>
 	</Detector>
+	
+	<Detector class="com.mebigfatguy.fbcontrib.detect.SpoiledChildInterfaceImplementor">
+		<Details>
+			<![CDATA[
+			<p>looks for classes that implement interfaces by relying on methods being 
+			implemented in superclasses, even tho the superclass knows nothing about
+			the interface being implemented by the child.</p>
+			]]>
+		</Details>
+	</Detector>
 
 	<!-- BugPattern -->
 	                
@@ -1618,6 +1628,20 @@
 		</Details>
 	</BugPattern>
 	
+	<BugPattern type="SCII_SPOILED_CHILD_INTERFACE_IMPLEMENTATOR">
+		<ShortDescription>Class implements interface by relying on unknowing superclass methods</ShortDescription>
+		<LongDescription>Class {0} implements interface by relying on unknowing superclass methods</LongDescription>
+		<Details>
+			<![CDATA[
+			<p>This class declares that it implements an interface, but does so by relying on methods supplied
+			by superclasses, even though those superclasses know nothing about the interface in question. If you wish
+			to have the child not implement all the methods of the interface, it would probably be better to declare
+			the superclass as implementing the interface, and if that class does not provide all the methods, then declare
+			that superclass abstract.</p>
+			]]>
+		</Details>
+	</BugPattern>
+	
 	<!-- BugCode -->
 	
 	<BugCode abbrev="ISB">Inefficient String Buffering</BugCode>
@@ -1678,5 +1702,5 @@
 	<BugCode abbrev="SCRV">Suspicious Comparator Return Values</BugCode>
 	<BugCode abbrev="SPP">Sillyness Pot Pourri</BugCode>
 	<BugCode abbrev="BAS">Bloated Assignment Scope</BugCode>
-
+	<BugCode abbrev="SCII">Spoiled Child Interface Implementor</BugCode>
 </MessageCollection>
\ No newline at end of file


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.