[Fb-contrib-commit] SF.net SVN: fb-contrib: [675] trunk/fb-contrib/etc

[<dbr...@us...>]

Revision: 675
          http://svn.sourceforge.net/fb-contrib/?rev=675&view=rev
Author:   dbrosius
Date:     2006-10-28 10:47:13 -0700 (Sat, 28 Oct 2006)

Log Message:
-----------
add sc to the xml files

Modified Paths:
--------------
    trunk/fb-contrib/etc/findbugs.xml
    trunk/fb-contrib/etc/messages.xml

Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================
--- trunk/fb-contrib/etc/findbugs.xml	2006-10-27 05:27:56 UTC (rev 674)
+++ trunk/fb-contrib/etc/findbugs.xml	2006-10-28 17:47:13 UTC (rev 675)
@@ -249,6 +249,11 @@
 	<Detector class="com.mebigfatguy.fbcontrib.detect.PossibleIncompleteSerialization"
 			speed="fast"
 			reports="PIS_POSSIBLE_INCOMPLETE_SERIALIZATION" />
+			
+	<Detector class="com.mebigfatguy.fbcontrib.detect.SuspiciousComparator"
+			speed="fast"
+			reports="SC_SUSPICIOUS_COMPARATOR"/>
+			
    	<!-- BugPattern -->
 	
 	<BugPattern abbrev="ISB" type="ISB_INEFFICIENT_STRING_BUFFERING" category="PERFORMANCE" />
@@ -306,11 +311,12 @@
 	<BugPattern abbrev="SACM" type="SACM_STATIC_ARRAY_CREATED_IN_METHOD" category="PERFORMANCE" />
 	<BugPattern abbrev="PRMC" type="PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS" category="PERFORMANCE" />
 	<BugPattern abbrev="UTA" type="UTA_USE_TO_ARRAY" category="STYLE" />
-	<BugPattern abbrev="LEST" type="LEST_LOST_EXCEPTION_STACK_TRACE" category="CORRECTNESS" experimental="true" />
-	<BugPattern abbrev="UCPM" type="UCPM_USE_CHARACTER_PARAMETERIZED_METHOD" category="PERFORMANCE" experimental="true" />
-	<BugPattern abbrev="TR" type="TR_TAIL_RECURSION" category="PERFORMANCE" experimental="true" />
-	<BugPattern abbrev="URV" type="URV_UNRELATED_RETURN_VALUES" category="STYLE" experimental="true" />
-	<BugPattern abbrev="URV" type="URV_CHANGE_RETURN_TYPE" category="STYLE" experimental="true" />
-	<BugPattern abbrev="URV" type="URV_INHERITED_METHOD_WITH_RELATED_TYPES" category="STYLE" experimental="true" />
-	<BugPattern abbrev="PIS" type="PIS_POSSIBLE_INCOMPLETE_SERIALIZATION" category="CORRECTNESS" experimental="true" />
+	<BugPattern abbrev="LEST" type="LEST_LOST_EXCEPTION_STACK_TRACE" category="CORRECTNESS" />
+	<BugPattern abbrev="UCPM" type="UCPM_USE_CHARACTER_PARAMETERIZED_METHOD" category="PERFORMANCE" />
+	<BugPattern abbrev="TR" type="TR_TAIL_RECURSION" category="PERFORMANCE" />
+	<BugPattern abbrev="URV" type="URV_UNRELATED_RETURN_VALUES" category="STYLE" />
+	<BugPattern abbrev="URV" type="URV_CHANGE_RETURN_TYPE" category="STYLE" />
+	<BugPattern abbrev="URV" type="URV_INHERITED_METHOD_WITH_RELATED_TYPES" category="STYLE" />
+	<BugPattern abbrev="PIS" type="PIS_POSSIBLE_INCOMPLETE_SERIALIZATION" category="CORRECTNESS" />
+	<BugPattern abbrev="SC" type="SC_SUSPICIOUS_COMPARATOR" category="CORRECTNESS" experimental="true" />
 </FindbugsPlugin>
\ No newline at end of file

Modified: trunk/fb-contrib/etc/messages.xml
===================================================================
--- trunk/fb-contrib/etc/messages.xml	2006-10-27 05:27:56 UTC (rev 674)
+++ trunk/fb-contrib/etc/messages.xml	2006-10-28 17:47:13 UTC (rev 675)
@@ -675,6 +675,16 @@
 			]]>
 		</Details>
 	</Detector>
+	
+	<Detector class="com.mebigfatguy.fbcontrib.detect.SuspiciousComparator">
+		<Details>
+			<![CDATA[
+			<p>looks for class that implement Comparator or Comparable, and whose compare or compareTo
+ 			methods return constant values only, but that don't represent the three possible choice
+			(a negative number, 0, and a positive number).</p>
+			]]>
+		</Details>
+	</Detector>
 
 	<!-- BugPattern -->
 	                
@@ -1486,6 +1496,18 @@
 		</Details>
 	</BugPattern>
 	
+	<BugPattern type="SC_SUSPICIOUS_COMPARATOR">
+		<ShortDescription>Comparator method doesn't seem to return all ordering values</ShortDescription>
+		<LongDescription>Comparator method {1} doesn't seem to return all ordering values</LongDescription>
+		<Details>
+			<![CDATA[
+				<p>This compareTo or compare method returns constant values for to represent less than,
+				equals and greater than. However it does not return each type. Given that comparators 
+				are transitive, this seems incorrect.</p>
+			]]>
+		</Details>
+	</BugPattern>
+	
 	<!-- BugCode -->
 	
 	<BugCode abbrev="ISB">Inefficient String Buffering</BugCode>
@@ -1543,4 +1565,5 @@
 	<BugCode abbrev="TR">Tail Recursion</BugCode>
 	<BugCode abbrev="URV">Unrelated Return Values</BugCode>
 	<BugCode abbrev="PIS">Possible Incomplete Serialization</BugCode>
+	<BugCode abbrev="SC">Suspicious Comparator</BugCode>
 </MessageCollection>
\ No newline at end of file


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.