[Fb-contrib-commit] SF.net SVN: fb-contrib: [649] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/AbnormalFinallyBlockReturn.java

[<dbr...@us...>]

Revision: 649
          http://svn.sourceforge.net/fb-contrib/?rev=649&view=rev
Author:   dbrosius
Date:     2006-09-13 21:57:15 -0700 (Wed, 13 Sep 2006)

Log Message:
-----------
add TODOs to AFBR

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbnormalFinallyBlockReturn.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbnormalFinallyBlockReturn.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbnormalFinallyBlockReturn.java	2006-09-14 04:42:03 UTC (rev 648)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbnormalFinallyBlockReturn.java	2006-09-14 04:57:15 UTC (rev 649)
@@ -27,6 +27,8 @@
 import edu.umd.cs.findbugs.BugInstance;
 import edu.umd.cs.findbugs.BugReporter;
 import edu.umd.cs.findbugs.BytecodeScanningDetector;
+import edu.umd.cs.findbugs.FindBugsAnalysisFeatures;
+import edu.umd.cs.findbugs.ba.AnalysisContext;
 import edu.umd.cs.findbugs.ba.ClassContext;
 
 /**
@@ -54,6 +56,10 @@
 	 */
 	@Override
 	public void visitClassContext(ClassContext classContext) {
+		//TODO: Look at method calls in a finally block to see if they throw exceptions
+		//    : and those exceptions are not caught in the finally block
+		//    : Only do it if effort is on, ie: boolean fullAnalysis = AnalysisContext.currentAnalysisContext().getBoolProperty(FindBugsAnalysisFeatures.INTERPROCEDURAL_ANALYSIS_OF_REFERENCED_CLASSES);
+
 		try {
 	        int majorVersion = classContext.getJavaClass().getMajor();
 	        if (majorVersion >= MAJOR_1_4) {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.