[Fb-contrib-commit] SF.net SVN: fb-contrib: [640] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect

[<dbr...@us...>]

Revision: 640
          http://svn.sourceforge.net/fb-contrib/?rev=640&view=rev
Author:   dbrosius
Date:     2006-09-09 20:54:51 -0700 (Sat, 09 Sep 2006)

Log Message:
-----------
misc fixes suggested by fb-contrib

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ClassEnvy.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FieldCouldBeLocal.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonRecycleableTaglibs.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ClassEnvy.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ClassEnvy.java	2006-09-10 01:51:12 UTC (rev 639)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ClassEnvy.java	2006-09-10 03:54:51 UTC (rev 640)
@@ -347,7 +347,7 @@
 	 * @return the package of the class
 	 */
 	private String getPackageName(final String className) {
-		int dotPos = className.lastIndexOf(".");
+		int dotPos = className.lastIndexOf('.');
 		if (dotPos < 0)
 			return "";
 		return className.substring(0, dotPos);

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FieldCouldBeLocal.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FieldCouldBeLocal.java	2006-09-10 01:51:12 UTC (rev 639)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FieldCouldBeLocal.java	2006-09-10 03:54:51 UTC (rev 640)
@@ -85,7 +85,7 @@
 		JavaClass cls = classContext.getJavaClass();
 		Field[] fields = cls.getFields();
 		for (Field f : fields) {
-			if ((!f.isStatic() && f.getName().indexOf("$") < 0) && f.isPrivate()) {
+			if ((!f.isStatic() && f.getName().indexOf('$') < 0) && f.isPrivate()) {
 				FieldAnnotation fa = new FieldAnnotation(cls.getClassName(), f.getName(), f.getSignature(), false);
 				localizableFields.put(f.getName(), new FieldInfo(fa));
 			}

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonRecycleableTaglibs.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonRecycleableTaglibs.java	2006-09-10 01:51:12 UTC (rev 639)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonRecycleableTaglibs.java	2006-09-10 03:54:51 UTC (rev 640)
@@ -189,8 +189,9 @@
 			
 			
 			String fieldInfo = fields.keySet().iterator().next();
-			String fieldName = fieldInfo.substring(0, fieldInfo.indexOf(":"));
-			String fieldType = fieldInfo.substring(fieldInfo.indexOf(":")+1);
+			int colonPos = fieldInfo.indexOf(':');
+			String fieldName = fieldInfo.substring(0, colonPos);
+			String fieldType = fieldInfo.substring(colonPos+1);
 			
 			if (!attType.equals(fieldType))
 				continue;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.