[Fb-contrib-commit] SF.net SVN: fb-contrib: [590] trunk/fb-contrib/etc

[<dbr...@us...>]

Revision: 590
Author:   dbrosius
Date:     2006-08-07 20:59:39 -0700 (Mon, 07 Aug 2006)
ViewCVS:  http://svn.sourceforge.net/fb-contrib/?rev=590&view=rev

Log Message:
-----------
add info for LEST

Modified Paths:
--------------
    trunk/fb-contrib/etc/findbugs.xml
    trunk/fb-contrib/etc/messages.xml
Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================
--- trunk/fb-contrib/etc/findbugs.xml	2006-08-08 03:19:37 UTC (rev 589)
+++ trunk/fb-contrib/etc/findbugs.xml	2006-08-08 03:59:39 UTC (rev 590)
@@ -230,6 +230,10 @@
 			speed="fast"
 			reports="UTA_USE_TO_ARRAY" />
 			
+	<Detector class="com.mebigfatguy.fbcontrib.detect.LostExceptionStackTrace"
+			speed="moderate"
+			reports="LEST_LOST_EXCEPTION_STACK_TRACE" />
+			
    	<!-- BugPattern -->
 	
 	<BugPattern abbrev="ISB" type="ISB_INEFFICIENT_STRING_BUFFERING" category="PERFORMANCE" />
@@ -283,8 +287,9 @@
 	<BugPattern abbrev="UEC" type="UEC_USE_ENUM_COLLECTIONS" category="PERFORMANCE" />
 	<BugPattern abbrev="SIL" type="SIL_SQL_IN_LOOP" category="PERFORMANCE" />
 	<BugPattern abbrev="NMCS" type="NMCS_NEEDLESS_MEMBER_COLLECTION_SYNCHRONIZATION" category="PERFORMANCE" />
-	<BugPattern abbrev="ITC" type="ITC_INHERITANCE_TYPE_CHECKING" category="STYLE" experimental="true" />
-	<BugPattern abbrev="SACM" type="SACM_STATIC_ARRAY_CREATED_IN_METHOD" category="PERFORMANCE" experimental="true" />
-	<BugPattern abbrev="RMC" type="RMC_REDUNDANT_METHOD_CALLS" category="PERFORMANCE" experimental="true" />
-	<BugPattern abbrev="UTA" type="UTA_USE_TO_ARRAY" category="STYLE" experimental="true" />
+	<BugPattern abbrev="ITC" type="ITC_INHERITANCE_TYPE_CHECKING" category="STYLE" />
+	<BugPattern abbrev="SACM" type="SACM_STATIC_ARRAY_CREATED_IN_METHOD" category="PERFORMANCE" />
+	<BugPattern abbrev="RMC" type="RMC_REDUNDANT_METHOD_CALLS" category="PERFORMANCE" />
+	<BugPattern abbrev="UTA" type="UTA_USE_TO_ARRAY" category="STYLE" />
+	<BugPattern abbrev="LEST" type="LEST_LOST_EXCEPTION_STACK_TRACE" category="CORRECTNESS" />
 </FindbugsPlugin>
\ No newline at end of file

Modified: trunk/fb-contrib/etc/messages.xml
===================================================================
--- trunk/fb-contrib/etc/messages.xml	2006-08-08 03:19:37 UTC (rev 589)
+++ trunk/fb-contrib/etc/messages.xml	2006-08-08 03:59:39 UTC (rev 590)
@@ -619,6 +619,17 @@
 			]]>
 		</Details>
 	</Detector>
+	
+	<Detector class="com.mebigfatguy.fbcontrib.detect.LostExceptionStackTrace">
+		<Details>
+			<![CDATA[
+			<p>looks for methods that catch exceptions, and then throw a different exception,
+			without embedding the original exception in the thrown one. Doing so, hides the real
+			source of the exception, making debugging and fixing these problems difficult.</p>
+			<p>It is a moderately fast detector</p>
+			]]>
+		</Details>
+	</Detector>
 			
 
 	<!-- BugPattern -->
@@ -1340,6 +1351,19 @@
 		</Details>
 	</BugPattern>
 	
+	<BugPattern type="LEST_LOST_EXCEPTION_STACK_TRACE">
+		<ShortDescription>Method throws alternative exception from catch block without history</ShortDescription>
+		<LongDescription>Method {1} throws alternative exception from catch block without history</LongDescription>
+		<Details>
+			<![CDATA[
+				<p>This method catches an exception, and throws a different exception, without incorporating the 
+				original exception. Doing so hides the original source of the exception making debugging and fixing
+				these problems difficult. It is better to use the constructor of this new exception that takes an 
+				original exception so that this detail can be passed along to the user.</p>
+			]]>
+		</Details>
+	</BugPattern>
+	
 	<!-- BugCode -->
 	
 	<BugCode abbrev="ISB">Inefficient String Buffering</BugCode>
@@ -1392,4 +1416,5 @@
 	<BugCode abbrev="SACM">Static Array Created in Method</BugCode>
 	<BugCode abbrev="RMC">Redundant Method Calls</BugCode>
 	<BugCode abbrev="UTA">Use toArray</BugCode>
+	<BugCode abbrev="LEST">Lost Exception Stack Trace</BugCode>
 </MessageCollection>
\ No newline at end of file


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.