[Fb-contrib-commit] SF.net SVN: fb-contrib: [561] trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InefficientStringBuffering.java

[<dbr...@us...>]

Revision: 561
Author:   dbrosius
Date:     2006-06-08 10:52:39 -0700 (Thu, 08 Jun 2006)
ViewCVS:  http://svn.sourceforge.net/fb-contrib/?rev=561&view=rev

Log Message:
-----------
try to suppress more fp's due to trinaries around string buffering

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InefficientStringBuffering.java
Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InefficientStringBuffering.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InefficientStringBuffering.java	2006-06-08 02:47:32 UTC (rev 560)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InefficientStringBuffering.java	2006-06-08 17:52:39 UTC (rev 561)
@@ -76,9 +76,11 @@
 					}
 				}
 			} else if (seen == GOTO) {
-				OpcodeStack.Item itm = getStringBufferItemAt(1);
-				if (itm != null)
+				int depth = opStack.getStackDepth();
+				for (int i = 0; i < depth; i++) {
+					OpcodeStack.Item itm = opStack.getStackItem(i);
 					itm.setUserValue(Boolean.TRUE);
+				}
 			}
 		} finally {
 			opStack.sawOpcode(this, seen);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.