[Fb-contrib-commit] SF.net SVN: fb-contrib: [524] trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java

[<dbr...@us...>]

Revision: 524
Author:   dbrosius
Date:     2006-05-09 00:41:02 -0700 (Tue, 09 May 2006)
ViewCVS:  http://svn.sourceforge.net/fb-contrib/?rev=524&view=rev

Log Message:
-----------
a lil more... far from done

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java
Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java	2006-05-09 07:25:51 UTC (rev 523)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java	2006-05-09 07:41:02 UTC (rev 524)
@@ -156,9 +156,7 @@
 		try {
 			stack.mergeJumps(this);
 			isSyncCollection = isSyncCollectionCreation(seen);
-			if (seen == PUTFIELD) {
-				processCollectionStore(PUTSTATIC, seen);
-			}
+			processCollectionStore(PUTSTATIC, seen);
 		} finally {
 			stack.sawOpcode(this, seen);
 			if (isSyncCollection) {
@@ -176,7 +174,6 @@
 			stack.mergeJumps(this);
 			isSyncCollection = isSyncCollectionCreation(seen);
 			processCollectionStore(PUTFIELD, seen);
-			
 		} finally {
 			stack.sawOpcode(this, seen);
 			if (isSyncCollection) {
@@ -191,9 +188,9 @@
 	private void sawMethodOpcode(int seen) {
 		try {
 			stack.mergeJumps(this);
-			if (isSyncCollectionCreation(seen)) {
-				
-			}
+			
+			//look for code that alters the collection, passes it to a method, returns it, etc
+			//watch out for aliases
 		} finally {
 			stack.sawOpcode(this, seen);
 		}


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.