[Fb-contrib-commit] SF.net SVN: fb-contrib: [475] trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/det
Brought to you by:
dbrosius
Menu
▾
▴
[Fb-contrib-commit] SF.net SVN: fb-contrib: [475] trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect
|
From: <dbr...@us...> - 2006-04-18 03:13:37
|
Revision: 475 Author: dbrosius Date: 2006-04-17 20:13:27 -0700 (Mon, 17 Apr 2006) ViewCVS: http://svn.sourceforge.net/fb-contrib/?rev=475&view=rev Log Message: ----------- clear stuff in the finally block Modified Paths: -------------- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbnormalFinallyBlockReturn.java trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayBasedCollections.java trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedSynchronizedBlock.java trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ClassEnvy.java trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConstantListIndex.java trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CustomBuiltXML.java trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CyclomaticComplexity.java trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeclaredRuntimeException.java trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ListIndexedIterating.java Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbnormalFinallyBlockReturn.java =================================================================== --- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbnormalFinallyBlockReturn.java 2006-04-18 03:04:50 UTC (rev 474) +++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbnormalFinallyBlockReturn.java 2006-04-18 03:13:27 UTC (rev 475) @@ -54,12 +54,15 @@ */ @Override public void visitClassContext(ClassContext classContext) { - int majorVersion = classContext.getJavaClass().getMajor(); - if (majorVersion >= MAJOR_1_4) { - fbInfo = new ArrayList<FinallyBlockInfo>(); - super.visitClassContext(classContext); - fbInfo = null; - } + try { + int majorVersion = classContext.getJavaClass().getMajor(); + if (majorVersion >= MAJOR_1_4) { + fbInfo = new ArrayList<FinallyBlockInfo>(); + super.visitClassContext(classContext); + } + } finally { + fbInfo = null; + } } /** Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayBasedCollections.java =================================================================== --- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayBasedCollections.java 2006-04-18 03:04:50 UTC (rev 474) +++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayBasedCollections.java 2006-04-18 03:13:27 UTC (rev 475) @@ -61,26 +61,29 @@ */ @Override public void visitClassContext(ClassContext classContext) { - stack = new OpcodeStack(); - mapBugs = new ArrayList<BugInstance>(); - setBugs = new ArrayList<BugInstance>(); - hasMapComparator = false; - hasSetComparator = false; - super.visitClassContext(classContext); - if (!hasMapComparator) { - for (BugInstance bi : mapBugs) { - bugReporter.reportBug(bi); + try { + stack = new OpcodeStack(); + mapBugs = new ArrayList<BugInstance>(); + setBugs = new ArrayList<BugInstance>(); + hasMapComparator = false; + hasSetComparator = false; + super.visitClassContext(classContext); + if (!hasMapComparator) { + for (BugInstance bi : mapBugs) { + bugReporter.reportBug(bi); + } } - } - - if (!hasSetComparator) { - for (BugInstance bi : setBugs) { - bugReporter.reportBug(bi); + + if (!hasSetComparator) { + for (BugInstance bi : setBugs) { + bugReporter.reportBug(bi); + } } + } finally { + stack = null; + mapBugs = null; + setBugs = null; } - stack = null; - mapBugs = null; - setBugs = null; } /** Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java =================================================================== --- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java 2006-04-18 03:04:50 UTC (rev 474) +++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java 2006-04-18 03:13:27 UTC (rev 475) @@ -72,11 +72,14 @@ */ @Override public void visitClassContext(ClassContext classContext) { - stack = new OpcodeStack(); - wrappers = new HashMap<Integer, WrapperInfo>(); - super.visitClassContext(classContext); - stack = null; - wrappers = null; + try { + stack = new OpcodeStack(); + wrappers = new HashMap<Integer, WrapperInfo>(); + super.visitClassContext(classContext); + } finally { + stack = null; + wrappers = null; + } } /** Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedSynchronizedBlock.java =================================================================== --- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedSynchronizedBlock.java 2006-04-18 03:04:50 UTC (rev 474) +++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedSynchronizedBlock.java 2006-04-18 03:13:27 UTC (rev 475) @@ -66,13 +66,16 @@ @Override public void visitClassContext(ClassContext classContext) { - stack = new OpcodeStack(); - unsafeAliases = new HashSet<Integer>(); - branchInfo = new HashMap<Integer, Integer>(); - super.visitClassContext(classContext); - stack = null; - unsafeAliases = null; - branchInfo = null; + try { + stack = new OpcodeStack(); + unsafeAliases = new HashSet<Integer>(); + branchInfo = new HashMap<Integer, Integer>(); + super.visitClassContext(classContext); + } finally { + stack = null; + unsafeAliases = null; + branchInfo = null; + } } /** Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ClassEnvy.java =================================================================== --- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ClassEnvy.java 2006-04-18 03:04:50 UTC (rev 474) +++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ClassEnvy.java 2006-04-18 03:13:27 UTC (rev 475) @@ -89,13 +89,16 @@ */ @Override public void visitClassContext(final ClassContext classContext) { - JavaClass cls = classContext.getJavaClass(); - packageName = cls.getPackageName(); - clsName = cls.getClassName(); - stack = new OpcodeStack(); - super.visitClassContext(classContext); - stack = null; - clsAccessCount = null; + try { + JavaClass cls = classContext.getJavaClass(); + packageName = cls.getPackageName(); + clsName = cls.getClassName(); + stack = new OpcodeStack(); + super.visitClassContext(classContext); + } finally { + stack = null; + clsAccessCount = null; + } } /** Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConstantListIndex.java =================================================================== --- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConstantListIndex.java 2006-04-18 03:04:50 UTC (rev 474) +++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConstantListIndex.java 2006-04-18 03:13:27 UTC (rev 475) @@ -65,9 +65,12 @@ */ @Override public void visitClassContext(ClassContext classContext) { - iConst0Looped = new HashSet<Integer>(); - super.visitClassContext(classContext); - iConst0Looped = null; + try { + iConst0Looped = new HashSet<Integer>(); + super.visitClassContext(classContext); + } finally { + iConst0Looped = null; + } } /** Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CustomBuiltXML.java =================================================================== --- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CustomBuiltXML.java 2006-04-18 03:04:50 UTC (rev 474) +++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CustomBuiltXML.java 2006-04-18 03:13:27 UTC (rev 475) @@ -83,9 +83,12 @@ */ @Override public void visitClassContext(ClassContext classContext) { - stack = new OpcodeStack(); - super.visitClassContext(classContext); - stack = null; + try { + stack = new OpcodeStack(); + super.visitClassContext(classContext); + } finally { + stack = null; + } } /** Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CyclomaticComplexity.java =================================================================== --- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CyclomaticComplexity.java 2006-04-18 03:04:50 UTC (rev 474) +++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CyclomaticComplexity.java 2006-04-18 03:13:27 UTC (rev 475) @@ -65,9 +65,12 @@ * @param context the context object for the currently parsed class */ public void visitClassContext(final ClassContext context) { - classContext = context; - classContext.getJavaClass().accept(this); - classContext = null; + try { + classContext = context; + classContext.getJavaClass().accept(this); + } finally { + classContext = null; + } } /** Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeclaredRuntimeException.java =================================================================== --- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeclaredRuntimeException.java 2006-04-18 03:04:50 UTC (rev 474) +++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeclaredRuntimeException.java 2006-04-18 03:13:27 UTC (rev 475) @@ -63,16 +63,6 @@ } /** - * clone this detector so that it can be a StatelessDetector - * - * @return a clone of this object - */ - @Override - public Object clone() throws CloneNotSupportedException { - return super.clone(); - } - - /** * overrides the visitor and accepts if the Exception class was loaded * * @param classContext the context object for the currently parsed class Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ListIndexedIterating.java =================================================================== --- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ListIndexedIterating.java 2006-04-18 03:04:50 UTC (rev 474) +++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ListIndexedIterating.java 2006-04-18 03:13:27 UTC (rev 475) @@ -74,11 +74,14 @@ */ @Override public void visitClassContext(ClassContext classContext) { - stack = new OpcodeStack(); - possibleForLoops = new HashSet<ForLoop>(); - super.visitClassContext(classContext); - stack = null; - possibleForLoops = null; + try { + stack = new OpcodeStack(); + possibleForLoops = new HashSet<ForLoop>(); + super.visitClassContext(classContext); + } finally { + stack = null; + possibleForLoops = null; + } } /** This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
