[Fb-contrib-commit] SF.net SVN: fb-contrib: [462] trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect

[<dbr...@us...>]

Revision: 462
Author:   dbrosius
Date:     2006-04-17 08:37:01 -0700 (Mon, 17 Apr 2006)
ViewCVS:  http://svn.sourceforge.net/fb-contrib/?rev=462&view=rev

Log Message:
-----------
oops, fix booboo

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CustomBuiltXML.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CyclomaticComplexity.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DateComparison.java
Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CustomBuiltXML.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CustomBuiltXML.java	2006-04-17 15:29:54 UTC (rev 461)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CustomBuiltXML.java	2006-04-17 15:37:01 UTC (rev 462)
@@ -29,8 +29,9 @@
 import edu.umd.cs.findbugs.BugReporter;
 import edu.umd.cs.findbugs.BytecodeScanningDetector;
 import edu.umd.cs.findbugs.OpcodeStack;
-import edu.umd.cs.findbugs.StatelessDetector;
+import edu.umd.cs.findbugs.ba.ClassContext;
 
+
 /**
  * looks for methods that build xml based strings by concatenation strings
  * and custom values together. Doing so makes brittle code, that is difficult to 

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CyclomaticComplexity.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CyclomaticComplexity.java	2006-04-17 15:29:54 UTC (rev 461)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CyclomaticComplexity.java	2006-04-17 15:37:01 UTC (rev 462)
@@ -18,7 +18,25 @@
  */
 package com.mebigfatguy.fbcontrib.detect;
 
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.Set;
 
+import org.apache.bcel.classfile.Code;
+import org.apache.bcel.classfile.Method;
+
+import edu.umd.cs.findbugs.BugInstance;
+import edu.umd.cs.findbugs.BugReporter;
+import edu.umd.cs.findbugs.Detector;
+import edu.umd.cs.findbugs.ba.BasicBlock;
+import edu.umd.cs.findbugs.ba.CFG;
+import edu.umd.cs.findbugs.ba.CFGBuilderException;
+import edu.umd.cs.findbugs.ba.ClassContext;
+import edu.umd.cs.findbugs.ba.Edge;
+import edu.umd.cs.findbugs.ba.EdgeTypes;
+import edu.umd.cs.findbugs.visitclass.PreorderVisitor;
+
+
 /**
  * Calculates the McCabe Cyclomatic Complexity measure and reports methods that have an
  * excessive value. This report value can be set with system property 'fb-contrib.cc.limit'.

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DateComparison.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DateComparison.java	2006-04-17 15:29:54 UTC (rev 461)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DateComparison.java	2006-04-17 15:37:01 UTC (rev 462)
@@ -26,13 +26,13 @@
 import edu.umd.cs.findbugs.BugInstance;
 import edu.umd.cs.findbugs.BugReporter;
 import edu.umd.cs.findbugs.BytecodeScanningDetector;
-import edu.umd.cs.findbugs.StatelessDetector;
 
+
 /**
  * Looks for inefficient comparison of Date objects using two comparisons when one would do.
  */
-public class DateComparison extends BytecodeScanningDetector implements StatelessDetector {
-
+public class DateComparison extends BytecodeScanningDetector
+{
 	private static final int SEEN_NOTHING = 0;
 	private static final int SEEN_LOAD1_1 = 1;
 	private static final int SEEN_LOAD1_2 = 2;
@@ -65,17 +65,6 @@
     }
 
 	/**
-	 * clone this detector so that it can be a StatelessDetector
-	 * 
-	 * @return a clone of this object
-	 */
-	@Override
-	public Object clone() throws CloneNotSupportedException {
-		return super.clone();
-	}
-	
-	
-	/**
 	 * overrides the visitor to reset the registers
 	 * 
 	 * @param obj the method of the currently parsed method


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.