[Fb-contrib-commit] SF.net SVN: fb-contrib: [437] trunk/fb-contrib/etc

[<dbr...@us...>]

Revision: 437
Author:   dbrosius
Date:     2006-04-09 20:08:45 -0700 (Sun, 09 Apr 2006)
ViewCVS:  http://svn.sourceforge.net/fb-contrib/?rev=437&view=rev

Log Message:
-----------
adjust documented detector timings based on experimentation

Modified Paths:
--------------
    trunk/fb-contrib/etc/findbugs.xml
    trunk/fb-contrib/etc/messages.xml
Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================
--- trunk/fb-contrib/etc/findbugs.xml	2006-04-10 02:53:59 UTC (rev 436)
+++ trunk/fb-contrib/etc/findbugs.xml	2006-04-10 03:08:45 UTC (rev 437)
@@ -18,7 +18,7 @@
             reports="ISB_INEFFICIENT_STRING_BUFFERING" />
             
     <Detector class="com.mebigfatguy.fbcontrib.detect.SyncCollectionIterators"
-    		speed="fast"
+    		speed="slow"
     		reports="SCI_SYNCHRONIZED_COLLECTION_ITERATORS" />
     		
     <Detector class="com.mebigfatguy.fbcontrib.detect.CyclomaticComplexity"
@@ -26,7 +26,7 @@
     		reports="CC_CYCLOMATIC_COMPLEXITY" />
     		
     <Detector class="com.mebigfatguy.fbcontrib.detect.OverlyConcreteParameter"
-    		speed="fast"
+    		speed="moderate"
     		reports="OCP_OVERLY_CONCRETE_PARAMETER" />
   		
     <Detector class="com.mebigfatguy.fbcontrib.detect.ListIndexedIterating"
@@ -34,7 +34,7 @@
     		reports="LII_LIST_INDEXED_ITERATING" />
     		
     <Detector class="com.mebigfatguy.fbcontrib.detect.UnrelatedCollectionContents"
-    		speed="moderate"
+    		speed="fast"
     		reports="UCC_UNRELATED_COLLECTION_CONTENTS" />
     		
     <Detector class="com.mebigfatguy.fbcontrib.detect.DeclaredRuntimeException"
@@ -42,12 +42,12 @@
     		reports="DRE_DECLARED_RUNTIME_EXCEPTION" />
     		
     <Detector class="com.mebigfatguy.fbcontrib.detect.ClassEnvy"
-    		speed="moderate"
+    		speed="fast"
     		reports="CE_CLASS_ENVY" 
     		disabled="true" />
     		
     <Detector class="com.mebigfatguy.fbcontrib.detect.LiteralStringComparison"
-    		speed="moderate"
+    		speed="fast"
     		reports="LSC_LITERAL_STRING_COMPARISON" />
     		
     <Detector class="com.mebigfatguy.fbcontrib.detect.PartiallyConstructedObjectAccess"
@@ -63,7 +63,7 @@
     		reports="PL_PARALLEL_LISTS" />
     		
     <Detector class="com.mebigfatguy.fbcontrib.detect.FinalParameters"
-    		speed="fast"
+    		speed="slow"
     		reports="FP_FINAL_PARAMETERS" />
 
     <Detector class="com.mebigfatguy.fbcontrib.detect.AbstractClassEmptyMethods"
@@ -107,7 +107,7 @@
     		reports="USBR_UNNECESSARY_STORE_BEFORE_RETURN" />
     		
     <Detector class="com.mebigfatguy.fbcontrib.detect.CopiedOverriddenMethod"
-    		speed="moderate"
+    		speed="fast"
     		reports="COM_COPIED_OVERRIDDEN_METHOD" />
     		
     <Detector class="com.mebigfatguy.fbcontrib.detect.ArrayBasedCollections"
@@ -123,7 +123,7 @@
     		reports="AOM_ABSTRACT_OVERRIDDEN_METHOD" />
     		
     <Detector class="com.mebigfatguy.fbcontrib.detect.CustomBuiltXML"
-    		speed="moderate"
+    		speed="fast"
     		reports="CBX_CUSTOM_BUILT_XML" />
     		
     <Detector class="com.mebigfatguy.fbcontrib.detect.BloatedSynchronizedBlock"
@@ -160,7 +160,7 @@
 			reports="SWCO_SUSPICIOUS_WAIT_ON_CONCURRENT_OBJECT" />
 			
 	<Detector class="com.mebigfatguy.fbcontrib.detect.JDBCVendorReliance"
-			speed="moderate"
+			speed="fast"
 			reports="JVR_JDBC_VENDOR_RELIANCE" />
 			
 	<Detector class="com.mebigfatguy.fbcontrib.detect.PossibleMemoryBloat"
@@ -168,11 +168,11 @@
 			reports="PMB_POSSIBLE_MEMORY_BLOAT" />
 			
 	<Detector class="com.mebigfatguy.fbcontrib.detect.LocalSynchronizedCollection"
-			speed="fast"
+			speed="moderate"
 			reports="LSYC_LOCAL_SYNCHRONIZED_COLLECTION" />
 			
 	<Detector class="com.mebigfatguy.fbcontrib.detect.FieldCouldBeLocal"
-			speed="fast"
+			speed="slow"
 			reports="FCBL_FIELD_COULD_BE_LOCAL" />
 			
 	<Detector class="com.mebigfatguy.fbcontrib.detect.NonOwnedSynchronization"
@@ -180,7 +180,7 @@
 			reports="NOS_NON_OWNED_SYNCHRONIZATION" />
 			
 	<Detector class="com.mebigfatguy.fbcontrib.detect.NonRecycleableTaglibs"
-			speed="moderate"
+			speed="fast"
 			reports="NRTL_NON_RECYCLEABLE_TAG_LIBS" />
 			
    	<!-- BugPattern -->

Modified: trunk/fb-contrib/etc/messages.xml
===================================================================
--- trunk/fb-contrib/etc/messages.xml	2006-04-10 02:53:59 UTC (rev 436)
+++ trunk/fb-contrib/etc/messages.xml	2006-04-10 03:08:45 UTC (rev 437)
@@ -37,7 +37,7 @@
 			<p> As the collection in question was built thru Collections.synchronizedXXX, an assumption
 			is made that this collection must be multithreaded safe. However, iterator access is used, 
 			which is explicitly unsafe. When iterators are to be used, synchronization should be done manually.</p>
-			<p>It is a fast detector</p>
+			<p>It is a slow detector</p>
 			]]>
 	    </Details>
 	</Detector>
@@ -58,7 +58,7 @@
 			<p> Looks for parameters that are defined by classes, but only use methods defined by an
 			implemented interface or super class. Relying on concrete classes in public signatures causes cohesion,
 			and makes low impact changes more difficult.</p>
-			<p>It is a fast detector</p>
+			<p>It is a moderately fast detector</p>
 			]]>
 	    </Details>
 	</Detector>
@@ -83,7 +83,7 @@
 			determine type. A better design usually can be had by creating a seperate class,
 			which defines the different types required, and add an instance of that class to the
 			collection, or array.</p>
-			<p>It is a moderately fast detector</p>
+			<p>It is a fast detector</p>
 			]]>
 		</Details>
 	</Detector>
@@ -108,7 +108,7 @@
 			methods. When this is the case, it is often better to implement this method in that other class,
 			by refactoring the class to accept parameters it needs from the source class.
 			The reporting percentage can be set with system property 'fb-contrib.ce.percent'.</p>
-			<p>It is a moderately fast detector</p>
+			<p>It is a fast detector</p>
 			]]>
 		</Details>
 	</Detector>
@@ -119,7 +119,7 @@
 			<p> Looks for methods that compare strings against literal strings, where the literal string
 			is passed as the parameter. If the .equals or .compareTo is called on the literal itself, passing
 			the variable as the parameter, you avoid the possibility of a NullPointerException.</p>
-			<p>It is a moderately fast detector</p>
+			<p>It is a fast detector</p>
 			]]>
 		</Details>
 	</Detector>
@@ -320,7 +320,7 @@
 			<![CDATA[
 			<p>Looks for methods that are direct copies of the implementation in the super class</p>
 			</p>
-			<p>It is a moderately fast detector</p>			
+			<p>It is a fast detector</p>			
 			]]>
 		</Details>
 	</Detector>
@@ -366,7 +366,7 @@
 			and custom values together. Doing so makes brittle code, that is difficult to 
 			modify, validate and understand. It is cleaner to create external xml files that are
 			transformed at runtime, using parameters set through Transformer.setParameter.
-			<p>It is a moderately fast detector</p>
+			<p>It is a fast detector</p>
 			]]>
 		</Details>
 	</Detector>
@@ -377,7 +377,7 @@
 			<p>Looks for methods that are implemented using synchronized blocks, but are overly
 			synchronized because the beginning of the block only accesses local variables,
 			and not member variables, or this.</p>
-			<p>It is a fast detector</p>
+			<p>It is a slow detector</p>
 			]]>
 		</Details>
 	</Detector>
@@ -466,7 +466,7 @@
 			<![CDATA[
 			<p>Looks for uses of jdbc vendor specific classes and methods making the database 
 			access code non portable.</p>
-			<p>It is a moderately fast detector</p>
+			<p>It is a fast detector</p>
 			]]>
 		</Details>
 	</Detector>
@@ -489,7 +489,7 @@
 			variables, and never stored in fields or returned from methods. As local variables 
 			are by definition thread safe, using synchronized collections in this context 
 			makes no sense.</p>
-			<p>It is a fast detector</p>
+			<p>It is a moderately fast detector</p>
 			]]>
 		</Details>
 	</Detector>
@@ -500,7 +500,7 @@
 			<p>looks for classes that define fields that are used in a locals only fashion, 
 			specifically private fields that are accessed first in each method with a 
 			store vs. a load.</p>
-			<p>It is a fast detector</p>
+			<p>It is a slow detector</p>
 			]]>
 		</Details>
 	</Detector>
@@ -523,7 +523,7 @@
 			<![CDATA[
 			<p>looks for tag libraries that are not recycleable because backing members 
 			of taglib attributes are set in areas besides the setter method for the attribute.</p>
-			<p>It is a moderately fast detector</p>
+			<p>It is a fast detector</p>
 			]]>
 		</Details>
 	</Detector>


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.