[Fb-contrib-commit] fb-contrib/src/com/mebigfatguy/fbcontrib/detect FieldCouldBeLocal.java,1.5,1.6

[Dave B. <dbr...@us...>]

Update of /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv27594/src/com/mebigfatguy/fbcontrib/detect

Modified Files:
	FieldCouldBeLocal.java 
Log Message:
don't look at protected members

Index: FieldCouldBeLocal.java
===================================================================
RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FieldCouldBeLocal.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -d -r1.5 -r1.6
--- FieldCouldBeLocal.java	28 Mar 2006 02:38:53 -0000	1.5
+++ FieldCouldBeLocal.java	28 Mar 2006 04:42:07 -0000	1.6
@@ -49,8 +49,8 @@
 import edu.umd.cs.findbugs.ba.BasicBlock.InstructionIterator;
 
 /**
- * finds fields that are used in a locals only fashion, specifically private fields or protected fields
- * in final classes that are accessed first in each method with a store vs. a load.
+ * finds fields that are used in a locals only fashion, specifically private fields
+ * that are accessed first in each method with a store vs. a load.
  */
 public class FieldCouldBeLocal extends BytecodeScanningDetector implements StatelessDetector {
 
@@ -95,7 +95,7 @@
 		boolean clsIsFinal = cls.isFinal();
 		Field[] fields = cls.getFields();
 		for (Field f : fields) {
-			if ((!f.isStatic() && f.getName().indexOf("$") < 0) && (f.isPrivate() || (clsIsFinal && f.isProtected()))) {
+			if ((!f.isStatic() && f.getName().indexOf("$") < 0) && f.isPrivate()) {
 				FieldAnnotation fa = new FieldAnnotation(cls.getClassName(), f.getName(), f.getSignature(), false);
 				localizableFields.put(f.getName(), new FieldInfo(fa));
 			}