[Fb-contrib-commit] fb-contrib/etc findbugs.xml,1.69,1.70 messages.xml,1.63,1.64

[Dave B. <dbr...@us...>]

Update of /cvsroot/fb-contrib/fb-contrib/etc
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv16920/etc

Modified Files:
	findbugs.xml messages.xml 
Log Message:
Initial checkin - new FCBL detector

Index: messages.xml
===================================================================
RCS file: /cvsroot/fb-contrib/fb-contrib/etc/messages.xml,v
retrieving revision 1.63
retrieving revision 1.64
diff -u -d -r1.63 -r1.64
--- messages.xml	14 Mar 2006 04:36:29 -0000	1.63
+++ messages.xml	27 Mar 2006 05:56:54 -0000	1.64
@@ -494,6 +494,17 @@
 		</Details>
 	</Detector>
 
+	<Detector class="com.mebigfatguy.fbcontrib.detect.FieldCouldBeLocal">
+		<Details>
+			<![CDATA[
+			<p>looks for classes that define fields that are used in a locals only fashion, 
+			specifically private fields or protected fields in final classes that are accessed 
+			first in each method with a store vs. a load.</p>
+			<p>It is a fast detector</p>
+			]]>
+		</Details>
+	</Detector>
+
 	<!-- BugPattern -->
 	                
 	<BugPattern type="ISB_INEFFICIENT_STRING_BUFFERING">
@@ -1006,6 +1017,19 @@
 		</Details>	
 	</BugPattern>
 	
+	<BugPattern type="FCBL_FIELD_COULD_BE_LOCAL">
+		<ShortDescription>class defines fields that are used only as locals</ShortDescription>
+		<LongDescription>class {0} defines fields that are used only as locals</LongDescription>
+		<Details>
+			<![CDATA[
+			<p>This class defines fields that are used in a locals only fashion, 
+			specifically private fields or protected fields in final classes that are accessed 
+			first in each method with a store vs. a load. This field could be replaced by one
+			or more local variables.</p>
+			]]>
+		</Details>	
+	</BugPattern>
+	
 	<!-- BugCode -->
 	
 	<BugCode abbrev="ISB">Inefficient String Buffering</BugCode>
@@ -1047,4 +1071,5 @@
 	<BugCode abbrev="JVR">JDBC Vendor Reliance</BugCode>
 	<BugCode abbrev="PMB">Possible Memory Bloat</BugCode>
 	<BugCode abbrev="LSYC">Local Synchronized Collection</BugCode>
+	<BugCode abbrev="FCBL">Field Could Be Local</BugCode>
 </MessageCollection>
\ No newline at end of file

Index: findbugs.xml
===================================================================
RCS file: /cvsroot/fb-contrib/fb-contrib/etc/findbugs.xml,v
retrieving revision 1.69
retrieving revision 1.70
diff -u -d -r1.69 -r1.70
--- findbugs.xml	11 Mar 2006 05:01:35 -0000	1.69
+++ findbugs.xml	27 Mar 2006 05:56:54 -0000	1.70
@@ -171,6 +171,10 @@
 			speed="fast"
 			reports="LSYC_LOCAL_SYNCHRONIZED_COLLECTION" />
 			
+	<Detector class="com.mebigfatguy.fbcontrib.detect.FieldCouldBeLocal"
+			speed="fast"
+			reports="FCBL_FIELD_COULD_BE_LOCAL" />
+			
    	<!-- BugPattern -->
 	
 	<BugPattern abbrev="ISB" type="ISB_INEFFICIENT_STRING_BUFFERING" category="PERFORMANCE" />
@@ -212,4 +216,5 @@
 	<BugPattern abbrev="JVR" type="JVR_JDBC_VENDOR_RELIANCE" category="CORRECTNESS" experimental="true" />
 	<BugPattern abbrev="PMB" type="PMB_POSSIBLE_MEMORY_BLOAT" category="CORRECTNESS" experimental="true" />
 	<BugPattern abbrev="LSYC" type="LSYC_LOCAL_SYNCHRONIZED_COLLECTION" category="CORRECTNESS" experimental="true" />
+	<BugPattern abbrev="FCBL" type="FCBL_FIELD_COULD_BE_LOCAL" category="CORRECTNESS" experimental="true" />
 </FindbugsPlugin>
\ No newline at end of file