[Fb-contrib-commit] fb-contrib/etc findbugs.xml,1.66,1.67 messages.xml,1.56,1.57
Brought to you by:
dbrosius
Menu
▾
▴
[Fb-contrib-commit] fb-contrib/etc findbugs.xml,1.66,1.67 messages.xml,1.56,1.57
|
From: Dave B. <dbr...@us...> - 2006-03-06 04:16:40
|
Update of /cvsroot/fb-contrib/fb-contrib/etc In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv22371/etc Modified Files: findbugs.xml messages.xml Log Message: initial checkin, new JVR detector Index: messages.xml =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/etc/messages.xml,v retrieving revision 1.56 retrieving revision 1.57 diff -u -d -r1.56 -r1.57 --- messages.xml 5 Mar 2006 04:37:15 -0000 1.56 +++ messages.xml 6 Mar 2006 04:16:37 -0000 1.57 @@ -365,7 +365,7 @@ and custom values together. Doing so makes brittle code, that is difficult to modify, validate and understand. It is cleaner to create external xml files that are transformed at runtime, using parameters set through Transformer.setParameter. - <p>It is a moderately fast Detector</p> + <p>It is a moderately fast detector</p> ]]> </Details> </Detector> @@ -376,7 +376,7 @@ <p>Looks for methods that are implemented using synchronized blocks, but are overly synchronized because the beginning of the block only accesses local variables, and not member variables, or this.</p> - <p>It is a fast Detector</p> + <p>It is a fast detector</p> ]]> </Details> </Detector> @@ -388,7 +388,7 @@ using a constant integer for the index. This is often a typo intented to be a loop variable, but if specific indices mean certain things, perhaps a first class object would be a better choice for a container.</p> - <p>It is a fast Detector</p> + <p>It is a fast detector</p> ]]> </Details> </Detector> @@ -401,7 +401,7 @@ XXX.class, and doing so protects the integrity of this code from such transformations as obfuscation. Use of Class.forName should only be used when the class in question isn't already statically bound to this context.</p> - <p>It is a fast Detector</p> + <p>It is a fast detector</p> ]]> </Details> </Detector> @@ -412,7 +412,7 @@ <p>Looks for methods that use an array of length one to pass a variable to achieve call by pointer ala C++. It is better to define a proper return class type that holds all the relevant information retrieved from the called method.</p> - <p>It is a fast Detector</p> + <p>It is a fast detector</p> ]]> </Details> </Detector> @@ -425,7 +425,7 @@ interface to appear sluggish and non-responsive to the user. It is better to use a separate thread to do the time consuming work so that the user has a better experience.</p> - <p>It is a fast Detector</p> + <p>It is a fast detector</p> ]]> </Details> </Detector> @@ -436,7 +436,7 @@ <p>Looks for methods that call a method to retrieve a reference to an object, to use to load a constant. It is simpler and more performant to access the static variable directly from the class itself.</p> - <p>It is a fast Detector</p> + <p>It is a fast detector</p> ]]> </Details> </Detector> @@ -444,8 +444,8 @@ <Detector class="com.mebigfatguy.fbcontrib.detect.DateComparison"> <Details> <![CDATA[ - <p> Looks for inefficient comparison of Date objects using two comparisons when one would do. - It is a fast detector. + <p> Looks for inefficient comparison of Date objects using two comparisons when one would do.</p> + <p>It is a fast detector</p> ]]> </Details> </Detector> @@ -454,7 +454,18 @@ <Details> <![CDATA[ <p>Looks for calls to the wait method on mutexes defined in the java.util.concurrent - package where it is likely that await was intended. + package where it is likely that await was intended.</p> + <p>It is a fast detector</p> + ]]> + </Details> + </Detector> + + <Detector class="com.mebigfatguy.fbcontrib.detect.JDBCVendorReliance"> + <Details> + <![CDATA[ + <p>Looks for uses of jdbc vendor specific classes and methods making the database + access code non portable.</p> + <p>It is a moderately fast detector</p> ]]> </Details> </Detector> @@ -935,6 +946,17 @@ </Details> </BugPattern> + <BugPattern type="JVR_JDBC_VENDOR_RELIANCE"> + <ShortDescription>method uses jdbc vendor specific classes and methods</ShortDescription> + <LongDescription>method {1} uses jdbc vendor specific classes and methods</LongDescription> + <Details> + <![CDATA[ + <p>This method uses jdbc vendor specific classes and method to perform database work. + This makes the code specific to this vendor, and unable to run on other databases.</p> + ]]> + </Details> + </BugPattern> + <!-- BugCode --> <BugCode abbrev="ISB">Inefficient String Buffering</BugCode> @@ -973,4 +995,5 @@ <BugCode abbrev="NIR">Needless Instance Retrieval</BugCode> <BugCode abbrev="DDC">Double Date comparison</BugCode> <BugCode abbrev="SWCO">Suspicious Wait on Concurrent Object</BugCode> + <BugCode abbrev="JVR">JDBC Vendor Reliance</BugCode> </MessageCollection> \ No newline at end of file Index: findbugs.xml =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/etc/findbugs.xml,v retrieving revision 1.66 retrieving revision 1.67 diff -u -d -r1.66 -r1.67 --- findbugs.xml 5 Mar 2006 04:37:13 -0000 1.66 +++ findbugs.xml 6 Mar 2006 04:16:36 -0000 1.67 @@ -159,6 +159,10 @@ speed="fast" reports="SWCO_SUSPICIOUS_WAIT_ON_CONCURRENT_OBJECT" /> + <Detector class="com.mebigfatguy.fbcontrib.detect.JDBCVendorReliance" + speed="moderate" + reports="JVR_JDBC_VENDOR_RELIANCE" /> + <!-- BugPattern --> @@ -198,4 +202,5 @@ <BugPattern abbrev="NIR" type="NIR_NEEDLESS_INSTANCE_RETRIEVAL" category="PERFORMANCE" /> <BugPattern abbrev="DDC" type="DDC_DOUBLE_DATE_COMPARISON" category="PERFORMANCE" experimental="true" /> <BugPattern abbrev="SWCO" type="SWCO_SUSPICIOUS_WAIT_ON_CONCURRENT_OBJECT" category="CORRECTNESS" experimental="true" /> + <BugPattern abbrev="JVR" type="JVR_JDBC_VENDOR_RELIANCE" category="CORRECTNESS" experimental="true" /> </FindbugsPlugin> \ No newline at end of file |
