[Fb-contrib-commit] fb-contrib/etc findbugs.xml,1.65,1.66 messages.xml,1.55,1.56

[Dave B. <dbr...@us...>]

Update of /cvsroot/fb-contrib/fb-contrib/etc
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv7897/etc

Modified Files:
	findbugs.xml messages.xml 
Log Message:
initial checkin - new SWCO detector

Index: messages.xml
===================================================================
RCS file: /cvsroot/fb-contrib/fb-contrib/etc/messages.xml,v
retrieving revision 1.55
retrieving revision 1.56
diff -u -d -r1.55 -r1.56
--- messages.xml	28 Feb 2006 03:17:23 -0000	1.55
+++ messages.xml	5 Mar 2006 04:37:15 -0000	1.56
@@ -449,6 +449,15 @@
 			]]>
 		</Details>
 	</Detector>
+	
+	<Detector class="com.mebigfatguy.fbcontrib.detect.SuspiciousWaitOnConcurrentObject">
+		<Details>
+			<![CDATA[
+			<p>Looks for calls to the wait method on mutexes defined in the java.util.concurrent 
+			package where it is likely that await was intended.
+			]]>
+		</Details>
+	</Detector>
 
 	<!-- BugPattern -->
 	                
@@ -914,6 +923,18 @@
 		</Details>
 	</BugPattern>
 
+	<BugPattern type="SWCO_SUSPICIOUS_WAIT_ON_CONCURRENT_OBJECT">
+		<ShortDescription>method calls wait when await was probably intended</ShortDescription>
+		<LongDescription>method {1} calls wait when await was probably intended</LongDescription>
+		<Details>
+			<![CDATA[
+			<p>This method calls wait() on a on mutex defined in the java.util.concurrent package.
+			These classes, define await, instead of wait, and it is most likely that await
+			was intended.</p>
+			]]>
+		</Details>	
+	</BugPattern>
+	
 	<!-- BugCode -->
 	
 	<BugCode abbrev="ISB">Inefficient String Buffering</BugCode>
@@ -951,4 +972,5 @@
 	<BugCode abbrev="SG">Sluggish Gui</BugCode>
 	<BugCode abbrev="NIR">Needless Instance Retrieval</BugCode>
 	<BugCode abbrev="DDC">Double Date comparison</BugCode>
+	<BugCode abbrev="SWCO">Suspicious Wait on Concurrent Object</BugCode>
 </MessageCollection>
\ No newline at end of file

Index: findbugs.xml
===================================================================
RCS file: /cvsroot/fb-contrib/fb-contrib/etc/findbugs.xml,v
retrieving revision 1.65
retrieving revision 1.66
diff -u -d -r1.65 -r1.66
--- findbugs.xml	28 Feb 2006 03:17:23 -0000	1.65
+++ findbugs.xml	5 Mar 2006 04:37:13 -0000	1.66
@@ -154,6 +154,11 @@
     <Detector class="com.mebigfatguy.fbcontrib.detect.DateComparison" 
     		speed="fast"
 		    reports="DDC_DOUBLE_DATE_COMPARISON" />
+		    
+	<Detector class="com.mebigfatguy.fbcontrib.detect.SuspiciousWaitOnConcurrentObject"
+			speed="fast"
+			reports="SWCO_SUSPICIOUS_WAIT_ON_CONCURRENT_OBJECT" />
+			
 
    	<!-- BugPattern -->
 	
@@ -192,4 +197,5 @@
 	<BugPattern abbrev="SG" type="SG_SLUGGISH_GUI" category="PERFORMANCE" />
 	<BugPattern abbrev="NIR" type="NIR_NEEDLESS_INSTANCE_RETRIEVAL" category="PERFORMANCE" />
 	<BugPattern abbrev="DDC" type="DDC_DOUBLE_DATE_COMPARISON" category="PERFORMANCE" experimental="true" />
+	<BugPattern abbrev="SWCO" type="SWCO_SUSPICIOUS_WAIT_ON_CONCURRENT_OBJECT" category="CORRECTNESS" experimental="true" />
 </FindbugsPlugin>
\ No newline at end of file