[Fb-contrib-commit] fb-contrib/src/com/mebigfatguy/fbcontrib/detect DateComparison.java,1.1,1.2
Brought to you by:
dbrosius
|
From: Dave B. <dbr...@us...> - 2006-03-02 02:05:55
|
Update of /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv11884/src/com/mebigfatguy/fbcontrib/detect Modified Files: DateComparison.java Log Message: add Timestamp Index: DateComparison.java =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DateComparison.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -d -r1.1 -r1.2 --- DateComparison.java 28 Feb 2006 03:17:23 -0000 1.1 +++ DateComparison.java 2 Mar 2006 02:05:46 -0000 1.2 @@ -18,6 +18,9 @@ */ package com.mebigfatguy.fbcontrib.detect; +import java.util.HashSet; +import java.util.Set; + import org.apache.bcel.classfile.Method; import edu.umd.cs.findbugs.BugInstance; @@ -40,6 +43,13 @@ private static final int SEEN_LOAD2_2 = 6; private static final int SEEN_CMP_2 = 7; + private static final Set<String> dateClasses = new HashSet<String>(); + static { + dateClasses.add("java.util.Date"); + dateClasses.add("java.sql.Date"); + dateClasses.add("java.sql.Timestamp"); + } + private BugReporter bugReporter; private int state; private int register1_1; @@ -114,7 +124,7 @@ case SEEN_LOAD1_2: if (seen == INVOKEVIRTUAL) { String cls = getDottedClassConstantOperand(); - if ((cls.equals("java.util.Date")) || (cls.equals("java.sql.Date"))) { + if (dateClasses.contains(cls)) { String methodName = getNameConstantOperand(); if (methodName.equals( "equals" ) || methodName.equals( "after" ) |