[Fb-contrib-commit] fb-contrib/src/com/mebigfatguy/fbcontrib/detect DubiousListCollection.java,1.12,
Brought to you by:
dbrosius
From: Dave B. <dbr...@us...> - 2006-02-18 23:31:36
|
Update of /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv15145/src/com/mebigfatguy/fbcontrib/detect Modified Files: DubiousListCollection.java Log Message: fix javadoc Index: DubiousListCollection.java =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DubiousListCollection.java,v retrieving revision 1.12 retrieving revision 1.13 diff -u -d -r1.12 -r1.13 --- DubiousListCollection.java 6 Feb 2006 01:36:23 -0000 1.12 +++ DubiousListCollection.java 18 Feb 2006 23:31:30 -0000 1.13 @@ -37,9 +37,10 @@ import edu.umd.cs.findbugs.ba.ClassContext; /** - * looks for constructors of non final classes that make method calls to non final methods. - * As these methods could be overridden, the overridden method will be accessing an object that - * is only partially constructed, perhaps causing problems. + * looks for fields that are implementations of java.util.List, but that are used in a set-like fashion. + * Since lookup type operations are performed using a linear search for Lists, the performance for large + * Lists will be poor. Consideration should be made as to whether these fields should be sets. In the + * case that order is important, consider using LinkedHashSet. */ public class DubiousListCollection extends BytecodeScanningDetector { |