[Fb-contrib-commit] fb-contrib/etc findbugs.xml,1.56,1.57 messages.xml,1.48,1.49

[Dave B. <dbr...@us...>]

Update of /cvsroot/fb-contrib/fb-contrib/etc
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv9694/etc

Modified Files:
	findbugs.xml messages.xml 
Log Message:
initial checkin new AWCBR detector - semi working
(requires findbugs.jar 0.95)

Index: messages.xml
===================================================================
RCS file: /cvsroot/fb-contrib/fb-contrib/etc/messages.xml,v
retrieving revision 1.48
retrieving revision 1.49
diff -u -d -r1.48 -r1.49
--- messages.xml	21 Jan 2006 07:00:52 -0000	1.48
+++ messages.xml	23 Jan 2006 07:53:06 -0000	1.49
@@ -407,6 +407,17 @@
 		</Details>
 	</Detector>
 	
+	<Detector class="com.mebigfatguy.fbcontrib.detect.ArrayWrappedCallByReference">
+		<Details>
+			<![CDATA[
+			<p>Looks for methods that use an array of length one to pass a variable to achieve call
+			by pointer ala C++. It is better to define a proper return class type that holds all
+			the relevant information retrieved from the called method.</p>
+			<p>It is a fast Detector</p>
+			]]>
+		</Details>
+	</Detector>
+
 	<!-- BugPattern -->
 	                
 	<BugPattern type="ISB_INEFFICIENT_STRING_BUFFERING">
@@ -799,6 +810,16 @@
 		</Details>	
 	</BugPattern>
 	
+	<BugPattern type="AWCBR_ARRAY_WRAPPED_CALL_BY_REFERENCE">
+		<ShortDescription>method uses 1 element array to similate call by reference</ShortDescription>
+		<LongDescription>method {1} uses 1 element array to similate call by reference</LongDescription>
+		<Details>
+			<![CDATA[
+			<p></p>
+			]]>
+		</Details>	
+	</BugPattern>
+
 	<!-- BugCode -->
 	
 	<BugCode abbrev="ISB">Inefficient String Buffering</BugCode>
@@ -832,4 +853,5 @@
 	<BugCode abbrev="BSB">Bloated Synchronized Block</BugCode>
 	<BugCode abbrev="CLI">Constant List Index</BugCode>
 	<BugCode abbrev="SCR">Sloppy Class Reflection</BugCode>
+	<BugCode abbrev="AWCBR">Array Wrapped Call By Reference</BugCode>
 </MessageCollection>
\ No newline at end of file

Index: findbugs.xml
===================================================================
RCS file: /cvsroot/fb-contrib/fb-contrib/etc/findbugs.xml,v
retrieving revision 1.56
retrieving revision 1.57
diff -u -d -r1.56 -r1.57
--- findbugs.xml	21 Jan 2006 07:00:52 -0000	1.56
+++ findbugs.xml	23 Jan 2006 07:53:06 -0000	1.57
@@ -138,6 +138,10 @@
     		speed="fast"
     		reports="SCR_SLOPPY_CLASS_REFLECTION" />
 
+    <Detector class="com.mebigfatguy.fbcontrib.detect.ArrayWrappedCallByReference"
+    		speed="fast"
+    		reports="AWCBR_ARRAY_WRAPPED_CALL_BY_REFERENCE" />
+
    	<!-- BugPattern -->
 	
 	<BugPattern abbrev="ISB" type="ISB_INEFFICIENT_STRING_BUFFERING" category="PERFORMANCE" />
@@ -171,4 +175,5 @@
 	<BugPattern abbrev="BSB" type="BSB_BLOATED_SYNCHRONIZED_BLOCK" category="PERFORMANCE" experimental="true" />
 	<BugPattern abbrev="CLI" type="CLI_CONSTANT_LIST_INDEX" category="CORRECTNESS" experimental="true" />
 	<BugPattern abbrev="SCR" type="SCR_SLOPPY_CLASS_REFLECTION" category="STYLE" experimental="true" />
+	<BugPattern abbrev="AWCBR" type="AWCBR_ARRAY_WRAPPED_CALL_BY_REFERENCE" category="STYLE" experimental="true" />
 </FindbugsPlugin>
\ No newline at end of file