[Fb-contrib-commit] fb-contrib/src/com/mebigfatguy/fbcontrib/detect ConstantListIndex.java,1.4,1.5

[Dave B. <dbr...@us...>]

Update of /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv11611/src/com/mebigfatguy/fbcontrib/detect

Modified Files:
	ConstantListIndex.java 
Log Message:
remove pc's that have been reported, ignore caload and baloads

Index: ConstantListIndex.java
===================================================================
RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConstantListIndex.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -d -r1.4 -r1.5
--- ConstantListIndex.java	17 Jan 2006 03:48:20 -0000	1.4
+++ ConstantListIndex.java	18 Jan 2006 02:10:13 -0000	1.5
@@ -99,8 +99,8 @@
 					case FALOAD:
 					case DALOAD:
 					case AALOAD:
-					case BALOAD:
-					case CALOAD:
+					//case BALOAD: byte and char indexing seems prevalent, and 
+					//case CALOAD: usually harmless so ignore
 					case SALOAD:
 						if (state == SEEN_CONSTANT_0)
 							iConst0Looped.add(new Integer(getPC()));
@@ -142,6 +142,7 @@
 											.addClass(this)
 											.addMethod(this)
 											.addSourceLine(this, bugPC));
+					it.remove();
 				}
 			}
 		}