[Fb-contrib-commit] fb-contrib/etc findbugs.xml,1.49,1.50 messages.xml,1.43,1.44
Brought to you by:
dbrosius
From: Dave B. <dbr...@us...> - 2006-01-02 03:41:16
|
Update of /cvsroot/fb-contrib/fb-contrib/etc In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv26877/etc Modified Files: findbugs.xml messages.xml Log Message: finding BSB at the end of a synchronized block seems very problematic. For now just look for beginning BSB Index: messages.xml =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/etc/messages.xml,v retrieving revision 1.43 retrieving revision 1.44 diff -u -d -r1.43 -r1.44 --- messages.xml 2 Jan 2006 02:48:55 -0000 1.43 +++ messages.xml 2 Jan 2006 03:41:07 -0000 1.44 @@ -375,7 +375,7 @@ <Details> <![CDATA[ <p>Looks for methods that are implemented using synchronized blocks, but are overly - synchronized because the beginning or end of the block only accesses local variables, + synchronized because the beginning of the block only accesses local variables, and not member variables, or this.</p> <p>It is a fast Detector</p> ]]> @@ -739,9 +739,9 @@ <LongDescription>method {1} overly synchronizes a block of code</LongDescription> <Details> <![CDATA[ - <p>This methods implements a synchronized blocks, but the code found at the beginning - or endare overly only accesses local variables, and not member variables, or this. - To be better performance move the code that access local variables only, outside the + <p>This methods implements a synchronized block, but the code found at the beginning + of this block only accesses local variables, and not member variables, or this. + To be better performance move the code that access local variables only, above the synchronized block, and leave the synchronized block only for field accesses, or access to this object.</p> ]]> Index: findbugs.xml =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/etc/findbugs.xml,v retrieving revision 1.49 retrieving revision 1.50 diff -u -d -r1.49 -r1.50 --- findbugs.xml 2 Jan 2006 02:48:55 -0000 1.49 +++ findbugs.xml 2 Jan 2006 03:41:07 -0000 1.50 @@ -128,8 +128,7 @@ <Detector class="com.mebigfatguy.fbcontrib.detect.BloatedSynchronizedBlock" speed="fast" - reports="BSB_BLOATED_SYNCHRONIZED_BLOCK" - hidden="true" /> + reports="BSB_BLOATED_SYNCHRONIZED_BLOCK" /> <!-- BugPattern --> |