[Fb-contrib-commit] fb-contrib/etc findbugs.xml,1.48,1.49 messages.xml,1.42,1.43
Brought to you by:
dbrosius
|
From: Dave B. <dbr...@us...> - 2006-01-02 02:49:07
|
Update of /cvsroot/fb-contrib/fb-contrib/etc In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv19962/etc Modified Files: findbugs.xml messages.xml Log Message: initial checkin - BSB -- not working yet, so hidden Index: messages.xml =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/etc/messages.xml,v retrieving revision 1.42 retrieving revision 1.43 diff -u -d -r1.42 -r1.43 --- messages.xml 31 Dec 2005 03:18:56 -0000 1.42 +++ messages.xml 2 Jan 2006 02:48:55 -0000 1.43 @@ -371,6 +371,17 @@ </Details> </Detector> + <Detector class="com.mebigfatguy.fbcontrib.detect.BloatedSynchronizedBlock"> + <Details> + <![CDATA[ + <p>Looks for methods that are implemented using synchronized blocks, but are overly + synchronized because the beginning or end of the block only accesses local variables, + and not member variables, or this.</p> + <p>It is a fast Detector</p> + ]]> + </Details> + </Detector> + <!-- BugPattern --> <BugPattern type="ISB_INEFFICIENT_STRING_BUFFERING"> @@ -723,6 +734,21 @@ </Details> </BugPattern> + <BugPattern type="BSB_BLOATED_SYNCHRONIZED_BLOCK"> + <ShortDescription>method overly synchronizes a block of code</ShortDescription> + <LongDescription>method {1} overly synchronizes a block of code</LongDescription> + <Details> + <![CDATA[ + <p>This methods implements a synchronized blocks, but the code found at the beginning + or endare overly only accesses local variables, and not member variables, or this. + To be better performance move the code that access local variables only, outside the + synchronized block, and leave the synchronized block only for field accesses, or access + to this object.</p> + ]]> + </Details> + + </BugPattern> + <!-- BugCode --> <BugCode abbrev="ISB">Inefficient String Buffering</BugCode> @@ -753,4 +779,5 @@ <BugCode abbrev="ODN">Orphaned DOM Node</BugCode> <BugCode abbrev="AOM">Abstract Overridden Method</BugCode> <BugCode abbrev="CBX">Custom Built XML</BugCode> + <BugCode abbrev="BSB">Bloated Synchronized Block</BugCode> </MessageCollection> \ No newline at end of file Index: findbugs.xml =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/etc/findbugs.xml,v retrieving revision 1.48 retrieving revision 1.49 diff -u -d -r1.48 -r1.49 --- findbugs.xml 31 Dec 2005 03:18:56 -0000 1.48 +++ findbugs.xml 2 Jan 2006 02:48:55 -0000 1.49 @@ -125,6 +125,11 @@ <Detector class="com.mebigfatguy.fbcontrib.detect.CustomBuiltXML" speed="moderate" reports="CBX_CUSTOM_BUILT_XML" /> + + <Detector class="com.mebigfatguy.fbcontrib.detect.BloatedSynchronizedBlock" + speed="fast" + reports="BSB_BLOATED_SYNCHRONIZED_BLOCK" + hidden="true" /> <!-- BugPattern --> @@ -152,8 +157,9 @@ <BugPattern abbrev="NAB" type="NAB_NEEDLESS_AUTOBOXING" category="PERFORMANCE" /> <BugPattern abbrev="USBR" type="USBR_UNNECESSARY_STORE_BEFORE_RETURN" category="STYLE" /> <BugPattern abbrev="COM" type="COM_COPIED_OVERRIDDEN_METHOD" category="STYLE" /> - <BugPattern abbrev="ABC" type="ABC_ARRAY_BASED_COLLECTIONS" category="CORRECTNESS" experimental="true" /> - <BugPattern abbrev="ODN" type="ODN_ORPHANED_DOM_NODE" category="CORRECTNESS" experimental="true" /> - <BugPattern abbrev="AOM" type="AOM_ABSTRACT_OVERRIDDEN_METHOD" category="CORRECTNESS" experimental="true" /> - <BugPattern abbrev="CBX" type="CBX_CUSTOM_BUILT_XML" category="STYLE" experimental="true" /> + <BugPattern abbrev="ABC" type="ABC_ARRAY_BASED_COLLECTIONS" category="CORRECTNESS" /> + <BugPattern abbrev="ODN" type="ODN_ORPHANED_DOM_NODE" category="CORRECTNESS" /> + <BugPattern abbrev="AOM" type="AOM_ABSTRACT_OVERRIDDEN_METHOD" category="CORRECTNESS" /> + <BugPattern abbrev="CBX" type="CBX_CUSTOM_BUILT_XML" category="STYLE" /> + <BugPattern abbrev="BSB" type="BSB_BLOATED_SYNCHRONIZED_BLOCK" category="PERFORMANCE" experimental="true" /> </FindbugsPlugin> \ No newline at end of file |