[Fb-contrib-commit] fb-contrib/etc findbugs.xml,1.45,1.46 messages.xml,1.39,1.40

[Dave B. <dbr...@us...>]

Update of /cvsroot/fb-contrib/fb-contrib/etc
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv13344/etc

Modified Files:
	findbugs.xml messages.xml 
Log Message:
intial checkin, new AOM detector

Index: messages.xml
===================================================================
RCS file: /cvsroot/fb-contrib/fb-contrib/etc/messages.xml,v
retrieving revision 1.39
retrieving revision 1.40
diff -u -d -r1.39 -r1.40
--- messages.xml	23 Dec 2005 05:23:27 -0000	1.39
+++ messages.xml	28 Dec 2005 03:40:18 -0000	1.40
@@ -348,6 +348,16 @@
 		</Details>
 	</Detector>
 	
+	<Detector class="com.mebigfatguy.fbcontrib.detect.AbstractOverriddenMethod">
+		<Details>
+			<![CDATA[
+			<p>Looks for methods that are declared as abstract that override concrete methods in a
+			super class. Doing this casts away the implementation of the super class, and breaks
+			the contract as set forth by the parent class.</p>
+			]]>
+		</Details>
+	</Detector>
+	
 	<!-- BugPattern -->
 	                
 	<BugPattern type="ISB_INEFFICIENT_STRING_BUFFERING">
@@ -674,6 +684,18 @@
 		</Details>	
 	</BugPattern>
 	
+	<BugPattern type="AOM_ABSTRACT_OVERRIDDEN_METHOD">
+		<ShortDescription>abstract method overrides a concrete implementation</ShortDescription>
+		<LongDescription>abstract method {1} overrides a concrete implementation</LongDescription>
+		<Details>
+			<![CDATA[
+			<p>This abstract method is derived from a concrete method implementation. It is highly
+			suspect that the super class method's implementation would be cast away. 
+			</p>
+			]]>
+		</Details>		
+	</BugPattern>
+	
 	<!-- BugCode -->
 	
 	<BugCode abbrev="ISB">Inefficient String Buffering</BugCode>
@@ -702,4 +724,5 @@
 	<BugCode abbrev="COM">Copied Overridden Method</BugCode>
 	<BugCode abbrev="ABC">Array Based Collection</BugCode>
 	<BugCode abbrev="ODN">Orphaned DOM Node</BugCode>
+	<BugCode abbrev="AOM">Abstract Overridden Method</BugCode>
 </MessageCollection>
\ No newline at end of file

Index: findbugs.xml
===================================================================
RCS file: /cvsroot/fb-contrib/fb-contrib/etc/findbugs.xml,v
retrieving revision 1.45
retrieving revision 1.46
diff -u -d -r1.45 -r1.46
--- findbugs.xml	23 Dec 2005 05:23:27 -0000	1.45
+++ findbugs.xml	28 Dec 2005 03:40:18 -0000	1.46
@@ -117,6 +117,10 @@
     <Detector class="com.mebigfatguy.fbcontrib.detect.OrphanedDOMNode"
     		speed="fast"
     		reports="ODN_ORPHANED_DOM_NODE" />
+    		
+    <Detector class="com.mebigfatguy.fbcontrib.detect.AbstractOverriddenMethod"
+    		speed="fast"
+    		reports="AOM_ABSTRACT_OVERRIDDEN_METHOD" />
 
    	<!-- BugPattern -->
 	
@@ -146,4 +150,5 @@
     <BugPattern abbrev="COM" type="COM_COPIED_OVERRIDDEN_METHOD" category="STYLE" />
     <BugPattern abbrev="ABC" type="ABC_ARRAY_BASED_COLLECTIONS" category="CORRECTNESS" experimental="true" />
 	<BugPattern abbrev="ODN" type="ODN_ORPHANED_DOM_NODE" category="CORRECTNESS" experimental="true" />
+	<BugPattern abbrev="AOM" type="AOM_ABSTRACT_OVERRIDDEN_METHOD" category="CORRECTNESS" experimental="true" />
 </FindbugsPlugin>
\ No newline at end of file