[Fb-contrib-commit] fb-contrib/etc findbugs.xml,1.42,1.43 messages.xml,1.35,1.36

[Dave B. <dbr...@us...>]

Update of /cvsroot/fb-contrib/fb-contrib/etc
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv3152/etc

Modified Files:
	findbugs.xml messages.xml 
Log Message:
initial check in - new COM detector

Index: messages.xml
===================================================================
RCS file: /cvsroot/fb-contrib/fb-contrib/etc/messages.xml,v
retrieving revision 1.35
retrieving revision 1.36
diff -u -d -r1.35 -r1.36
--- messages.xml	3 Dec 2005 16:46:47 -0000	1.35
+++ messages.xml	8 Dec 2005 03:46:59 -0000	1.36
@@ -315,6 +315,16 @@
 		</Details>
 	</Detector>
 	
+	<Detector class="com.mebigfatguy.fbcontrib.detect.CopiedOverriddenMethod">
+		<Details>
+			<![CDATA[
+			<p>Looks for methods that are direct copies of the implementation in the super class</p>
+			</p>
+			<p>It is a moderately fast detector</p>			
+			]]>
+		</Details>
+	</Detector>
+	
 	<!-- BugPattern -->
 	                
 	<BugPattern type="ISB_INEFFICIENT_STRING_BUFFERING">
@@ -603,6 +613,18 @@
 		</Details>
 	</BugPattern>
 			
+	<BugPattern type="COM_COPIED_OVERRIDDEN_METHOD">
+		<ShortDescription>method is implemented with an exact copy of it's superclass's method</ShortDescription>
+		<LongDescription>method {1} is implemented with an exact copy of it's superclass's method</LongDescription>
+		<Details>
+			<![CDATA[
+			<p>This method is implemented using an exact copy of it's super class method's 
+			implementation, which usually means that this method can just be removed.
+			</p>
+			]]>
+		</Details>
+	</BugPattern>
+	
 	<!-- BugCode -->
 	
 	<BugCode abbrev="ISB">Inefficient String Buffering</BugCode>
@@ -628,4 +650,5 @@
 	<BugCode abbrev="STS">Spurious Thread States</BugCode>
 	<BugCode abbrev="NAB">Needless Autoboxing</BugCode>
 	<BugCode abbrev="USBR">Unnecessary Store Before Return</BugCode>
+	<BugCode abbrev="COM">Copied Overridden Method</BugCode>
 </MessageCollection>
\ No newline at end of file

Index: findbugs.xml
===================================================================
RCS file: /cvsroot/fb-contrib/fb-contrib/etc/findbugs.xml,v
retrieving revision 1.42
retrieving revision 1.43
diff -u -d -r1.42 -r1.43
--- findbugs.xml	3 Dec 2005 16:46:47 -0000	1.42
+++ findbugs.xml	8 Dec 2005 03:46:59 -0000	1.43
@@ -105,6 +105,10 @@
     <Detector class="com.mebigfatguy.fbcontrib.detect.UnnecessaryStoreBeforeReturn"
     		speed="fast"
     		reports="USBR_UNNECESSARY_STORE_BEFORE_RETURN" />
+    		
+    <Detector class="com.mebigfatguy.fbcontrib.detect.CopiedOverriddenMethod"
+    		speed="moderate"
+    		reports="COM_COPIED_OVERRIDDEN_METHOD" />
 
    	<!-- BugPattern -->
 	
@@ -131,4 +135,5 @@
     <BugPattern abbrev="STS" type="STS_SPURIOUS_THREAD_STATES" category="MT_CORRECTNESS" experimental="true" />
     <BugPattern abbrev="NAB" type="NAB_NEEDLESS_AUTOBOXING" category="PERFORMANCE" experimental="true" />
     <BugPattern abbrev="USBR" type="USBR_UNNECESSARY_STORE_BEFORE_RETURN" category="STYLE" experimental="true" />
+    <BugPattern abbrev="COM" type="COM_COPIED_OVERRIDDEN_METHOD" category="STYLE" experimental="true" />
 </FindbugsPlugin>
\ No newline at end of file