[Fb-contrib-commit] fb-contrib/src/com/mebigfatguy/fbcontrib/detect AbnormalFinallyBlockReturn.java,
Brought to you by:
dbrosius
|
From: Dave B. <dbr...@us...> - 2005-11-16 07:09:07
|
Update of /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv2509/src/com/mebigfatguy/fbcontrib/detect Modified Files: AbnormalFinallyBlockReturn.java AbstractClassEmptyMethods.java ConfusingAutoboxedOverloading.java FloatingPointLoops.java ManualArrayCopy.java NonCollectionMethodUse.java Log Message: pretend i'm actually doing something Index: NonCollectionMethodUse.java =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonCollectionMethodUse.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -d -r1.1 -r1.2 --- NonCollectionMethodUse.java 1 Nov 2005 05:41:14 -0000 1.1 +++ NonCollectionMethodUse.java 16 Nov 2005 07:08:59 -0000 1.2 @@ -47,10 +47,12 @@ this.bugReporter = bugReporter; } + @Override public Object clone() throws CloneNotSupportedException { return super.clone(); } + @Override public void sawOpcode(int seen) { if (seen == INVOKEVIRTUAL) { String className = getClassConstantOperand(); Index: AbnormalFinallyBlockReturn.java =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbnormalFinallyBlockReturn.java,v retrieving revision 1.3 retrieving revision 1.4 diff -u -d -r1.3 -r1.4 --- AbnormalFinallyBlockReturn.java 10 Nov 2005 01:53:49 -0000 1.3 +++ AbnormalFinallyBlockReturn.java 16 Nov 2005 07:08:59 -0000 1.4 @@ -43,16 +43,19 @@ this.bugReporter = bugReporter; } + @Override public Object clone() throws CloneNotSupportedException { return super.clone(); } - public void visitClassContext(ClassContext classContext) { + @Override + public void visitClassContext(ClassContext classContext) { majorVersion = classContext.getJavaClass().getMajor(); if (majorVersion >= MAJOR_1_4) super.visitClassContext(classContext); } + @Override public void visitCode(Code obj) { fbInfo.clear(); loadedReg = -1; @@ -71,7 +74,8 @@ super.visitCode(obj); } - public void sawOpcode(int seen) { + @Override + public void sawOpcode(int seen) { if (fbInfo.size() == 0) return; Index: AbstractClassEmptyMethods.java =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbstractClassEmptyMethods.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -d -r1.1 -r1.2 --- AbstractClassEmptyMethods.java 23 Oct 2005 04:59:15 -0000 1.1 +++ AbstractClassEmptyMethods.java 16 Nov 2005 07:08:59 -0000 1.2 @@ -55,21 +55,25 @@ this.bugReporter = bugReporter; } + @Override public Object clone() throws CloneNotSupportedException { return super.clone(); } + @Override public void visitClassContext(ClassContext classContext) { JavaClass cls = classContext.getJavaClass(); if (cls.isAbstract()) super.visitClassContext(classContext); } + @Override public void visitMethod(Method obj) { methodName = obj.getName(); state = SEEN_NOTHING; } + @Override public void visitCode(Code obj) { if ("<init>".equals(methodName) || "<clinit>".equals(methodName)) return; @@ -77,6 +81,7 @@ super.visitCode(obj); } + @Override public void sawOpcode(int seen) { try { switch (state) { Index: ConfusingAutoboxedOverloading.java =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingAutoboxedOverloading.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -d -r1.2 -r1.3 --- ConfusingAutoboxedOverloading.java 3 Nov 2005 05:19:08 -0000 1.2 +++ ConfusingAutoboxedOverloading.java 16 Nov 2005 07:08:59 -0000 1.3 @@ -29,7 +29,6 @@ import edu.umd.cs.findbugs.BugInstance; import edu.umd.cs.findbugs.BugReporter; -import edu.umd.cs.findbugs.ClassAnnotation; import edu.umd.cs.findbugs.Detector; import edu.umd.cs.findbugs.StatelessDetector; import edu.umd.cs.findbugs.ba.ClassContext; @@ -38,7 +37,6 @@ public class ConfusingAutoboxedOverloading extends PreorderVisitor implements Detector, StatelessDetector { private static final int JDK15_MAJOR = 49; - private static final int JDK15_MINOR = 0; private static final Set<String> primitiveSigs = new HashSet<String>(); static { @@ -53,6 +51,7 @@ this.bugReporter = bugReporter; } + @Override public Object clone() throws CloneNotSupportedException { return super.clone(); } @@ -154,7 +153,6 @@ return false; } - public void report() { - + public void report() { } } Index: ManualArrayCopy.java =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ManualArrayCopy.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -d -r1.1 -r1.2 --- ManualArrayCopy.java 26 Oct 2005 04:08:13 -0000 1.1 +++ ManualArrayCopy.java 16 Nov 2005 07:08:59 -0000 1.2 @@ -42,15 +42,18 @@ this.bugReporter = bugReporter; } + @Override public Object clone() throws CloneNotSupportedException { return super.clone(); } + @Override public void visitCode(Code obj) { state = SEEN_NOTHING; super.visitCode(obj); } + @Override public void sawOpcode(int seen) { switch (state) { case SEEN_NOTHING: Index: FloatingPointLoops.java =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FloatingPointLoops.java,v retrieving revision 1.5 retrieving revision 1.6 diff -u -d -r1.5 -r1.6 --- FloatingPointLoops.java 7 Nov 2005 02:51:49 -0000 1.5 +++ FloatingPointLoops.java 16 Nov 2005 07:08:59 -0000 1.6 @@ -44,14 +44,17 @@ this.bugReporter = bugReporter; } + @Override public Object clone() throws CloneNotSupportedException { return super.clone(); } + @Override public void visitMethod(Method obj) { forLoops.clear(); } + @Override public void sawOpcode(int seen) { if (forLoops.size() > 0) { Iterator<FloatForLoop> ffl = forLoops.iterator(); |