[Fb-contrib-commit] fb-contrib/etc findbugs.xml,1.25,1.26 messages.xml,1.25,1.26

[Dave B. <dbr...@us...>]

Update of /cvsroot/fb-contrib/fb-contrib/etc
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv5479/etc

Modified Files:
	findbugs.xml messages.xml 
Log Message:
new detector MAC, initial checkin

Index: messages.xml
===================================================================
RCS file: /cvsroot/fb-contrib/fb-contrib/etc/messages.xml,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -d -r1.25 -r1.26
--- messages.xml	23 Oct 2005 04:59:15 -0000	1.25
+++ messages.xml	26 Oct 2005 04:08:12 -0000	1.26
@@ -179,6 +179,16 @@
 		</Details>
 	</Detector>
 
+	<Detector class="com.mebigfatguy.fbcontrib.detect.ManualArrayCopy">
+		<Details>
+			<![CDATA[
+			<p> Looks for methods that copy data from one array to another using a loop. It is
+			better performing to use System.arraycopy to do such copying as this is a native method.</p>
+			<p>It is a fast detector</p>
+			]]>
+		</Details>
+	</Detector>
+
 	<!-- BugPattern -->
 	                
 	<BugPattern type="ISB_INEFFICIENT_STRING_BUFFERING">
@@ -353,6 +363,17 @@
 		</Details>
 	</BugPattern>
 	
+	<BugPattern type="MAC_MANUAL_ARRAY_COPY">
+		<ShortDescription>method copies arrays manually</ShortDescription>
+		<LongDescription>method {1} copies arrays manually</LongDescription>
+		<Details>
+			<![CDATA[
+			<p>This method copies data from one array to another manually using a loop.
+			It is much better performing to use System.arraycopy as this method is native.</p>
+			]]>
+		</Details>
+	</BugPattern>
+	
 	<!-- BugCode -->
 	
 	<BugCode abbrev="ISB">Inefficient String Buffering</BugCode>
@@ -369,5 +390,6 @@
 	<BugCode abbrev="PL">Parallel Lists</BugCode>
 	<BugCode abbrev="FP">Final Parameters</BugCode>
 	<BugCode abbrev="ACEM">Abstract Class Empty Methods</BugCode>
+	<BugCode abbrev="MAC">Manual Array Copy</BugCode>
 	
 </MessageCollection>
\ No newline at end of file

Index: findbugs.xml
===================================================================
RCS file: /cvsroot/fb-contrib/fb-contrib/etc/findbugs.xml,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -d -r1.25 -r1.26
--- findbugs.xml	23 Oct 2005 04:59:15 -0000	1.25
+++ findbugs.xml	26 Oct 2005 04:08:12 -0000	1.26
@@ -70,6 +70,10 @@
     		speed="fast"
     		reports="ACEM_ABSTRACT_CLASS_EMPTY_METHODS" />
 
+    <Detector class="com.mebigfatguy.fbcontrib.detect.ManualArrayCopy"
+    		speed="fast"
+    		reports="MAC_MANUAL_ARRAY_COPY" />
+
 
    	<!-- BugPattern -->
 	
@@ -87,5 +91,6 @@
     <BugPattern abbrev="PL" type="PL_PARALLEL_LISTS" category="STYLE" />
     <BugPattern abbrev="FP" type="FP_FINAL_PARAMETERS" category="STYLE" experimental="true" />
     <BugPattern abbrev="ACEM" type="ACEM_ABSTRACT_CLASS_EMPTY_METHODS" category="STYLE" experimental="true" />
+    <BugPattern abbrev="MAC" type="MAC_MANUAL_ARRAY_COPY" category="PERFORMANCE" experimental="true" />
     
 </FindbugsPlugin>
\ No newline at end of file