[Fb-contrib-commit] fb-contrib/src/com/mebigfatguy/fbcontrib/detect ClassEnvy.java,1.4,1.5 Cyclomati
Brought to you by:
dbrosius
Menu
▾
▴
[Fb-contrib-commit] fb-contrib/src/com/mebigfatguy/fbcontrib/detect ClassEnvy.java,1.4,1.5 CyclomaticComplexity.java,1.4,1.5 DeclaredRuntimeException.java,1.4,1.5 DubiousListCollection.java,1.4,1.5 FinalParameters.java,1.3,1.4 InefficientStringBuffering.java,1.2,1.3 ListIndexedIterating.java,1.2,1.3 LiteralStringComparison.java,1.3,1.4 OverlyConcreteParameter.java,1.17,1.18 ParallelLists.java,1.5,1.6 PartiallyConstructedObjectAccess.java,1.2,1.3 SyncCollectionIterators.java,1.4,1.5 UnrelatedCollectionContents.java,1.7,1.8
Update of /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv27324/src/com/mebigfatguy/fbcontrib/detect Modified Files: ClassEnvy.java CyclomaticComplexity.java DeclaredRuntimeException.java DubiousListCollection.java FinalParameters.java InefficientStringBuffering.java ListIndexedIterating.java LiteralStringComparison.java OverlyConcreteParameter.java ParallelLists.java PartiallyConstructedObjectAccess.java SyncCollectionIterators.java UnrelatedCollectionContents.java Log Message: add @Override annotations Index: DeclaredRuntimeException.java =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeclaredRuntimeException.java,v retrieving revision 1.4 retrieving revision 1.5 diff -u -d -r1.4 -r1.5 --- DeclaredRuntimeException.java 1 Oct 2005 07:22:44 -0000 1.4 +++ DeclaredRuntimeException.java 1 Oct 2005 07:38:02 -0000 1.5 @@ -53,6 +53,7 @@ this.bugReporter = bugReporter; } + @Override public Object clone() throws CloneNotSupportedException { return super.clone(); } @@ -62,6 +63,7 @@ classContext.getJavaClass().accept(this); } + @Override public void visitMethod(final Method obj) { ExceptionTable et = obj.getExceptionTable(); if (et != null) { Index: ListIndexedIterating.java =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ListIndexedIterating.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -d -r1.2 -r1.3 --- ListIndexedIterating.java 1 Oct 2005 07:22:44 -0000 1.2 +++ ListIndexedIterating.java 1 Oct 2005 07:38:02 -0000 1.3 @@ -56,10 +56,12 @@ possibleForLoops = new HashSet<ForLoop>(); } + @Override public Object clone() throws CloneNotSupportedException { return super.clone(); } + @Override public void visitCode(final Code obj) { sawListSize = false; @@ -76,6 +78,7 @@ } } + @Override public void sawOpcode(final int seen) { if (stage == FIND_LOOP_STAGE) sawOpcodeLoop(seen); Index: UnrelatedCollectionContents.java =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedCollectionContents.java,v retrieving revision 1.7 retrieving revision 1.8 diff -u -d -r1.7 -r1.8 --- UnrelatedCollectionContents.java 1 Oct 2005 07:22:44 -0000 1.7 +++ UnrelatedCollectionContents.java 1 Oct 2005 07:38:02 -0000 1.8 @@ -62,16 +62,19 @@ stack = new OpcodeStack(); } + @Override public Object clone() throws CloneNotSupportedException { return super.clone(); } + @Override public void visitClassContext(final ClassContext classContext) { memberCollections = new HashMap<String, Set<String>>(); memberSourceLineAnnotations = new HashMap<String, Set<SourceLineAnnotation>>(); super.visitClassContext(classContext); } + @Override public void visitCode(final Code obj) { localCollections = new HashMap<Integer, Set<String>>(); localScopeEnds = new HashMap<Integer, Set<Integer>>(); @@ -80,6 +83,7 @@ super.visitCode(obj); } + @Override public void sawOpcode(final int seen) { try { Set<Integer> regs = localScopeEnds.remove(getPC()); Index: SyncCollectionIterators.java =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SyncCollectionIterators.java,v retrieving revision 1.4 retrieving revision 1.5 diff -u -d -r1.4 -r1.5 --- SyncCollectionIterators.java 1 Oct 2005 07:24:36 -0000 1.4 +++ SyncCollectionIterators.java 1 Oct 2005 07:38:02 -0000 1.5 @@ -61,15 +61,18 @@ this.bugReporter = bugReporter; } + @Override public Object clone() throws CloneNotSupportedException { return super.clone(); } + @Override public void visitClassContext(final ClassContext classContext) { memberCollections.clear(); super.visitClassContext(classContext); } + @Override public void visitCode(final Code obj) { if (obj.getCode() != null) { state = SEEN_NOTHING; @@ -77,6 +80,8 @@ super.visitCode(obj); } } + + @Override public void sawOpcode(final int seen) { switch (state) { case SEEN_NOTHING: Index: FinalParameters.java =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FinalParameters.java,v retrieving revision 1.3 retrieving revision 1.4 diff -u -d -r1.3 -r1.4 --- FinalParameters.java 1 Oct 2005 07:22:44 -0000 1.3 +++ FinalParameters.java 1 Oct 2005 07:38:02 -0000 1.4 @@ -45,10 +45,12 @@ this.bugReporter = bugReporter; } + @Override public Object clone() throws CloneNotSupportedException { return super.clone(); } + @Override public void visitMethod(final Method obj) { isStatic = (obj.getAccessFlags() & Constants.ACC_STATIC) != 0; isAbstract = (obj.getAccessFlags() & Constants.ACC_ABSTRACT) != 0; @@ -57,6 +59,7 @@ super.visitMethod(obj); } + @Override public void visitCode(final Code obj) { if (isAbstract) return; @@ -82,6 +85,7 @@ } } + @Override public void sawOpcode(final int seen) { if ((seen == ASTORE) || ((seen >= ASTORE_0) && (seen <= ASTORE_3))) { int parm = getAStoreParameter(seen); Index: CyclomaticComplexity.java =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CyclomaticComplexity.java,v retrieving revision 1.4 retrieving revision 1.5 diff -u -d -r1.4 -r1.5 --- CyclomaticComplexity.java 1 Oct 2005 07:22:44 -0000 1.4 +++ CyclomaticComplexity.java 1 Oct 2005 07:38:02 -0000 1.5 @@ -50,6 +50,7 @@ reportLimit = limit.intValue(); } + @Override public Object clone() throws CloneNotSupportedException { return super.clone(); } @@ -62,6 +63,7 @@ public void report() { } + @Override public void visitMethod(final Method obj) { try { if (obj.getCode() == null) Index: ClassEnvy.java =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ClassEnvy.java,v retrieving revision 1.4 retrieving revision 1.5 diff -u -d -r1.4 -r1.5 --- ClassEnvy.java 1 Oct 2005 07:22:44 -0000 1.4 +++ ClassEnvy.java 1 Oct 2005 07:38:02 -0000 1.5 @@ -59,10 +59,12 @@ } } + @Override public Object clone() throws CloneNotSupportedException { return super.clone(); } + @Override public void visitClassContext(final ClassContext classContext) { JavaClass cls = classContext.getJavaClass(); packageName = cls.getPackageName(); @@ -70,6 +72,7 @@ super.visitClassContext(classContext); } + @Override public void visitCode(final Code obj) { stack.resetForMethodEntry(this); clsAccessCount = new HashMap<String, Integer>(); @@ -104,6 +107,7 @@ } } + @Override public void sawOpcode(final int seen) { try { if ((seen == INVOKEVIRTUAL) Index: ParallelLists.java =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ParallelLists.java,v retrieving revision 1.5 retrieving revision 1.6 diff -u -d -r1.5 -r1.6 --- ParallelLists.java 1 Oct 2005 07:22:44 -0000 1.5 +++ ParallelLists.java 1 Oct 2005 07:38:02 -0000 1.6 @@ -46,10 +46,12 @@ this.bugReporter = bugReporter; } + @Override public Object clone() throws CloneNotSupportedException { return super.clone(); } + @Override public void visitClassContext(final ClassContext classContext) { JavaClass cls = classContext.getJavaClass(); @@ -70,12 +72,14 @@ super.visitClassContext(classContext); } + @Override public void visitCode(final Code obj) { stack.resetForMethodEntry(this); indexToFieldMap.clear(); super.visitCode(obj); } + @Override public void sawOpcode(final int seen) { try { if (seen == INVOKEINTERFACE) { Index: LiteralStringComparison.java =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LiteralStringComparison.java,v retrieving revision 1.3 retrieving revision 1.4 diff -u -d -r1.3 -r1.4 --- LiteralStringComparison.java 1 Oct 2005 07:22:44 -0000 1.3 +++ LiteralStringComparison.java 1 Oct 2005 07:38:02 -0000 1.4 @@ -35,15 +35,18 @@ stack = new OpcodeStack(); } + @Override public Object clone() throws CloneNotSupportedException { return super.clone(); } + @Override public void visitCode(final Code obj) { stack.resetForMethodEntry(this); super.visitCode(obj); } + @Override public void sawOpcode(final int seen) { try { if ((seen == INVOKEVIRTUAL) && "java/lang/String".equals(getClassConstantOperand())) { Index: DubiousListCollection.java =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DubiousListCollection.java,v retrieving revision 1.4 retrieving revision 1.5 diff -u -d -r1.4 -r1.5 --- DubiousListCollection.java 1 Oct 2005 07:22:44 -0000 1.4 +++ DubiousListCollection.java 1 Oct 2005 07:38:02 -0000 1.5 @@ -66,6 +66,7 @@ this.bugReporter = bugReporter; } + @Override public void visitClassContext(ClassContext classContext) { JavaClass cls = classContext.getJavaClass(); Field[] flds = cls.getFields(); @@ -85,11 +86,13 @@ } } + @Override public void visitCode(final Code obj) { stack.resetForMethodEntry(this); super.visitCode(obj); } + @Override public void sawOpcode(final int seen) { try { if (seen == INVOKEINTERFACE) { Index: PartiallyConstructedObjectAccess.java =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PartiallyConstructedObjectAccess.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -d -r1.2 -r1.3 --- PartiallyConstructedObjectAccess.java 1 Oct 2005 07:22:44 -0000 1.2 +++ PartiallyConstructedObjectAccess.java 1 Oct 2005 07:38:02 -0000 1.3 @@ -41,16 +41,19 @@ stack = new OpcodeStack(); } + @Override public Object clone() throws CloneNotSupportedException { return super.clone(); } + @Override public void visitClassContext(final ClassContext classContext) { JavaClass cls = classContext.getJavaClass(); if ((cls.getAccessFlags() & Constants.ACC_FINAL) == 0) super.visitClassContext(classContext); } + @Override public void visitCode(final Code obj) { stack.resetForMethodEntry(this); reportedCtor = false; @@ -58,6 +61,7 @@ super.visitCode(obj); } + @Override public void sawOpcode(int seen) { if (reportedCtor) return; Index: InefficientStringBuffering.java =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InefficientStringBuffering.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -d -r1.2 -r1.3 --- InefficientStringBuffering.java 1 Oct 2005 07:22:44 -0000 1.2 +++ InefficientStringBuffering.java 1 Oct 2005 07:38:02 -0000 1.3 @@ -37,16 +37,20 @@ opStack = new OpcodeStack(); } + @Override public Object clone() throws CloneNotSupportedException { return super.clone(); } + @Override public void visit(final Code c) { if (c.getCode() != null) { opStack.resetForMethodEntry(this); super.visit(c); } } + + @Override public void sawOpcode(final int seen) { try { if (seen == INVOKESPECIAL) { Index: OverlyConcreteParameter.java =================================================================== RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OverlyConcreteParameter.java,v retrieving revision 1.17 retrieving revision 1.18 diff -u -d -r1.17 -r1.18 --- OverlyConcreteParameter.java 1 Oct 2005 07:22:44 -0000 1.17 +++ OverlyConcreteParameter.java 1 Oct 2005 07:38:02 -0000 1.18 @@ -61,10 +61,12 @@ } } + @Override public Object clone() throws CloneNotSupportedException { return super.clone(); } + @Override public void visitCode(final Code obj) { try { parameterDefiners.clear(); @@ -89,6 +91,7 @@ } } + @Override public void sawOpcode(final int seen) { if (parameterDefiners.size() == 0) return; |
