[Fb-contrib-commit] fb-contrib/etc findbugs.xml,1.17,1.18 messages.xml,1.17,1.18

[Dave B. <dbr...@us...>]

Update of /cvsroot/fb-contrib/fb-contrib/etc
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv23743/etc

Modified Files:
	findbugs.xml messages.xml 
Log Message:
Initial Checkin: PL Detector

Index: messages.xml
===================================================================
RCS file: /cvsroot/fb-contrib/fb-contrib/etc/messages.xml,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -d -r1.17 -r1.18
--- messages.xml	23 Sep 2005 01:44:48 -0000	1.17
+++ messages.xml	25 Sep 2005 04:49:11 -0000	1.18
@@ -157,6 +157,17 @@
 		</Details>
 	</Detector>
 	
+	<Detector class="com.mebigfatguy.fbcontrib.detect.DubiousListCollection">
+		<Details>
+			<![CDATA[
+			<p> Looks for classes that maintain two or more lists or arrays associated one for one through the same index
+			to hold two or more pieces of related information. It would be better to create a new class that holds
+			all of these pieces of information, and place instances of this class in one list.</p>
+			<p>It is a fast detector</p>
+			]]>
+		</Details>
+	</Detector>
+	
 	<!-- BugPattern -->
 	                
 	<BugPattern type="ISB_INEFFICIENT_STRING_BUFFERING">
@@ -307,6 +318,18 @@
 		</Details>
 	</BugPattern>
 	
+	<BugPattern type="PL_PARALLEL_LISTS">
+		<ShortDescription>class defines two or more one for one associated lists or arrays</ShortDescription>
+		<LongDescription>class {0} defines two or more one for one associated lists or arrays</LongDescription>
+		<Details>
+			<![CDATA[
+			<p>This class appears to maintain two or more lists or arrays who's contains is related one for one
+			through the index of the list or array. Consider creating a separate class to hold all the related 
+			pieces of information, and adding instances of this class to just one list or array.</p>
+			]]>
+		</Details>
+	</BugPattern>
+	
 	<!-- BugCode -->
 	
 	<BugCode abbrev="ISB">Inefficient String Buffering</BugCode>
@@ -321,5 +344,6 @@
 	<BugCode abbrev="LSC">Literal String Comparison</BugCode>
 	<BugCode abbrev="PCOA">Partially Constructed Object Access</BugCode>
 	<BugCode abbrev="DLC">Dubious List Collection</BugCode>
+	<BugCode abbrev="PL">PL_PARALLEL_LISTS</BugCode>
 	
 </MessageCollection>
\ No newline at end of file

Index: findbugs.xml
===================================================================
RCS file: /cvsroot/fb-contrib/fb-contrib/etc/findbugs.xml,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -d -r1.17 -r1.18
--- findbugs.xml	22 Sep 2005 05:48:01 -0000	1.17
+++ findbugs.xml	25 Sep 2005 04:49:10 -0000	1.18
@@ -62,6 +62,12 @@
     		speed="fast"
     		reports="DLC_DUBIOUS_LIST_COLLECTION" />
     		
+    <Detector class="com.mebigfatguy.fbcontrib.detect.ParallelLists"
+    		speed="fast"
+    		reports="PL_PARALLEL_LISTS"
+    		hidden="true" />
+
+
    	<!-- BugPattern -->
 	
 	<BugPattern abbrev="ISB" type="ISB_INEFFICIENT_STRING_BUFFERING" category="PERFORMANCE" />
@@ -76,5 +82,6 @@
     <BugPattern abbrev="LSC" type="LSC_LITERAL_STRING_COMPARISON" category="STYLE" experimental="true" />
     <BugPattern abbrev="PCOA" type="PCOA_PARTIALLY_CONSTRUCTED_OBJECT_ACCESS" category="CORRECTNESS" experimental="true" />
     <BugPattern abbrev="DLC" type="DLC_DUBIOUS_LIST_COLLECTION" category="PERFORMANCE" experimental="true" />
+    <BugPattern abbrev="PL" type="PL_PARALLEL_LISTS" category="STYLE" experimental="true" />
     
 </FindbugsPlugin>
\ No newline at end of file