[Fb-contrib-commit] fb-contrib/etc findbugs.xml,1.14,1.15 messages.xml,1.13,1.14

[Dave B. <dbr...@us...>]

Update of /cvsroot/fb-contrib/fb-contrib/etc
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv28847/etc

Modified Files:
	findbugs.xml messages.xml 
Log Message:
Initial checkin: PCOA

Index: messages.xml
===================================================================
RCS file: /cvsroot/fb-contrib/fb-contrib/etc/messages.xml,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -d -r1.13 -r1.14
--- messages.xml	19 Sep 2005 04:20:20 -0000	1.13
+++ messages.xml	20 Sep 2005 02:28:42 -0000	1.14
@@ -134,6 +134,17 @@
 		</Details>
 	</Detector>
 	
+	<Detector class="com.mebigfatguy.fbcontrib.detect.PartiallyConstructedObjectAccess">
+		<Details>
+			<![CDATA[
+			<p> Looks for constructors of non final classes that make method calls to non final methods.
+			As these methods could be overridden, the overridden method will be accessing an object that
+			is only partially constructed, perhaps causing problems.</p>
+			<p>It is a fast detector</p>
+			]]>
+		</Details>
+	</Detector>
+	
 	<!-- BugPattern -->
 	                
 	<BugPattern type="ISB_INEFFICIENT_STRING_BUFFERING">
@@ -259,6 +270,18 @@
 		</Details>
 	</BugPattern>
 
+	<BugPattern type="PCOA_PARTIALLY_CONSTRUCTED_OBJECT_ACCESS">
+		<ShortDescription>constructor makes call to non-final method</ShortDescription>
+		<LongDescription>constructor {1} makes call to non-final method</LongDescription>
+		<Details>
+			<![CDATA[
+			<p>This constructor makes a call to a non-final method. Since this method can be overriden, a subclasses
+			implementation will be executing against an object that has not been initialized at the subclass level.
+			You should mark all methods called from the constructor as final to avoid this problem.</p>
+			]]>
+		</Details>
+	</BugPattern>
+
 	<!-- BugCode -->
 	
 	<BugCode abbrev="ISB">Inefficient String Buffering</BugCode>
@@ -271,5 +294,6 @@
 	<BugCode abbrev="CE">Class Envy</BugCode>
 	<BugCode abbrev="FP">Final Parameters</BugCode>
 	<BugCode abbrev="LSC">Literal String Comparison</BugCode>
-
+	<BugCode abbrev="PCOA">Partially Constructed Object Access</BugCode>
+	
 </MessageCollection>
\ No newline at end of file

Index: findbugs.xml
===================================================================
RCS file: /cvsroot/fb-contrib/fb-contrib/etc/findbugs.xml,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -d -r1.14 -r1.15
--- findbugs.xml	19 Sep 2005 04:20:19 -0000	1.14
+++ findbugs.xml	20 Sep 2005 02:28:42 -0000	1.15
@@ -54,6 +54,10 @@
     		speed="fast"
     		reports="LSC_LITERAL_STRING_COMPARISON" />
     		
+    <Detector class="com.mebigfatguy.fbcontrib.detect.PartiallyConstructedObjectAccess"
+    		speed="fast"
+    		reports="PCOA_PARTIALLY_CONSTRUCTED_OBJECT_ACCESS" />
+    		
    	<!-- BugPattern -->
 	
 	<BugPattern abbrev="ISB" type="ISB_INEFFICIENT_STRING_BUFFERING" category="PERFORMANCE" />
@@ -66,5 +70,6 @@
     <BugPattern abbrev="CE" type="CE_CLASS_ENVY" category="STYLE" experimental="true" />
     <BugPattern abbrev="FP" type="FP_FINAL_PARAMETERS" category="STYLE" experimental="true" />
     <BugPattern abbrev="LSC" type="LSC_LITERAL_STRING_COMPARISON" category="STYLE" experimental="true" />
+    <BugPattern abbrev="PCOA" type="PCOA_PARTIALLY_CONSTRUCTED_OBJECT_ACCESS" category="CORRECTNESS" experimental="true" />
     
 </FindbugsPlugin>
\ No newline at end of file