[Fb-contrib-commit] SF.net SVN: fb-contrib:[1658] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/BloatedAssignmentScope.java

[<dbr...@us...>]

Revision: 1658
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1658&view=rev
Author:   dbrosius
Date:     2011-03-06 21:56:49 +0000 (Sun, 06 Mar 2011)

Log Message:
-----------
rule out ObjectInput as well

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedAssignmentScope.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedAssignmentScope.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedAssignmentScope.java	2011-03-06 16:59:29 UTC (rev 1657)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedAssignmentScope.java	2011-03-06 21:56:49 UTC (rev 1658)
@@ -47,9 +47,13 @@
  */
 public class BloatedAssignmentScope extends BytecodeScanningDetector
 {
-	private static final Set<String> dangerousAssignmentSources = new HashSet<String>();
+	private static final Set<String> dangerousAssignmentClassSources = new HashSet<String>();
+	private static final Set<String> dangerousAssignmentMethodSources = new HashSet<String>();
+
 	static {
-		dangerousAssignmentSources.add("java/lang/System.currentTimeMillis()J");
+		dangerousAssignmentClassSources.add("java/io/InputStream");
+		dangerousAssignmentClassSources.add("java/io/ObjectInput");
+		dangerousAssignmentMethodSources.add("java/lang/System.currentTimeMillis()J");
 	}
 
 	BugReporter bugReporter;
@@ -798,8 +802,15 @@
 	}
 
 	public boolean isRiskyMethodCall() {
-		String key = getClassConstantOperand() + "." + getNameConstantOperand() + getSigConstantOperand();
-		return dangerousAssignmentSources.contains(key);
+
+		String clsName =getClassConstantOperand();
+
+		if (dangerousAssignmentClassSources.contains(clsName)) {
+			return true;
+		}
+
+		String key = clsName + "." + getNameConstantOperand() + getSigConstantOperand();
+		return dangerousAssignmentMethodSources.contains(key);
 	}
 
 	class UserObject {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.