[Fb-contrib-commit] SF.net SVN: fb-contrib:[1602] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/LostExceptionStackTrace.java

[<dbr...@us...>]

Revision: 1602
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1602&view=rev
Author:   dbrosius
Date:     2010-08-31 01:33:46 +0000 (Tue, 31 Aug 2010)

Log Message:
-----------
a better way, if the throw directly follows a MONITOREXIT, it's probably synthetic, so mark it LOW

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LostExceptionStackTrace.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LostExceptionStackTrace.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LostExceptionStackTrace.java	2010-08-31 01:30:07 UTC (rev 1601)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LostExceptionStackTrace.java	2010-08-31 01:33:46 UTC (rev 1602)
@@ -246,7 +246,8 @@
 								&&  itm.getUserValue() == null) {
                                     if (!isPre14Class(itm.getJavaClass()))
                                     {
-    									bugReporter.reportBug(new BugInstance(this, "LEST_LOST_EXCEPTION_STACK_TRACE", NORMAL_PRIORITY)
+                                    	int priority = getPrevOpcode(1) == MONITOREXIT ? LOW_PRIORITY : NORMAL_PRIORITY;
+    									bugReporter.reportBug(new BugInstance(this, "LEST_LOST_EXCEPTION_STACK_TRACE", priority)
     													.addClass(this)
     													.addMethod(this)
     													.addSourceLine(this));


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.