[Fb-contrib-commit] SF.net SVN: fb-contrib:[1599] trunk/fb-contrib

[<dbr...@us...>]

Revision: 1599
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1599&view=rev
Author:   dbrosius
Date:     2010-08-31 01:10:22 +0000 (Tue, 31 Aug 2010)

Log Message:
-----------
fix various spilleng and engrish problems in bug detectors and web page, thanks to Jean-No?\195?\171l Rouvignac

Modified Paths:
--------------
    trunk/fb-contrib/etc/messages.xml
    trunk/fb-contrib/htdocs/index.shtml

Modified: trunk/fb-contrib/etc/messages.xml
===================================================================
--- trunk/fb-contrib/etc/messages.xml	2010-08-30 12:55:14 UTC (rev 1598)
+++ trunk/fb-contrib/etc/messages.xml	2010-08-31 01:10:22 UTC (rev 1599)
@@ -1159,7 +1159,7 @@
 	<Detector class="com.mebigfatguy.fbcontrib.detect.PossibleUnsuspectedSerialization">
 		<Details>
 	 		<![CDATA[
-	 		<p>This detector looks for code that serailizes objects that are non-static inner
+	 		<p>This detector looks for code that serializes objects that are non-static inner
 	 		classes of other classes. Since there is a reference to the containing class, this class will be serialized as well.
 	 		It is often the case that this is not what is wanted, and will cause much more data to be serialized
 	 		than is necessary.</p>
@@ -3206,9 +3206,9 @@
 		<Details>
 			<![CDATA[
 				<p>This method creates an object but does not assign this object to any variable or field.
-				This implies that the class operations through side effects in the constructor, which is a 
-				bad pattern to use, as it adds unnecessary coupling. Consider pulling the side effect out of the constructor, into a separate method,
-				or into the calling method.
+				This implies that the class operates through side effects in the constructor, which is a 
+				bad pattern to use, as it adds unnecessary coupling. Consider pulling the side effect out of 
+				the constructor, into a separate method, or into the calling method.
 			]]>
 		</Details>
 	</BugPattern>

Modified: trunk/fb-contrib/htdocs/index.shtml
===================================================================
--- trunk/fb-contrib/htdocs/index.shtml	2010-08-30 12:55:14 UTC (rev 1598)
+++ trunk/fb-contrib/htdocs/index.shtml	2010-08-31 01:10:22 UTC (rev 1599)
@@ -90,8 +90,14 @@
 				or a change in implementation.</li>
 				<li><b>[PUS] Possible Unsuspected Serialization</b><br/>
 				Looks for serialization of non-static inner classes. As this serializes
-				the enclosing class, it may unintentially bring in more to the serialization
+				the enclosing class, it may unintentionally bring in more to the serialization
 				than is wanted.</li>
+				<li><b>[SEC] Side Effect Constructor</b><br/>
+				Looks for constructors that operate through side effects, specifically
+				constructors that aren't assigned to any variable or field. This makes
+				the code more difficult to maintain as it has a tendency to increase cohesion
+				between classes.
+				</li>
 			</ul>
 		</div>
 		<hr/>


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.