[Fb-contrib-commit] SF.net SVN: fb-contrib:[1538] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/MoreDumbMethods.java

[<dbr...@us...>]

Revision: 1538
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1538&view=rev
Author:   dbrosius
Date:     2010-04-04 08:18:39 +0000 (Sun, 04 Apr 2010)

Log Message:
-----------
revert -- getting assertion errors

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MoreDumbMethods.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MoreDumbMethods.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MoreDumbMethods.java	2010-04-04 08:12:31 UTC (rev 1537)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MoreDumbMethods.java	2010-04-04 08:18:39 UTC (rev 1538)
@@ -128,17 +128,27 @@
 	@Override
 	public void sawOpcode(int seen) {
 		
-		ReportInfo info = null;
-		if (seen == INVOKESPECIAL || seen == INVOKESTATIC) {
-			// static method invocation: no dispatch, straight call
-			info = dumbMethods.get(getMethodSignature());
-		} else if (seen == INVOKEVIRTUAL || seen == INVOKEINTERFACE) {
-			// virtual method invocation: dispatch is based on the class
-			info = dumbMethods.get(getVirtualMethodSignature());
- 		}
-		if (info != null) {
-			reportBug(info);
+		if (seen == INVOKEVIRTUAL 
+			|| seen == INVOKEINTERFACE
+			|| seen == INVOKESPECIAL
+			|| seen == INVOKESTATIC) {	
+			final ReportInfo info = dumbMethods.get(getMethodSignature());
+			if (info != null) {
+				reportBug(info);
+			}
 		}
+		
+//		ReportInfo info = null;
+//		if (seen == INVOKESPECIAL || seen == INVOKESTATIC) {
+//			// static method invocation: no dispatch, straight call
+//			info = dumbMethods.get(getMethodSignature());
+//		} else if (seen == INVOKEVIRTUAL || seen == INVOKEINTERFACE) {
+//			// virtual method invocation: dispatch is based on the class
+//			info = dumbMethods.get(getVirtualMethodSignature());
+// 		}
+//		if (info != null) {
+//			reportBug(info);
+//		}
 	}
 
 	private String getMethodSignature() {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.