[Fb-contrib-commit] SF.net SVN: fb-contrib:[1449] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/OverzealousCasting.java

[<dbr...@us...>]

Revision: 1449
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1449&view=rev
Author:   dbrosius
Date:     2010-01-05 09:03:16 +0000 (Tue, 05 Jan 2010)

Log Message:
-----------
using 1.5 now --> use enums

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OverzealousCasting.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OverzealousCasting.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OverzealousCasting.java	2010-01-05 09:02:06 UTC (rev 1448)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OverzealousCasting.java	2010-01-05 09:03:16 UTC (rev 1449)
@@ -41,12 +41,10 @@
 public class OverzealousCasting
     extends BytecodeScanningDetector
 {
-    public static final int SAW_NOTHING = 0;
-    public static final int SAW_NEXT = 1;
-    public static final int SAW_CHECKCAST = 2;
+	enum State {SAW_NOTHING, SAW_NEXT, SAW_CHECKCAST}
     
     BugReporter bugReporter;
-    int state;
+    State state;
     LocalVariableTable lvt;
     String castClass;
     
@@ -65,7 +63,7 @@
      */
     @Override
     public void visitCode(Code obj) {
-        state = SAW_NOTHING;
+        state = State.SAW_NOTHING;
         lvt = obj.getLocalVariableTable();
         if (lvt != null && prescreen(getMethod()))
             super.visitCode(obj);
@@ -93,19 +91,19 @@
             case SAW_NOTHING:
                 if (seen == CHECKCAST) {
                     castClass = getClassConstantOperand();
-                    state = SAW_CHECKCAST;
+                    state = State.SAW_CHECKCAST;
                 } else if (seen == INVOKEINTERFACE) {
                     //enhanced for loops add an incorrect checkcast instruction, so ignore checkcasts after iterator.next()
                     String clsName = getClassConstantOperand();
                     String methodName = getNameConstantOperand();
                     if ("java/util/Iterator".equals(clsName) && "next".equals(methodName)) {
-                        state = SAW_NEXT;
+                        state = State.SAW_NEXT;
                     }
                 }
             break;
             
             case SAW_NEXT:
-                state = SAW_NOTHING;
+                state = State.SAW_NOTHING;
             break;
             
             case SAW_CHECKCAST:
@@ -137,11 +135,11 @@
                                    .addSourceLine(this));
                     }
                 }
-                state = SAW_NOTHING;
+                state = State.SAW_NOTHING;
             break;
             
             default:
-                state = SAW_NOTHING;
+                state = State.SAW_NOTHING;
             break;
         }
     }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.