[Fb-contrib-commit] SF.net SVN: fb-contrib:[1327] trunk/fb-contrib/etc/messages.xml

[<dbr...@us...>]

Revision: 1327
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1327&view=rev
Author:   dbrosius
Date:     2009-09-26 20:06:57 +0000 (Sat, 26 Sep 2009)

Log Message:
-----------
add PDP Detector

Modified Paths:
--------------
    trunk/fb-contrib/etc/messages.xml

Modified: trunk/fb-contrib/etc/messages.xml
===================================================================
--- trunk/fb-contrib/etc/messages.xml	2009-09-26 20:06:42 UTC (rev 1326)
+++ trunk/fb-contrib/etc/messages.xml	2009-09-26 20:06:57 UTC (rev 1327)
@@ -1023,6 +1023,18 @@
 			]]>	
 		</Details>
 	</Detector>
+	
+	<Detector class="com.mebigfatguy.fbcontrib.detect.PoorlyDefinedParameter">
+		<Details>
+			<![CDATA[
+			<p>looks for non derivable methods that declare parameters and then cast those
+			parameters to more specific types in the method. This is misleading and dangerous
+			as you are not documenting through parameter types what is necessary for these
+			parameters to function correctly.</p>
+			<p>It is a fast detector</p>
+			]]>
+		</Details>
+	</Detector>
 			
 
 	<!-- BugPattern -->	
@@ -2656,6 +2668,18 @@
 		</Details>
 	</BugPattern>
 	
+	<BugPattern type="PDP_POORLY_DEFINED_PARAMETER">
+		<ShortDescription>method defines parameters more abstractly than needed to function properly</ShortDescription>
+		<LongDescription>method {1} defines parameters more abstractly than needed to function properly</LongDescription>
+		<Details>
+			<![CDATA[
+			<p>This method defines parameters at a more abstract level than is actually needed to function correctly,
+			as the code casts these parameters to more concrete types. Since this method is not derivable, you should 
+			just define the parameters with the type that is needed.
+			]]>
+		</Details>
+	</BugPattern>
+	
 	<!-- BugCode -->
 	
 	<BugCode abbrev="ISB">Inefficient String Buffering</BugCode>
@@ -2742,4 +2766,5 @@
 	<BugCode abbrev="ITU">Inappropriate ToString Use</BugCode>
 	<BugCode abbrev="IKNC">Inconsistent Key Name Casing</BugCode>
 	<BugCode abbrev="OC">Overzealous Casting</BugCode>
+	<BugCode abbrev="PDP">Poorly Defined Parameter</BugCode>
 </MessageCollection>
\ No newline at end of file


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.