[Fb-contrib-commit] SF.net SVN: fb-contrib:[1220] trunk/fb-contrib

[<dbr...@us...>]

Revision: 1220
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1220&view=rev
Author:   dbrosius
Date:     2009-07-17 03:12:15 +0000 (Fri, 17 Jul 2009)

Log Message:
-----------
spilleng

Modified Paths:
--------------
    trunk/fb-contrib/etc/bugrank.txt
    trunk/fb-contrib/etc/findbugs.xml
    trunk/fb-contrib/etc/messages.xml
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java

Modified: trunk/fb-contrib/etc/bugrank.txt
===================================================================
--- trunk/fb-contrib/etc/bugrank.txt	2009-07-15 04:48:45 UTC (rev 1219)
+++ trunk/fb-contrib/etc/bugrank.txt	2009-07-17 03:12:15 UTC (rev 1220)
@@ -105,7 +105,7 @@
 0 BugPattern JAO_JUNIT_ASSERTION_ODDITIES_ACTUAL_CONSTANT
 0 BugPattern JAO_JUNIT_ASSERTION_ODDITIES_INEXACT_DOUBLE
 0 BugPattern JAO_JUNIT_ASSERTION_ODDITIES_BOOLEAN_ASSERT
-0 BugPattern JAO_JUNIT_ASSERTION_ODITIES_IMPOSSIBLE_NULL
+0 BugPattern JAO_JUNIT_ASSERTION_ODDITIES_IMPOSSIBLE_NULL
 0 BugPattern SCA_SUSPICIOUS_CLONE_ALGORITHM
 0 BugPattern WEM_WEAK_EXCEPTION_MESSAGING
 0 BugPattern SCSS_SUSPICIOUS_CLUSTERED_SESSION_SUPPORT

Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================
--- trunk/fb-contrib/etc/findbugs.xml	2009-07-15 04:48:45 UTC (rev 1219)
+++ trunk/fb-contrib/etc/findbugs.xml	2009-07-17 03:12:15 UTC (rev 1220)
@@ -306,7 +306,7 @@
 			
 	<Detector class="com.mebigfatguy.fbcontrib.detect.JUnitAssertionOddities"
 			speed="fast"
-			reports="JAO_JUNIT_ASSERTION_ODDITIES_ACTUAL_CONSTANT,JAO_JUNIT_ASSERTION_ODDITIES_INEXACT_DOUBLE,JAO_JUNIT_ASSERTION_ODDITIES_BOOLEAN_ASSERT,JAO_JUNIT_ASSERTION_ODITIES_IMPOSSIBLE_NULL" />
+			reports="JAO_JUNIT_ASSERTION_ODDITIES_ACTUAL_CONSTANT,JAO_JUNIT_ASSERTION_ODDITIES_INEXACT_DOUBLE,JAO_JUNIT_ASSERTION_ODDITIES_BOOLEAN_ASSERT,JAO_JUNIT_ASSERTION_ODDITIES_IMPOSSIBLE_NULL" />
 			
 	<Detector class="com.mebigfatguy.fbcontrib.detect.SuspiciousCloneAlgorithm"
 			speed="fast"
@@ -461,7 +461,7 @@
 	<BugPattern abbrev="JAO" type="JAO_JUNIT_ASSERTION_ODDITIES_ACTUAL_CONSTANT" category="STYLE" />
 	<BugPattern abbrev="JAO" type="JAO_JUNIT_ASSERTION_ODDITIES_INEXACT_DOUBLE" category="STYLE" />
 	<BugPattern abbrev="JAO" type="JAO_JUNIT_ASSERTION_ODDITIES_BOOLEAN_ASSERT" category="STYLE" />
-	<BugPattern abbrev="JAO" type="JAO_JUNIT_ASSERTION_ODITIES_IMPOSSIBLE_NULL" category="CORRECTNESS" />
+	<BugPattern abbrev="JAO" type="JAO_JUNIT_ASSERTION_ODDITIES_IMPOSSIBLE_NULL" category="CORRECTNESS" />
 	<BugPattern abbrev="SCA" type="SCA_SUSPICIOUS_CLONE_ALGORITHM" category="CORRECTNESS" />
 	<BugPattern abbrev="WEM" type="WEM_WEAK_EXCEPTION_MESSAGING" category="STYLE" />
 	<BugPattern abbrev="SCSS" type="SCSS_SUSPICIOUS_CLUSTERED_SESSION_SUPPORT" category="CORRECTNESS" />

Modified: trunk/fb-contrib/etc/messages.xml
===================================================================
--- trunk/fb-contrib/etc/messages.xml	2009-07-15 04:48:45 UTC (rev 1219)
+++ trunk/fb-contrib/etc/messages.xml	2009-07-17 03:12:15 UTC (rev 1220)
@@ -2392,7 +2392,7 @@
 		</Details>
 	</BugPattern>
 	
-	<BugPattern type="JAO_JUNIT_ASSERTION_ODITIES_IMPOSSIBLE_NULL">
+	<BugPattern type="JAO_JUNIT_ASSERTION_ODDITIES_IMPOSSIBLE_NULL">
 		<ShortDescription>method asserts that an auto-boxed value is not null</ShortDescription>
 		<LongDescription>method {1} asserts that an auto-boxed value is not null</LongDescription>
 		<Details>

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java	2009-07-15 04:48:45 UTC (rev 1219)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java	2009-07-17 03:12:15 UTC (rev 1220)
@@ -176,7 +176,7 @@
 					} else if ("assertNotNull".equals(methodName)) {
 						if (stack.getStackDepth() > 0) {
 							if ("valueOf".equals(stack.getStackItem(0).getUserValue())) {
-								bugReporter.reportBug(new BugInstance(this, "JAO_JUNIT_ASSERTION_ODITIES_IMPOSSIBLE_NULL", NORMAL_PRIORITY)
+								bugReporter.reportBug(new BugInstance(this, "JAO_JUNIT_ASSERTION_ODDITIES_IMPOSSIBLE_NULL", NORMAL_PRIORITY)
 										   .addClass(this)
 										   .addMethod(this)
 										   .addSourceLine(this));


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.