[Fb-contrib-commit] SF.net SVN: fb-contrib:[1187] trunk/fb-contrib/etc/messages.xml

[<dbr...@us...>]

Revision: 1187
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1187&view=rev
Author:   dbrosius
Date:     2009-05-03 04:33:44 +0000 (Sun, 03 May 2009)

Log Message:
-----------
embellish LO with LO_SUSPECT_LOG_PARAMETER

Modified Paths:
--------------
    trunk/fb-contrib/etc/messages.xml

Modified: trunk/fb-contrib/etc/messages.xml
===================================================================
--- trunk/fb-contrib/etc/messages.xml	2009-05-03 04:33:29 UTC (rev 1186)
+++ trunk/fb-contrib/etc/messages.xml	2009-05-03 04:33:44 UTC (rev 1187)
@@ -883,8 +883,7 @@
 	<Detector class="com.mebigfatguy.fbcontrib.detect.LoggerOddities">
 		<Details>
 			<![CDATA[
-			<p>looks for code that allocates a Logger object by passing a specification of a class that
-			is not related to the class in which the logger is used.</p>
+			<p>looks for odd patterns of use of Logger classes from either log4j or slf4j.</p>
 			<p>It is a fast detector</p>
 			]]>
 		</Details>
@@ -2418,6 +2417,18 @@
 		</Details>
 	</BugPattern>
 	
+	<BugPattern type="LO_SUSPECT_LOG_PARAMETER">
+		<ShortDescription>constructor declares a Logger parameter</ShortDescription>
+		<LongDescription>constructor {1} declares a Logger parameter</LongDescription>
+		<Details>
+			<![CDATA[
+			<p>This constructor declares a parameter that is a Logger. As loggers are meant to be
+			created statically per class, it doesn't make sense that you would pass a Logger from one
+			class to another. Declare the Logger static in each class instead.</p>
+			]]>
+		</Details>
+	</BugPattern>
+	
 	<BugPattern type="IICU_INCORRECT_INTERNAL_CLASS_USE">
 		<ShortDescription>class relies on internal api classes</ShortDescription>
 		<LongDescription>class {0} relies on internal api classes</LongDescription>


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.