[Fb-contrib-commit] SF.net SVN: fb-contrib:[1185] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/LoggerOddities.java

[<dbr...@us...>]

Revision: 1185
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1185&view=rev
Author:   dbrosius
Date:     2009-05-03 04:33:15 +0000 (Sun, 03 May 2009)

Log Message:
-----------
embellish LO with LO_SUSPECT_LOG_PARAMETER

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java	2009-04-25 05:19:58 UTC (rev 1184)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java	2009-05-03 04:33:15 UTC (rev 1185)
@@ -23,7 +23,10 @@
 import org.apache.bcel.classfile.ConstantClass;
 import org.apache.bcel.classfile.ConstantPool;
 import org.apache.bcel.classfile.ConstantUtf8;
+import org.apache.bcel.classfile.Method;
 
+import com.sun.org.apache.bcel.internal.generic.Type;
+
 import edu.umd.cs.findbugs.BugInstance;
 import edu.umd.cs.findbugs.BugReporter;
 import edu.umd.cs.findbugs.BytecodeScanningDetector;
@@ -82,6 +85,21 @@
     @Override
     public void visitCode(Code obj) {
         stack.resetForMethodEntry(this);
+        Method m = getMethod();
+        if ("<init>".equals(m.getName())) {
+        	Type[] types = Type.getArgumentTypes(m.getSignature());
+        	for (Type t : types)
+        	{
+        		String parmSig = t.getSignature();
+        		if ("Lorg/slf4j/Logger;".equals(parmSig)
+        		||  "Lorg/apache/log4j/Logger;".equals(parmSig)) {
+                    bugReporter.reportBug(new BugInstance(this, "LO_SUSPECT_LOG_PARAMETER", NORMAL_PRIORITY)
+                    .addClass(this)
+                    .addMethod(this)
+                    .addSourceLine(this));
+        		}
+        	}
+        }
         super.visitCode(obj);
     }
     


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.