[Fb-contrib-commit] SF.net SVN: fb-contrib:[1064] trunk/fb-contrib/etc

[<dbr...@us...>]

Revision: 1064
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1064&view=rev
Author:   dbrosius
Date:     2008-08-08 05:31:36 +0000 (Fri, 08 Aug 2008)

Log Message:
-----------
hook up LO

Modified Paths:
--------------
    trunk/fb-contrib/etc/findbugs.xml
    trunk/fb-contrib/etc/messages.xml

Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================
--- trunk/fb-contrib/etc/findbugs.xml	2008-08-08 05:18:21 UTC (rev 1063)
+++ trunk/fb-contrib/etc/findbugs.xml	2008-08-08 05:31:36 UTC (rev 1064)
@@ -320,6 +320,10 @@
 			speed="fast"
 			reports="SCSS_SUSPICIOUS_CLUSTERED_SESSION_SUPPORT" />
 			
+	<Detector class="com.mebigfatguy.fbcontrib.detect.LoggerOddities"
+			speed="fast"
+			reports="LO_SUSPECT_LOG_CLASS" />
+			
    	<!-- BugPattern -->
 	
 	<BugPattern abbrev="ISB" type="ISB_INEFFICIENT_STRING_BUFFERING" category="PERFORMANCE" />
@@ -421,11 +425,12 @@
 	<BugPattern abbrev="EXS" type="EXS_EXCEPTION_SOFTENING_NO_CONSTRAINTS" category="STYLE" />
 	<BugPattern abbrev="EXS" type="EXS_EXCEPTION_SOFTENING_HAS_CHECKED" category="STYLE" />
 	<BugPattern abbrev="EXS" type="EXS_EXCEPTION_SOFTENING_NO_CHECKED" category="STYLE" />
-	<BugPattern abbrev="CFS" type="CFS_CONFUSING_FUNCTION_SEMANTICS" category="STYLE" experimental="true" />
-	<BugPattern abbrev="JAO" type="JAO_JUNIT_ASSERTION_ODDITIES_ACTUAL_CONSTANT" category="STYLE" experimental="true" />
-	<BugPattern abbrev="JAO" type="JAO_JUNIT_ASSERTION_ODDITIES_INEXACT_DOUBLE" category="STYLE" experimental="true" />
-	<BugPattern abbrev="JAO" type="JAO_JUNIT_ASSERTION_ODDITIES_BOOLEAN_ASSERT" category="STYLE" experimental="true" />
-	<BugPattern abbrev="SCA" type="SCA_SUSPICIOUS_CLONE_ALGORITHM" category="CORRECTNESS" experimental="true" />
-	<BugPattern abbrev="WEM" type="WEM_WEAK_EXCEPTION_MESSAGING" category="STYLE" experimental="true" />
+	<BugPattern abbrev="CFS" type="CFS_CONFUSING_FUNCTION_SEMANTICS" category="STYLE" />
+	<BugPattern abbrev="JAO" type="JAO_JUNIT_ASSERTION_ODDITIES_ACTUAL_CONSTANT" category="STYLE" />
+	<BugPattern abbrev="JAO" type="JAO_JUNIT_ASSERTION_ODDITIES_INEXACT_DOUBLE" category="STYLE" />
+	<BugPattern abbrev="JAO" type="JAO_JUNIT_ASSERTION_ODDITIES_BOOLEAN_ASSERT" category="STYLE" />
+	<BugPattern abbrev="SCA" type="SCA_SUSPICIOUS_CLONE_ALGORITHM" category="CORRECTNESS" />
+	<BugPattern abbrev="WEM" type="WEM_WEAK_EXCEPTION_MESSAGING" category="STYLE" />
 	<BugPattern abbrev="SCSS" type="SCSS_SUSPICIOUS_CLUSTERED_SESSION_SUPPORT" category="CORRECTNESS" experimental="true" />
+	<BugPattern abbrev="LO" type="LO_SUSPECT_LOG_CLASS" category="CORRECTNESS" experimental="true" />
 </FindbugsPlugin>
\ No newline at end of file

Modified: trunk/fb-contrib/etc/messages.xml
===================================================================
--- trunk/fb-contrib/etc/messages.xml	2008-08-08 05:18:21 UTC (rev 1063)
+++ trunk/fb-contrib/etc/messages.xml	2008-08-08 05:31:36 UTC (rev 1064)
@@ -880,6 +880,16 @@
 		</Details>
 	</Detector>
 	
+	<Detector class="com.mebigfatguy.fbcontrib.detect.LoggerOddities">
+		<Details>
+			<![CDATA[
+			<p>looks for code that allocates a Logger object by passing a specification of a class that
+			is not related to the class in which the logger is used.</p>
+			<p>It is a fast detector</p>
+			]]>
+		</Details>
+	</Detector>
+	
 	<!-- BugPattern -->	
 	                
 	<BugPattern type="ISB_INEFFICIENT_STRING_BUFFERING">
@@ -2277,6 +2287,17 @@
 		</Details>
 	</BugPattern>
 	
+	<BugPattern type="LO_SUSPECT_LOG_CLASS">
+		<ShortDescription>method specifies an unrelated class when allocating a Logger</ShortDescription>
+		<LongDescription>method {1} specifies an unrelated class when allocating a Logger</LongDescription>
+		<Details>
+			<![CDATA[
+			<p>This method creates a Logger by passing in a specification for a class that is unrelated
+			to the class in which the logger is going to be used. This is likely caused by copy/paste code.
+			]]>
+		</Details>
+	</BugPattern>
+	
 	<!-- BugCode -->
 	
 	<BugCode abbrev="ISB">Inefficient String Buffering</BugCode>
@@ -2351,4 +2372,5 @@
 	<BugCode abbrev="SCA">Suspicious Clone Algorithm</BugCode>
 	<BugCode abbrev="WEM">Weak Exception Messaging</BugCode>
 	<BugCode abbrev="SCSS">Suspicious Clustered Session Support</BugCode>
+	<BugCode abbrev="LO">Logger Oddities</BugCode>
 </MessageCollection>
\ No newline at end of file


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.