[Fb-contrib-commit] SF.net SVN: fb-contrib: [1030] trunk/fb-contrib/etc

[<dbr...@us...>]

Revision: 1030
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1030&view=rev
Author:   dbrosius
Date:     2008-06-02 00:31:29 -0700 (Mon, 02 Jun 2008)

Log Message:
-----------
Initial checkin of SCSS detector - not even close to working

Modified Paths:
--------------
    trunk/fb-contrib/etc/findbugs.xml
    trunk/fb-contrib/etc/messages.xml

Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================
--- trunk/fb-contrib/etc/findbugs.xml	2008-06-02 07:04:19 UTC (rev 1029)
+++ trunk/fb-contrib/etc/findbugs.xml	2008-06-02 07:31:29 UTC (rev 1030)
@@ -316,6 +316,10 @@
 			speed="fast"
 			reports="WEM_WEAK_EXCEPTION_MESSAGING" />
 			
+	<Detector class="com.mebigfatguy.fbcontrib.detect.SuspiciousClusteredSessionSupport"
+			speed="fast"
+			reports="SCSS_SUSPICIOUS_CLUSTERED_SESSION_SUPPORT" />
+			
    	<!-- BugPattern -->
 	
 	<BugPattern abbrev="ISB" type="ISB_INEFFICIENT_STRING_BUFFERING" category="PERFORMANCE" />
@@ -421,4 +425,5 @@
 	<BugPattern abbrev="JAO" type="JAO_JUNIT_ASSERTION_ODDITIES_BOOLEAN_ASSERT" category="STYLE" experimental="true" />
 	<BugPattern abbrev="SCA" type="SCA_SUSPICIOUS_CLONE_ALGORITHM" category="CORRECTNESS" experimental="true" />
 	<BugPattern abbrev="WEM" type="WEM_WEAK_EXCEPTION_MESSAGING" category="STYLE" experimental="true" />
+	<BugPattern abbrev="SCSS" type="SCSS_SUSPICIOUS_CLUSTERED_SESSION_SUPPORT" category="CORRECTNESS" experimental="true" />
 </FindbugsPlugin>
\ No newline at end of file

Modified: trunk/fb-contrib/etc/messages.xml
===================================================================
--- trunk/fb-contrib/etc/messages.xml	2008-06-02 07:04:19 UTC (rev 1029)
+++ trunk/fb-contrib/etc/messages.xml	2008-06-02 07:31:29 UTC (rev 1030)
@@ -863,12 +863,22 @@
 			<![CDATA[
 			<p>looks for exceptions that are thrown with static strings as messages. Using static strings
 			doesn't differentiate one use of this method versus another, and so it may be difficult
-			to determine how this exception occurred without showing context.<p>
+			to determine how this exception occurred without showing context.</p>
 			<p>It is a fast detector</p>
 			]]>
 		</Details>
 	</Detector>
 				
+	<Detector class="com.mebigfatguy.fbcontrib.detect.SuspiciousClusteredSessionSupport">
+		<Details>
+			<![CDATA[
+			<p>looks for code that fetches a complex object from an HttpSession attribute, modifies the
+			object, but does not call setAttribute again on this object. This will not inform the application server
+			that this object has changed, and thus will not correctly replicate these changes across the cluster.</p>
+			<p>It is a fast detector</p>
+			]]>
+		</Details>
+	</Detector>
 	
 	<!-- BugPattern -->	
 	                
@@ -2232,6 +2242,19 @@
 		</Details>
 	</BugPattern>
 	
+	<BugPattern type="SCSS_SUSPICIOUS_CLUSTERED_SESSION_SUPPORT">
+		<ShortDescription>method modifies http session attribute without calling setAttribute</ShortDescription>
+		<LongDescription>method {1} modifies http session attribute without calling setAttribute</LongDescription>
+		<Details>
+			<![CDATA[
+			<p>This method fetches a complex object from an HttpSession object, modifies this object, but does
+			not call setAttribute, to inform the application server that this attribute has been changed. This will
+			cause this attribute not to be updated in other servers in a clustered environment, as only changes marked
+			by a call to setAttribute are replicated.</p>
+			]]>
+		</Details>
+	</BugPattern>
+	
 	<!-- BugCode -->
 	
 	<BugCode abbrev="ISB">Inefficient String Buffering</BugCode>
@@ -2305,4 +2328,5 @@
 	<BugCode abbrev="JAO">JUnit Assertion Oddities</BugCode>
 	<BugCode abbrev="SCA">Suspicious Clone Algorithm</BugCode>
 	<BugCode abbrev="WEM">Weak Exception Messaging</BugCode>
+	<BugCode abbrev="SCSS">Suspicious Clustered Session Support</BugCode>
 </MessageCollection>
\ No newline at end of file


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.