[Fb-contrib-commit] SF.net SVN: fb-contrib: [998] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/SuspiciousComparatorReturnValues.java

[<dbr...@us...>]

Revision: 998
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=998&view=rev
Author:   dbrosius
Date:     2008-03-13 21:58:39 -0700 (Thu, 13 Mar 2008)

Log Message:
-----------
fix for [ 1913611 ] FalsePositve SCRV Suspicious Comparator Return Values, assume that trinaries are indeterminate

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousComparatorReturnValues.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousComparatorReturnValues.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousComparatorReturnValues.java	2008-03-14 04:38:15 UTC (rev 997)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousComparatorReturnValues.java	2008-03-14 04:58:39 UTC (rev 998)
@@ -133,6 +133,9 @@
 					}
 				} else
 					indeterminate = true;
+			} else if ((seen == GOTO) || (seen == GOTO_W)) {
+				if (stack.getStackDepth() > 0)
+					indeterminate = true;
 			}
 		} finally {
 			stack.sawOpcode(this, seen);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.