[Fb-contrib-commit] SF.net SVN: fb-contrib: [992] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/UseAddAll.java

[<dbr...@us...>]

Revision: 992
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=992&view=rev
Author:   dbrosius
Date:     2008-03-08 19:46:50 -0800 (Sat, 08 Mar 2008)

Log Message:
-----------
Fix for 1909543: Check the result of add for a following POP and only report if the POP is seen. 

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseAddAll.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseAddAll.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseAddAll.java	2008-03-09 03:42:54 UTC (rev 991)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseAddAll.java	2008-03-09 03:46:50 UTC (rev 992)
@@ -168,10 +168,12 @@
 							if (uValue != null) {
 								LoopInfo loop = loops.get(uValue);
 								if ((loop != null) && loop.isInLoop(getPC(), false)) {
-									bugReporter.reportBug(new BugInstance(this, "UAA_USE_ADD_ALL", NORMAL_PRIORITY)
-									.addClass(this)
-									.addMethod(this)
-									.addSourceLine(this));
+									if (this.getCodeByte(getNextPC()) == POP) {
+										bugReporter.reportBug(new BugInstance(this, "UAA_USE_ADD_ALL", NORMAL_PRIORITY)
+										.addClass(this)
+										.addMethod(this)
+										.addSourceLine(this));
+									}
 								}
 							}
 						} else {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.